Skip to content

Commit 3b205f2

Browse files
committed
fixes query
1 parent 651a860 commit 3b205f2

File tree

4 files changed

+32
-32
lines changed

4 files changed

+32
-32
lines changed

hazelcast-driver/src/main/java/org/jnosql/diana/hazelcast/key/DefaultHazelcastBucketManager.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,14 @@ public void close() {
9999
}
100100

101101
@Override
102-
public Collection<Value> query(String query) throws NullPointerException {
103-
requireNonNull(query, "query is required");
104-
return query(new SqlPredicate(query));
102+
public Collection<Value> sql(String query) throws NullPointerException {
103+
requireNonNull(query, "sql is required");
104+
return sql(new SqlPredicate(query));
105105
}
106106

107107
@Override
108-
public Collection<Value> query(String query, Map<String, Object> params) throws NullPointerException {
109-
requireNonNull(query, "query is required");
108+
public Collection<Value> sql(String query, Map<String, Object> params) throws NullPointerException {
109+
requireNonNull(query, "sql is required");
110110
requireNonNull(params, "params is required");
111111
final StringBuilder finalQuery = new StringBuilder(query);
112112
final Consumer<Map.Entry<String, Object>> consumer = e -> {
@@ -115,11 +115,11 @@ public Collection<Value> query(String query, Map<String, Object> params) throws
115115
finalQuery.replace(indexOf, indexOf + key.length(), e.getValue().toString());
116116
};
117117
params.entrySet().forEach(consumer);
118-
return query(new SqlPredicate(finalQuery.toString()));
118+
return sql(new SqlPredicate(finalQuery.toString()));
119119
}
120120

121121
@Override
122-
public <K, V> Collection<Value> query(Predicate<K, V> predicate) throws NullPointerException {
122+
public <K, V> Collection<Value> sql(Predicate<K, V> predicate) throws NullPointerException {
123123
requireNonNull(predicate, "predicate is required");
124124
Collection<V> values = map.values(predicate);
125125
return values.stream().map(Value::of).collect(toList());

hazelcast-driver/src/main/java/org/jnosql/diana/hazelcast/key/HazelcastBucketManager.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -29,34 +29,34 @@ public interface HazelcastBucketManager extends BucketManager {
2929

3030

3131
/**
32-
* Executes hazelcast query
32+
* Executes hazelcast sql
3333
*
34-
* @param query the query
35-
* @return the result query
36-
* @throws NullPointerException when there is null query
34+
* @param query the sql
35+
* @return the result sql
36+
* @throws NullPointerException when there is null sql
3737
*/
38-
Collection<Value> query(String query);
38+
Collection<Value> sql(String query);
3939

4040
/**
41-
* Executes hazelcast query with named query.
42-
* E.g.: bucketManager.query("name = :name", singletonMap("name", "Matrix"))
41+
* Executes hazelcast sql with named sql.
42+
* E.g.: bucketManager.sql("name = :name", singletonMap("name", "Matrix"))
4343
*
44-
* @param query the query
44+
* @param query the sql
4545
* @param params the params to bind
46-
* @return the result query
47-
* @throws NullPointerException when there is null query
46+
* @return the result sql
47+
* @throws NullPointerException when there is null sql
4848
*/
49-
Collection<Value> query(String query, Map<String, Object> params);
49+
Collection<Value> sql(String query, Map<String, Object> params);
5050

5151
/**
52-
* Executes hazelcast query
52+
* Executes hazelcast sql
5353
*
5454
* @param predicate the hazelcast predicate
5555
* @param <K> the key type
5656
* @param <V> the value type
57-
* @return the result query
57+
* @return the result sql
5858
* @throws NullPointerException when there is null predicate
5959
*/
60-
<K, V> Collection<Value> query(Predicate<K, V> predicate);
60+
<K, V> Collection<Value> sql(Predicate<K, V> predicate);
6161

6262
}

hazelcast-driver/src/main/java/org/jnosql/diana/hazelcast/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* scaling of processing and available storage. Backups are also distributed among nodes to protect against failure
2121
* of any single node. Hazelcast provides central, predictable scaling of applications through in-memory
2222
* access to frequently used data and across an elastically scalable data grid. These techniques reduce
23-
* the query load on databases and improve speed.
23+
* the sql load on databases and improve speed.
2424
* Hazelcast can run on-premise, in the cloud (Amazon Web Services,
2525
* Microsoft Azure, Cloud Foundry, OpenShift), virtually (VMWare),
2626
* and in Docker containers. Hazelcast offers technology integrations for multiple cloud configuration and deployment

hazelcast-driver/src/test/java/org/jnosql/diana/hazelcast/key/HazelcastBucketManagerQueryTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,51 +60,51 @@ public void shouldReturnWhenStringQueryIsNull() {
6060

6161
@Test
6262
public void shouldReturnWhenPredicateQueryIsNull() {
63-
assertThrows(NullPointerException.class, () -> bucketManager.query((Predicate<? extends Object, ? extends Object>) null));
63+
assertThrows(NullPointerException.class, () -> bucketManager.sql((Predicate<? extends Object, ? extends Object>) null));
6464
}
6565

6666
@Test
6767
public void shouldReturnActive() {
68-
Collection<Value> result = bucketManager.query("active");
68+
Collection<Value> result = bucketManager.sql("active");
6969
assertEquals(2, result.size());
7070
}
7171

7272
@Test
7373
public void shouldReturnActiveAndGreaterThan2000() {
74-
Collection<Value> result = bucketManager.query("NOT active AND year > 1990");
74+
Collection<Value> result = bucketManager.sql("NOT active AND year > 1990");
7575
assertEquals(2, result.size());
7676
}
7777

7878
@Test
7979
public void shouldReturnEqualsMatrix() {
80-
Collection<Value> result = bucketManager.query("name = Matrix");
80+
Collection<Value> result = bucketManager.sql("name = Matrix");
8181
assertEquals(1, result.size());
8282
}
8383

8484

8585
@Test
8686
public void shouldReturnActivePredicate() {
87-
Collection<Value> result = bucketManager.query(equal("active", true));
87+
Collection<Value> result = bucketManager.sql(equal("active", true));
8888
assertEquals(2, result.size());
8989
}
9090

9191
@Test
9292
public void shouldReturnActiveAndGreaterThan2000Predicate() {
9393
Predicate predicate = and(equal("active", false), greaterEqual("year", 1990));
94-
Collection<Value> result = bucketManager.query(predicate);
94+
Collection<Value> result = bucketManager.sql(predicate);
9595
assertEquals(2, result.size());
9696
}
9797

9898
@Test
9999
public void shouldReturnEqualsMatrixPredicate() {
100100
Predicate predicate = equal("name", "Matrix");
101-
Collection<Value> result = bucketManager.query(predicate);
101+
Collection<Value> result = bucketManager.sql(predicate);
102102
assertEquals(1, result.size());
103103
}
104104

105105
@Test
106106
public void shouldReturnEqualsNameParam() {
107-
Collection<Value> result = bucketManager.query("name = :name", singletonMap("name", "Matrix"));
107+
Collection<Value> result = bucketManager.sql("name = :name", singletonMap("name", "Matrix"));
108108
assertEquals(1, result.size());
109109
}
110110

@@ -113,14 +113,14 @@ public void shouldReturnNameAndYearParam() {
113113
Map<String, Object> params = new HashMap<>();
114114
params.put("name", "Matrix");
115115
params.put("year", 1900);
116-
Collection<Value> result = bucketManager.query("name = :name AND year > :year", params);
116+
Collection<Value> result = bucketManager.sql("name = :name AND year > :year", params);
117117

118118
assertEquals(1, result.size());
119119
}
120120

121121
@Test
122122
public void shouldReturnLikeNameParam() {
123-
Collection<Value> result = bucketManager.query("name like :name", singletonMap("name", "Mat%"));
123+
Collection<Value> result = bucketManager.sql("name like :name", singletonMap("name", "Mat%"));
124124
assertEquals(1, result.size());
125125
}
126126

0 commit comments

Comments
 (0)