test: improve assertions and add count query test

Refactored assertions to use assertSoftly for better readability
and added a new test to verify count queries with specific
conditions in the OracleNoSQLDocumentManagerTest.

Signed-off-by: Maximillian Arruda <[email protected]>

Author: dearrudam

jnosql-oracle-nosql/src/test/java/org/eclipse/jnosql/databases/oracle/communication/OracleNoSQLDocumentManagerTest.java

@@ -14,7 +14,6 @@
  */
 package org.eclipse.jnosql.databases.oracle.communication;
 
-import org.assertj.core.api.SoftAssertions;
 import org.eclipse.jnosql.communication.TypeReference;
 import org.eclipse.jnosql.communication.semistructured.CommunicationEntity;
 import org.eclipse.jnosql.communication.semistructured.CriteriaCondition;
@@ -209,12 +208,12 @@ void shouldFindDocumentLesserThan() {
 
         List<CommunicationEntity> entitiesFound = entityManager.select(query).toList();
 
-        SoftAssertions.assertSoftly(soft -> {
+        assertSoftly(soft -> {
             soft.assertThat(entitiesFound).hasSize(1);
 
             List<String> namesFound = entitiesFound.stream()
                     .flatMap(d -> d.find("name").stream())
-                    .map(d-> d.get(String.class))
+                    .map(d -> d.get(String.class))
                     .toList();
             soft.assertThat(namesFound).contains("Lucas");
         });
@@ -252,11 +251,11 @@ void shouldFindDocumentIn() {
             soft.assertThat(entitiesFound).hasSize(entities.size());
             List<String> namesFound = entitiesFound.stream()
                     .flatMap(d -> d.find("name").stream())
-                    .map(d-> d.get(String.class))
+                    .map(d -> d.get(String.class))
                     .toList();
             List<String> names = entities.stream()
                     .flatMap(d -> d.find("name").stream())
-                    .map(d-> d.get(String.class))
+                    .map(d -> d.get(String.class))
                     .toList();
             soft.assertThat(namesFound).containsAll(names);
         });
@@ -463,7 +462,7 @@ void shouldCreateDate() {
 
         assertEquals(1, entities.size());
         var documentEntity = entities.get(0);
-        assertSoftly(soft ->{
+        assertSoftly(soft -> {
             soft.assertThat(id).isEqualTo(documentEntity.find("_id").orElseThrow().get(Long.class));
             soft.assertThat(now).isEqualTo(documentEntity.find("now").orElseThrow().get(LocalDate.class));
         });
@@ -498,7 +497,27 @@ void shouldCount() {
         assertTrue(entityManager.count(COLLECTION_NAME) > 0);
     }
 
+    @Test
+    void shouldCountWithSelectQuery() {
+        Iterable<CommunicationEntity> entitiesSaved = entityManager.insert(getEntitiesWithValues());
+        List<CommunicationEntity> entities = StreamSupport.stream(entitiesSaved.spliterator(), false).toList();
+
+        assertSoftly(softly -> {
+            softly.assertThat(entityManager.count(
+                    select().from(COLLECTION_NAME)
+                            .where("age").gt(22)
+                            .and("type").eq("V")
+                            .build()
+            )).isEqualTo(2);
+
+            softly.assertThat(entityManager.count(
+                    select().from(COLLECTION_NAME)
+                            .where("name").eq("Otavio")
+                            .build()
+            )).isEqualTo(1);
+        });
 
+    }
 
     @Test
     void shouldSaveMap() {
@@ -532,7 +551,7 @@ void shouldInsertNull() {
     }
 
     @Test
-    void shouldUpdateNull(){
+    void shouldUpdateNull() {
         var entity = entityManager.insert(getEntity());
         entity.add(Element.of("name", null));
         var documentEntity = entityManager.update(entity);
@@ -545,7 +564,7 @@ void shouldUpdateNull(){
     }
 
     @Test
-    void shouldQuery(){
+    void shouldQuery() {
         entityManager.insert(getEntity());
 
         var query = "select * from database where database.content.name = 'Poliana'";
@@ -556,7 +575,7 @@ void shouldQuery(){
     }
 
     @Test
-    void shouldQueryParams(){
+    void shouldQueryParams() {
         entityManager.insert(getEntity());
 
         var query = "select * from database where database.content.name = ?";
@@ -578,7 +597,7 @@ void shouldInsertAndRetrieveWithEnum() {
         var query = select().from(COLLECTION_NAME)
                 .where("_id").eq(id).build();
         Optional<CommunicationEntity> optional = entityManager.select(query).findFirst();
-       SoftAssertions.assertSoftly(soft -> {
+        assertSoftly(soft -> {
             soft.assertThat(optional).isPresent();
             CommunicationEntity documentEntity = optional.get();
             soft.assertThat(documentEntity.find("name").orElseThrow().get(String.class)).isEqualTo("Test Name");
@@ -599,7 +618,7 @@ void shouldDoQueryUsingEnumAsParameter() {
         var query = select().from(COLLECTION_NAME)
                 .where("contact_type").eq(ContactType.EMAIL).build();
         Optional<CommunicationEntity> optional = entityManager.select(query).findFirst();
-        SoftAssertions.assertSoftly(soft -> {
+        assertSoftly(soft -> {
             soft.assertThat(optional).isPresent();
             CommunicationEntity documentEntity = optional.get();
             soft.assertThat(documentEntity.find("name").orElseThrow().get(String.class)).isEqualTo("Test Name");
@@ -622,7 +641,7 @@ void shouldFindDocumentLike() {
 
         List<CommunicationEntity> entitiesFound = entityManager.select(query).collect(Collectors.toList());
 
-        SoftAssertions.assertSoftly(soft -> {
+        assertSoftly(soft -> {
             soft.assertThat(entitiesFound).hasSize(2);
             var names = entitiesFound.stream()
                     .flatMap(d -> d.find("name").stream())
@@ -642,7 +661,7 @@ void shouldFindContains() {
                 "lia")), COLLECTION_NAME, Collections.emptyList());
 
         var result = entityManager.select(query).toList();
-        SoftAssertions.assertSoftly(softly -> {
+        assertSoftly(softly -> {
             softly.assertThat(result).hasSize(1);
             softly.assertThat(result.get(0).find("name").orElseThrow().get(String.class)).isEqualTo("Poliana");
         });
@@ -657,7 +676,7 @@ void shouldStartsWith() {
                 "Pol")), COLLECTION_NAME, Collections.emptyList());
 
         var result = entityManager.select(query).toList();
-        SoftAssertions.assertSoftly(softly -> {
+        assertSoftly(softly -> {
             softly.assertThat(result).hasSize(1);
             softly.assertThat(result.get(0).find("name").orElseThrow().get(String.class)).isEqualTo("Poliana");
         });
@@ -672,7 +691,7 @@ void shouldEndsWith() {
                 "ana")), COLLECTION_NAME, Collections.emptyList());
 
         var result = entityManager.select(query).toList();
-        SoftAssertions.assertSoftly(softly -> {
+        assertSoftly(softly -> {
             softly.assertThat(result).hasSize(1);
             softly.assertThat(result.get(0).find("name").orElseThrow().get(String.class)).isEqualTo("Poliana");
         });