fix: fix delete method by integration test

Signed-off-by: Otavio Santana <[email protected]>

Author: otaviojava

jnosql-orientdb/src/main/java/org/eclipse/jnosql/databases/orientdb/communication/DefaultOrientDBDocumentManager.java

@@ -141,11 +141,18 @@ public void delete(DocumentDeleteQuery query) {
         DocumentQuery selectQuery = new OrientDBDocumentQuery(query);
         QueryOSQLFactory.QueryResult orientQuery = QueryOSQLFactory.to(selectQuery);
 
-        try (ODatabaseSession tx = pool.acquire();
-             OResultSet resultSet = tx.command(orientQuery.getQuery(), orientQuery.getParams())) {
-            while (resultSet.hasNext()) {
-                OResult next = resultSet.next();
-                tx.delete(next.toElement().getIdentity());
+        try (ODatabaseSession tx = pool.acquire()) {
+
+            if (orientQuery.isRunQuery()) {
+                try (OResultSet resultSet = tx.command(orientQuery.getQuery(), orientQuery.getParams())) {
+                    while (resultSet.hasNext()) {
+                        OResult result = resultSet.next();
+                        tx.delete(result.toElement().getIdentity());
+                    }
+                }
+            }
+            if (orientQuery.isLoad()) {
+                orientQuery.getIds().forEach(tx::delete);
             }
         }
 
@@ -167,6 +174,7 @@ public Stream<DocumentEntity> select(DocumentQuery query) {
             if (orientQuery.isLoad()) {
                 orientQuery.getIds().stream().map(tx::load)
                         .map(o -> OrientDBConverter.convert((ODocument) o))
+                        .filter(Objects::nonNull)
                         .forEach(entities::add);
             }
             return entities.stream();

jnosql-orientdb/src/main/java/org/eclipse/jnosql/databases/orientdb/communication/OrientDBConverter.java

@@ -72,12 +72,15 @@ static DocumentEntity convert(OResult row) {
         long clusterPosition = identity.getClusterPosition();
         entity.add(VERSION_FIELD, element.getVersion());
         entity.add(RID_FIELD, "#" + clusterId + ":" + clusterPosition);
-        entity.add(ID_FIELD,  "#" + clusterId + ":" + clusterPosition);
+        entity.add(ID_FIELD, "#" + clusterId + ":" + clusterPosition);
         return entity;
     }
 
 
     static DocumentEntity convert(ODocument document) {
+        if (document == null) {
+            return null;
+        }
         DocumentEntity entity = DocumentEntity.of(document.getClassName());
         Stream.of(document.fieldNames())
                 .map(f -> Document.of(f, convert((Object) document.field(f))))

jnosql-orientdb/src/test/java/org/eclipse/jnosql/databases/orientdb/integration/OrientDBTemplateIntegrationTest.java

@@ -102,7 +102,6 @@ public void shouldDelete() {
         assertThat(template.insert(book))
                 .isNotNull()
                 .isEqualTo(book);
-
         template.delete(Book.class, book.id());
         assertThat(template.find(Book.class, book.id()))
                 .isNotNull().isEmpty();