Skip to content

Commit 5ef0d6d

Browse files
committed
feat: update Neo4J query builder to use count queries
Refactored Neo4JQueryBuilderTest to utilize the new buildCountQuery method for generating count queries, ensuring accurate query construction for counting entities. Signed-off-by: Maximillian Arruda <[email protected]>
1 parent 7565439 commit 5ef0d6d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

jnosql-neo4j/src/main/java/org/eclipse/jnosql/databases/neo4j/communication/Neo4JQueryBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ String buildQuery(SelectQuery query, Map<String, Object> parameters) {
8585

8686
String buildCountQuery(SelectQuery query, Map<String, Object> parameters) {
8787
StringBuilder cypher = buildCypher(query.name(), query.condition(), parameters);
88-
cypher.append(" RETURN COUNT(e) AS count");
88+
cypher.append(" RETURN COUNT(e)");
8989
return cypher.toString();
9090
}
9191

jnosql-neo4j/src/test/java/org/eclipse/jnosql/databases/neo4j/communication/Neo4JQueryBuilderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ void shouldBuildCountQueryWithCondition() {
107107
when(query.columns()).thenReturn(List.of());
108108

109109
Map<String, Object> parameters = new HashMap<>();
110-
String cypher = Neo4JQueryBuilder.INSTANCE.buildQuery(query, parameters);
110+
String cypher = Neo4JQueryBuilder.INSTANCE.buildCountQuery(query, parameters);
111111

112112
assertThat(cypher).isEqualTo("MATCH (e:Person) WHERE e.age = $age RETURN COUNT(e)");
113113
assertThat(parameters).containsEntry("age", 30);
@@ -121,7 +121,7 @@ void shouldBuildCountQueryWithoutCondition() {
121121
when(query.columns()).thenReturn(List.of());
122122

123123
Map<String, Object> parameters = new HashMap<>();
124-
String cypher = Neo4JQueryBuilder.INSTANCE.buildQuery(query, parameters);
124+
String cypher = Neo4JQueryBuilder.INSTANCE.buildCountQuery(query, parameters);
125125

126126
assertThat(cypher).isEqualTo("MATCH (e:Person) RETURN COUNT(e)");
127127
}

0 commit comments

Comments
 (0)