Skip to content

Commit 7977fd2

Browse files
authored
Merge pull request #147 from eclipse/remove_key
Updates key-value api
2 parents f4cf0f0 + 98bb887 commit 7977fd2

File tree

23 files changed

+57
-56
lines changed

23 files changed

+57
-56
lines changed

arangodb-driver/src/main/java/org/eclipse/jnosql/diana/arangodb/keyvalue/ArangoDBBucketManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@ public <K> Iterable<Value> get(Iterable<K> keys) throws NullPointerException {
108108
}
109109

110110
@Override
111-
public <K> void remove(K key) throws NullPointerException {
111+
public <K> void delete(K key) throws NullPointerException {
112112
arangoDB.db(bucketName).collection(namespace).deleteDocument(key.toString());
113113
}
114114

115115
@Override
116-
public <K> void remove(Iterable<K> keys) throws NullPointerException {
116+
public <K> void delete(Iterable<K> keys) throws NullPointerException {
117117
Objects.requireNonNull(keys, "Keys is required");
118118

119119
arangoDB.db(bucketName).collection(namespace)

arangodb-driver/src/test/java/org/eclipse/jnosql/diana/arangodb/keyvalue/ArangoDBKeyValueEntityManagerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public void shouldRemoveKey() {
9898

9999
keyValueEntityManager.put(keyValueOtavio);
100100
assertTrue(keyValueEntityManager.get("otavio").isPresent());
101-
keyValueEntityManager.remove("otavio");
101+
keyValueEntityManager.delete("otavio");
102102
assertFalse(keyValueEntityManager.get("otavio").isPresent());
103103
}
104104

@@ -109,7 +109,7 @@ public void shouldRemoveMultiKey() {
109109
List<String> keys = asList("otavio", "soro");
110110
Iterable<Value> values = keyValueEntityManager.get(keys);
111111
assertThat(StreamSupport.stream(values.spliterator(), false).map(value -> value.get(User.class)).collect(Collectors.toList()), containsInAnyOrder(userOtavio, userSoro));
112-
keyValueEntityManager.remove(keys);
112+
keyValueEntityManager.delete(keys);
113113
Iterable<Value> users = values;
114114
assertEquals(0L, StreamSupport.stream(keyValueEntityManager.get(keys).spliterator(), false).count());
115115
}

couchbase-driver/src/main/java/org/eclipse/jnosql/diana/couchbase/keyvalue/CouchbaseBucketManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public <K> Iterable<Value> get(Iterable<K> keys) {
129129
}
130130

131131
@Override
132-
public <K> void remove(K key) {
132+
public <K> void delete(K key) {
133133
requireNonNull(key, "key is required");
134134
try {
135135
bucket.remove(key.toString());
@@ -139,9 +139,9 @@ public <K> void remove(K key) {
139139
}
140140

141141
@Override
142-
public <K> void remove(Iterable<K> keys) {
142+
public <K> void delete(Iterable<K> keys) {
143143
requireNonNull(keys, "keys is required");
144-
keys.forEach(this::remove);
144+
keys.forEach(this::delete);
145145
}
146146

147147
@Override

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/document/CouchbaseDocumentCollectionManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static void afterClass() {
6969
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
7070
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
7171
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
72-
keyValueEntityManager.remove("person:id");
72+
keyValueEntityManager.delete("person:id");
7373
}
7474

7575
@Test

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/document/DocumentQueryTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ public static void afterClass() {
5757
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
5858
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
5959
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
60-
keyValueEntityManager.remove("person:id");
61-
keyValueEntityManager.remove("person:id2");
62-
keyValueEntityManager.remove("person:id3");
63-
keyValueEntityManager.remove("person:id4");
60+
keyValueEntityManager.delete("person:id");
61+
keyValueEntityManager.delete("person:id2");
62+
keyValueEntityManager.delete("person:id3");
63+
keyValueEntityManager.delete("person:id4");
6464
}
6565

6666
@BeforeAll

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/document/SearchQueryTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ public static void afterClass() {
5353
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
5454
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
5555
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
56-
keyValueEntityManager.remove("city:salvador");
57-
keyValueEntityManager.remove("city:sao_paulo");
58-
keyValueEntityManager.remove("city:rio_janeiro");
59-
keyValueEntityManager.remove("city:manaus");
56+
keyValueEntityManager.delete("city:salvador");
57+
keyValueEntityManager.delete("city:sao_paulo");
58+
keyValueEntityManager.delete("city:rio_janeiro");
59+
keyValueEntityManager.delete("city:manaus");
6060
}
6161

6262
@BeforeAll

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/keyvalue/CouchbaseBucketManagerTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ public static void afterClass() {
6565
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
6666
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
6767
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
68-
keyValueEntityManager.remove(KEY_OTAVIO);
69-
keyValueEntityManager.remove(KEY_SORO);
68+
keyValueEntityManager.delete(KEY_OTAVIO);
69+
keyValueEntityManager.delete(KEY_SORO);
7070
}
7171

7272

@@ -165,7 +165,7 @@ public void shouldRemoveKey() {
165165

166166
keyValueEntityManager.put(entityOtavio);
167167
assertTrue(keyValueEntityManager.get(KEY_OTAVIO).isPresent());
168-
keyValueEntityManager.remove(KEY_OTAVIO);
168+
keyValueEntityManager.delete(KEY_OTAVIO);
169169
assertFalse(keyValueEntityManager.get(KEY_OTAVIO).isPresent());
170170
}
171171

@@ -176,7 +176,7 @@ public void shouldRemoveMultiKey() {
176176
List<String> keys = asList(KEY_OTAVIO, KEY_SORO);
177177
Iterable<Value> values = keyValueEntityManager.get(keys);
178178
assertThat(StreamSupport.stream(values.spliterator(), false).map(value -> value.get(User.class)).collect(Collectors.toList()), containsInAnyOrder(userOtavio, userSoro));
179-
keyValueEntityManager.remove(keys);
179+
keyValueEntityManager.delete(keys);
180180
Iterable<Value> users = values;
181181
assertEquals(0L, StreamSupport.stream(keyValueEntityManager.get(keys).spliterator(), false).count());
182182
}

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/keyvalue/CouchbaseListTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public static void afterClass() {
6464
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
6565
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
6666
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
67-
keyValueEntityManager.remove("jnosql:list");
67+
keyValueEntityManager.delete("jnosql:list");
6868
}
6969

7070
@AfterEach

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/keyvalue/CouchbaseMapTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public static void afterClass() {
5050
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
5151
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
5252
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
53-
keyValueEntityManager.remove("jnosql:map");
53+
keyValueEntityManager.delete("jnosql:map");
5454
}
5555

5656
@Test

couchbase-driver/src/test/java/org/eclipse/jnosql/diana/couchbase/keyvalue/CouchbaseQueueTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public static void afterClass() {
5757
CouchbaseKeyValueConfiguration configuration = CouchbaseKeyValueTcConfiguration.getTcConfiguration();
5858
BucketManagerFactory keyValueEntityManagerFactory = configuration.get();
5959
BucketManager keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager(CouchbaseUtil.BUCKET_NAME);
60-
keyValueEntityManager.remove("jnosql:queue");
60+
keyValueEntityManager.delete("jnosql:queue");
6161
}
6262

6363
@Test

0 commit comments

Comments
 (0)