Merge pull request #79 from eclipse/improvements-couchbase

Improvements couchbase

Author: furlaneto

couchbase-driver/src/main/java/org/jnosql/diana/couchbase/key/CouchbaseBucketManager.java

@@ -18,6 +18,7 @@
 import com.couchbase.client.java.Bucket;
 import com.couchbase.client.java.document.JsonDocument;
 import com.couchbase.client.java.document.json.JsonObject;
+import com.couchbase.client.java.error.DocumentDoesNotExistException;
 import org.jnosql.diana.api.Value;
 import org.jnosql.diana.api.key.BucketManager;
 import org.jnosql.diana.api.key.KeyValueEntity;
@@ -28,6 +29,7 @@
 import java.time.Duration;
 import java.util.Objects;
 import java.util.Optional;
+import java.util.logging.Logger;
 
 import static java.util.Objects.requireNonNull;
 import static java.util.concurrent.TimeUnit.MILLISECONDS;
@@ -40,6 +42,8 @@
  */
 public class CouchbaseBucketManager implements BucketManager {
 
+    private static final Logger LOGGER = Logger.getLogger(CouchbaseBucketManager.class.getName());
+
     private static final Jsonb JSONB = JsonbBuilder.create();
 
     private final Bucket bucket;
@@ -113,7 +117,11 @@ public <K> Iterable<Value> get(Iterable<K> keys) throws NullPointerException {
     @Override
     public <K> void remove(K key) throws NullPointerException {
         requireNonNull(key, "key is required");
-        bucket.remove(key.toString());
+        try {
+            bucket.remove(key.toString());
+        } catch (DocumentDoesNotExistException e) {
+            LOGGER.info("Not found any document with the key " + key);
+        }
     }
 
     @Override

couchbase-driver/src/test/java/org/jnosql/diana/couchbase/key/CouchbaseBucketManagerTest.java

@@ -21,7 +21,6 @@
 import org.jnosql.diana.couchbase.CouchbaseUtil;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.time.Duration;
@@ -96,26 +95,24 @@ public void shouldPutValues() {
     }
 
     @Test
-    @Disabled
     public void shouldPutValueTtl() throws InterruptedException {
 
         keyValueEntityManager.put(KeyValueEntity.of(KEY_OTAVIO, userOtavio), Duration.ofSeconds(1L));
 
         Optional<Value> otavio = keyValueEntityManager.get(KEY_OTAVIO);
         assertTrue(otavio.isPresent());
-        Thread.sleep(5_000);
+        Thread.sleep(2_000);
         otavio = keyValueEntityManager.get(KEY_OTAVIO);
         assertFalse(otavio.isPresent());
     }
 
     @Test
-    @Disabled
     public void shouldPutValuesTtl() throws InterruptedException {
 
         keyValueEntityManager.put(singleton(KeyValueEntity.of(KEY_OTAVIO, userOtavio)), Duration.ofSeconds(1L));
         Optional<Value> otavio = keyValueEntityManager.get(KEY_OTAVIO);
         assertTrue(otavio.isPresent());
-        Thread.sleep(5_000);
+        Thread.sleep(2_000);
         otavio = keyValueEntityManager.get(KEY_OTAVIO);
         assertFalse(otavio.isPresent());
     }

couchbase-driver/src/test/java/org/jnosql/diana/couchbase/key/CouchbaseListTest.java

@@ -26,7 +26,14 @@
 import java.math.BigDecimal;
 import java.util.List;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static java.util.Arrays.asList;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.contains;
+import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class CouchbaseListTest {
 
@@ -70,10 +77,89 @@ public void shouldAddList() {
     }
 
     @Test
-    public void shouldRemoveList() {
-        fruits.add(banana);
+    public void shouldAddAllIterable() {
+        fruits.addAll(asList(banana, waterMelon, orange, melon));
+        assertThat(fruits, contains(banana, waterMelon, orange, melon));
     }
 
+    @Test
+    public void shouldAddAllIterableWithIndex() {
+        fruits.addAll(asList(orange, melon));
+        fruits.addAll(1, asList(banana, waterMelon));
+        assertThat(fruits, contains(orange, banana, waterMelon, melon));
+    }
+
+    @Test
+    public void shouldAddWithIndex() {
+        fruits.addAll(asList(banana, waterMelon));
+        fruits.add(0, orange);
+        assertThat(fruits, contains(orange, banana, waterMelon));
+    }
+
+    @Test
+    public void shouldRemove() {
+        fruits.addAll(asList(banana, waterMelon));
+        fruits.remove(banana);
+        assertTrue(fruits.size() == 1);
+        assertEquals(fruits.get(0), waterMelon);
+    }
+
+    @Test
+    public void shouldRemoveWithIndex() {
+        fruits.addAll(asList(banana, waterMelon));
+        fruits.remove(1);
+        assertTrue(fruits.size() == 1);
+        assertEquals(fruits.get(0), banana);
+    }
+
+    @Test
+    public void shouldRemoveAll() {
+        fruits.addAll(asList(banana, waterMelon, orange, melon));
+        fruits.removeAll(asList(banana, melon));
+        assertTrue(fruits.size() == 2);
+        assertThat(fruits, containsInAnyOrder(waterMelon, orange));
+    }
+
+    @Test
+    public void shouldContainsValue() {
+        fruits.addAll(asList(banana, waterMelon));
+        assertTrue(fruits.contains(waterMelon));
+    }
+
+    @Test
+    public void shouldContainsAllValues() {
+        fruits.addAll(asList(banana, waterMelon));
+        assertTrue(fruits.containsAll(asList(waterMelon, banana)));
+    }
+
+    @Test
+    public void shouldReturnIndexOf() {
+        fruits.addAll(asList(banana, waterMelon, banana));
+        assertEquals(0, fruits.indexOf(banana));
+    }
+
+    @Test
+    public void shouldReturnLstIndexOf() {
+        fruits.addAll(asList(banana, waterMelon, banana));
+        assertEquals(2, fruits.lastIndexOf(banana));
+    }
+
+    @Test
+    public void shouldSetValue() {
+        fruits.addAll(asList(banana, waterMelon));
+        assertEquals(fruits.get(1), waterMelon);
+        fruits.set(1, orange);
+        assertTrue(fruits.size() == 2);
+        assertEquals(fruits.get(1), orange);
+    }
+
+    @Test
+    public void shouldReturnSubList() {
+        fruits.addAll(asList(banana, waterMelon, orange, melon));
+        List<ProductCart> subList = fruits.subList(1, 3);
+        assertTrue(subList.size() == 2);
+        assertThat(subList, contains(waterMelon, orange));
+    }
 
     @AfterEach
     public void end() {