Skip to content

Commit aca6e72

Browse files
committed
fixes factory supplier at arangodb
1 parent f59e57e commit aca6e72

File tree

6 files changed

+28
-18
lines changed

6 files changed

+28
-18
lines changed

arangodb-driver/src/test/java/org/jnosql/diana/arangodb/document/ArangoDBDocumentCollectionManagerAsyncTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
import static org.awaitility.Awaitility.await;
3636
import static org.jnosql.diana.api.document.query.DocumentQueryBuilder.delete;
3737
import static org.jnosql.diana.api.document.query.DocumentQueryBuilder.select;
38-
import static org.jnosql.diana.arangodb.document.DocumentConfigurationUtils.getConfiguration;
39-
import static org.junit.jupiter.api.Assertions.assertEquals;
38+
import static org.jnosql.diana.arangodb.document.ArangoDBDocumentCollectionManagerFactorySupplier.INSTANCE;
4039
import static org.junit.jupiter.api.Assertions.assertFalse;
4140
import static org.junit.jupiter.api.Assertions.assertTrue;
4241

@@ -52,8 +51,8 @@ public class ArangoDBDocumentCollectionManagerAsyncTest {
5251
@BeforeEach
5352
public void setUp() {
5453
random = new Random();
55-
entityManagerAsync = getConfiguration().getAsync("database");
56-
entityManager = getConfiguration().get("database");
54+
entityManagerAsync = INSTANCE.get().getAsync("database");
55+
entityManager = INSTANCE.get().get("database");
5756
}
5857

5958

arangodb-driver/src/test/java/org/jnosql/diana/arangodb/document/ArangoDBDocumentCollectionManagerFactorySupplier.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,21 @@
1919
import org.testcontainers.containers.GenericContainer;
2020
import org.testcontainers.containers.wait.strategy.Wait;
2121

22-
public final class DocumentConfigurationUtils {
22+
import java.util.function.Supplier;
2323

24-
private static GenericContainer arangodb =
24+
enum ArangoDBDocumentCollectionManagerFactorySupplier implements Supplier<ArangoDBDocumentCollectionManagerFactory> {
25+
26+
INSTANCE;
27+
28+
private GenericContainer arangodb =
2529
new GenericContainer("arangodb/arangodb:latest")
2630
.withExposedPorts(8529)
2731
.withEnv("ARANGO_NO_AUTH", "1")
2832
.waitingFor(Wait.forHttp("/")
2933
.forStatusCode(200));
3034

31-
private DocumentConfigurationUtils() {
32-
}
33-
34-
public static ArangoDBDocumentCollectionManagerFactory getConfiguration() {
35+
@Override
36+
public ArangoDBDocumentCollectionManagerFactory get() {
3537
arangodb.start();
3638
ArangoDBDocumentConfiguration configuration = new ArangoDBDocumentConfiguration();
3739
configuration.addHost(arangodb.getContainerIpAddress(), arangodb.getFirstMappedPort());

arangodb-driver/src/test/java/org/jnosql/diana/arangodb/document/ArangoDBDocumentCollectionManagerFactoryTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.junit.jupiter.api.BeforeEach;
2121
import org.junit.jupiter.api.Test;
2222

23+
import static org.jnosql.diana.arangodb.document.ArangoDBDocumentCollectionManagerFactorySupplier.INSTANCE;
2324
import static org.junit.jupiter.api.Assertions.assertNotNull;
2425

2526
public class ArangoDBDocumentCollectionManagerFactoryTest {
@@ -28,7 +29,7 @@ public class ArangoDBDocumentCollectionManagerFactoryTest {
2829

2930
@BeforeEach
3031
public void setUp() {
31-
managerFactory = DocumentConfigurationUtils.getConfiguration();
32+
managerFactory = INSTANCE.get();
3233
}
3334

3435
@Test

arangodb-driver/src/test/java/org/jnosql/diana/arangodb/document/ArangoDBDocumentCollectionManagerTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,11 @@
3838
import static org.hamcrest.Matchers.containsInAnyOrder;
3939
import static org.jnosql.diana.api.document.query.DocumentQueryBuilder.delete;
4040
import static org.jnosql.diana.api.document.query.DocumentQueryBuilder.select;
41-
import static org.jnosql.diana.arangodb.document.DocumentConfigurationUtils.getConfiguration;
42-
import static org.junit.jupiter.api.Assertions.*;
41+
import static org.jnosql.diana.arangodb.document.ArangoDBDocumentCollectionManagerFactorySupplier.INSTANCE;
42+
import static org.junit.jupiter.api.Assertions.assertEquals;
43+
import static org.junit.jupiter.api.Assertions.assertFalse;
44+
import static org.junit.jupiter.api.Assertions.assertNotNull;
45+
import static org.junit.jupiter.api.Assertions.assertTrue;
4346

4447
public class ArangoDBDocumentCollectionManagerTest {
4548

@@ -51,7 +54,7 @@ public class ArangoDBDocumentCollectionManagerTest {
5154
@BeforeEach
5255
public void setUp() {
5356
random = new Random();
54-
entityManager = getConfiguration().get("database");
57+
entityManager = INSTANCE.get().get("database");
5558
}
5659

5760
@Test

arangodb-driver/src/test/java/org/jnosql/diana/arangodb/key/ArangoDBKeyValueEntityManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class ArangoDBKeyValueEntityManagerTest {
4545

4646
@BeforeEach
4747
public void init() {
48-
keyValueEntityManagerFactory = ArangoDBTestUtils.get();
48+
keyValueEntityManagerFactory = BucketManagerFactorySupplier.INSTANCE.get();
4949
keyValueEntityManager = keyValueEntityManagerFactory.getBucketManager("users-entity");
5050
}
5151

arangodb-driver/src/test/java/org/jnosql/diana/arangodb/key/ArangoDBTestUtils.java renamed to arangodb-driver/src/test/java/org/jnosql/diana/arangodb/key/BucketManagerFactorySupplier.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,22 @@
1919
import org.testcontainers.containers.GenericContainer;
2020
import org.testcontainers.containers.wait.strategy.Wait;
2121

22-
public final class ArangoDBTestUtils {
22+
import java.util.function.Supplier;
2323

24-
private static GenericContainer arangodb =
24+
enum BucketManagerFactorySupplier implements Supplier<BucketManagerFactory> {
25+
26+
INSTANCE;
27+
28+
private GenericContainer arangodb =
2529
new GenericContainer("arangodb/arangodb:latest")
2630
.withExposedPorts(8529)
2731
.withEnv("ARANGO_NO_AUTH", "1")
2832
.waitingFor(Wait.forHttp("/")
2933
.forStatusCode(200));
3034

3135

32-
public static BucketManagerFactory get() {
36+
@Override
37+
public BucketManagerFactory get() {
3338
arangodb.start();
3439
ArangoDBKeyValueConfiguration configuration = new ArangoDBKeyValueConfiguration();
3540
configuration.addHost(arangodb.getContainerIpAddress(), arangodb.getFirstMappedPort());

0 commit comments

Comments
 (0)