Skip to content

Commit e0b5109

Browse files
committed
feat: fix null id scenario
Signed-off-by: Otavio Santana <[email protected]>
1 parent 6bd0cd0 commit e0b5109

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

jnosql-mongodb/src/main/java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBDocumentManager.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,12 @@ public CommunicationEntity insert(CommunicationEntity entity) {
7575
Objects.requireNonNull(entity, "entity is required");
7676
String collectionName = entity.name();
7777
MongoCollection<Document> collection = mongoDatabase.getCollection(collectionName);
78-
Document document = getDocument(entity);
78+
var document = getDocument(entity);
79+
if (document.get(ID_FIELD) == null) {
80+
document.remove(ID_FIELD);
81+
entity.remove(ID_FIELD);
82+
}
83+
7984
collection.insertOne(document);
8085
boolean hasNotId = entity.elements().stream()
8186
.map(Element::name).noneMatch(k -> k.equals(ID_FIELD));

jnosql-mongodb/src/test/java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBDocumentManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void shouldInsertAndIgnoreIdNull() {
8484
var entity = getEntity();
8585
entity.add("_id", null);
8686
var documentEntity = entityManager.insert(entity);
87-
Element id = documentEntity.find("_id").orElseThrow();
87+
var id = documentEntity.find("_id").orElseThrow();
8888
entityManager.delete(DeleteQuery.delete().from(COLLECTION_NAME).where("_id").eq(id.get()).build());
8989
}
9090

0 commit comments

Comments
 (0)