Skip to content

Do not kill kuksa.val.v1 GRPC connection due to slow subscriber#165

Merged
SebastianSchildt merged 2 commits intoeclipse-kuksa:mainfrom
boschglobal:fix/grpcabort_v1_on_slow_subscriber
Jul 22, 2025
Merged

Do not kill kuksa.val.v1 GRPC connection due to slow subscriber#165
SebastianSchildt merged 2 commits intoeclipse-kuksa:mainfrom
boschglobal:fix/grpcabort_v1_on_slow_subscriber

Conversation

@SebastianSchildt
Copy link
Contributor

@SebastianSchildt SebastianSchildt commented Jul 21, 2025

Since the v2 API rework, KUKSA is warning you when a subscriber can not keep up processing all messages due to limited buffers of general overload. In case of v2 the message is just dropped, in v1 the GRPC connection has been severed as well as the tokio thread serving it panicked.

This has been fixed now, and the behavior of v1 mimicks that of v2: You still get a warning in KUKSA, but the connection remains stable and the app can continue.

The only "real" change is in the first commit:
f6ffb37

The rest is due to updated clippy rules.

…to slow subscriber. Now consistent with val.v2 behavior

Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 23.45679% with 62 lines in your changes missing coverage. Please review.

Project coverage is 62.07%. Comparing base (9819bf9) to head (35ae2bc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/broker.rs 34.61% 17 Missing ⚠️
databroker/src/types.rs 6.25% 15 Missing ⚠️
databroker/src/grpc/kuksa_val_v2/val.rs 42.10% 11 Missing ⚠️
databroker/src/grpc/kuksa_val_v2/conversions.rs 12.50% 7 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/val.rs 0.00% 5 Missing ⚠️
databroker-cli/src/main.rs 0.00% 2 Missing ⚠️
databroker-cli/src/kuksa_cli.rs 0.00% 1 Missing ⚠️
databroker/src/authorization/jwt/decoder.rs 0.00% 1 Missing ⚠️
databroker/src/viss/v2/server.rs 0.00% 1 Missing ⚠️
databroker/src/vss.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   62.60%   62.07%   -0.53%     
==========================================
  Files          37       37              
  Lines       18416    17095    -1321     
==========================================
- Hits        11529    10612     -917     
+ Misses       6887     6483     -404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SebastianSchildt SebastianSchildt force-pushed the fix/grpcabort_v1_on_slow_subscriber branch from 5c1c825 to 30a45cf Compare July 21, 2025 16:03
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
@SebastianSchildt SebastianSchildt force-pushed the fix/grpcabort_v1_on_slow_subscriber branch from 30a45cf to 35ae2bc Compare July 21, 2025 16:24
@SebastianSchildt SebastianSchildt marked this pull request as ready for review July 21, 2025 16:37
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianSchildt SebastianSchildt merged commit 9f60cdc into eclipse-kuksa:main Jul 22, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments