Do not kill kuksa.val.v1 GRPC connection due to slow subscriber#165
Merged
SebastianSchildt merged 2 commits intoeclipse-kuksa:mainfrom Jul 22, 2025
Merged
Conversation
…to slow subscriber. Now consistent with val.v2 behavior Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 62.60% 62.07% -0.53%
==========================================
Files 37 37
Lines 18416 17095 -1321
==========================================
- Hits 11529 10612 -917
+ Misses 6887 6483 -404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5c1c825 to
30a45cf
Compare
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
30a45cf to
35ae2bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the v2 API rework, KUKSA is warning you when a subscriber can not keep up processing all messages due to limited buffers of general overload. In case of v2 the message is just dropped, in v1 the GRPC connection has been severed as well as the tokio thread serving it panicked.
This has been fixed now, and the behavior of v1 mimicks that of v2: You still get a warning in KUKSA, but the connection remains stable and the app can continue.
The only "real" change is in the first commit:
f6ffb37
The rest is due to updated clippy rules.