Fix warnings in updated clippy#167
Conversation
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 62.07% 62.10% +0.02%
==========================================
Files 37 37
Lines 17095 17088 -7
==========================================
Hits 10612 10612
+ Misses 6483 6476 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several Rust clippy warnings and compiler warnings that were causing CI failures. The changes address lifetime annotation inconsistencies and remove unused code to ensure the codebase passes the updated clippy checks.
- Added explicit lifetime annotations to function return types to resolve mismatched lifetime syntax warnings
- Replaced inefficient if-else pattern with match expression for better code clarity
- Removed unused
DisplayChangeTypestruct and its associated implementation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| databroker/src/glob.rs | Added explicit lifetime annotations to test helper function return types |
| databroker/src/broker.rs | Fixed lifetime annotations and replaced if-else with match expression |
| databroker-cli/src/sdv_cli.rs | Removed unused DisplayChangeType struct and implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This fixes several clippy issues or compiler warings that triggered clippy to fail such as
or
As long as we do not fix it, any CI runs will fail, see eg. the currently open dependabot PRs