Skip to content

Commit 18a38ce

Browse files
authored
Use correct module type for generated module (#1393)
1 parent be0407e commit 18a38ce

File tree

7 files changed

+28
-27
lines changed

7 files changed

+28
-27
lines changed

examples/arithmetics/src/language-server/generated/module.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
* DO NOT EDIT MANUALLY!
44
******************************************************************************/
55

6-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module } from 'langium';
7-
import type { LangiumSharedServices, LangiumServices } from 'langium/lsp';
6+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module } from 'langium';
87
import { ArithmeticsAstReflection } from './ast.js';
98
import { ArithmeticsGrammar } from './grammar.js';
109

@@ -14,11 +13,11 @@ export const ArithmeticsLanguageMetaData = {
1413
caseInsensitive: true
1514
} as const satisfies LanguageMetaData;
1615

17-
export const ArithmeticsGeneratedSharedModule: Module<LangiumSharedServices, LangiumGeneratedSharedCoreServices> = {
16+
export const ArithmeticsGeneratedSharedModule: Module<LangiumSharedCoreServices, LangiumGeneratedSharedCoreServices> = {
1817
AstReflection: () => new ArithmeticsAstReflection()
1918
};
2019

21-
export const ArithmeticsGeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
20+
export const ArithmeticsGeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
2221
Grammar: () => ArithmeticsGrammar(),
2322
LanguageMetaData: () => ArithmeticsLanguageMetaData,
2423
parser: {}

examples/domainmodel/src/language-server/generated/module.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
* DO NOT EDIT MANUALLY!
44
******************************************************************************/
55

6-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module, IParserConfig } from 'langium';
7-
import type { LangiumSharedServices, LangiumServices } from 'langium/lsp';
6+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module, IParserConfig } from 'langium';
87
import { DomainModelAstReflection } from './ast.js';
98
import { DomainModelGrammar } from './grammar.js';
109

@@ -20,11 +19,11 @@ export const parserConfig: IParserConfig = {
2019
maxLookahead: 3,
2120
};
2221

23-
export const DomainModelGeneratedSharedModule: Module<LangiumSharedServices, LangiumGeneratedSharedCoreServices> = {
22+
export const DomainModelGeneratedSharedModule: Module<LangiumSharedCoreServices, LangiumGeneratedSharedCoreServices> = {
2423
AstReflection: () => new DomainModelAstReflection()
2524
};
2625

27-
export const DomainModelGeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
26+
export const DomainModelGeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
2827
Grammar: () => DomainModelGrammar(),
2928
LanguageMetaData: () => DomainModelLanguageMetaData,
3029
parser: {

examples/requirements/src/language-server/generated/module.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
* DO NOT EDIT MANUALLY!
44
******************************************************************************/
55

6-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module } from 'langium';
7-
import type { LangiumSharedServices, LangiumServices } from 'langium/lsp';
6+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module } from 'langium';
87
import { RequirementsAndTestsAstReflection } from './ast.js';
98
import { RequirementsGrammar, TestsGrammar } from './grammar.js';
109

@@ -20,17 +19,17 @@ export const TestsLanguageMetaData = {
2019
caseInsensitive: false
2120
} as const satisfies LanguageMetaData;
2221

23-
export const RequirementsAndTestsGeneratedSharedModule: Module<LangiumSharedServices, LangiumGeneratedSharedCoreServices> = {
22+
export const RequirementsAndTestsGeneratedSharedModule: Module<LangiumSharedCoreServices, LangiumGeneratedSharedCoreServices> = {
2423
AstReflection: () => new RequirementsAndTestsAstReflection()
2524
};
2625

27-
export const RequirementsGeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
26+
export const RequirementsGeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
2827
Grammar: () => RequirementsGrammar(),
2928
LanguageMetaData: () => RequirementsLanguageMetaData,
3029
parser: {}
3130
};
3231

33-
export const TestsGeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
32+
export const TestsGeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
3433
Grammar: () => TestsGrammar(),
3534
LanguageMetaData: () => TestsLanguageMetaData,
3635
parser: {}

examples/statemachine/src/language-server/generated/module.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
* DO NOT EDIT MANUALLY!
44
******************************************************************************/
55

6-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module } from 'langium';
7-
import type { LangiumSharedServices, LangiumServices } from 'langium/lsp';
6+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module } from 'langium';
87
import { StatemachineAstReflection } from './ast.js';
98
import { StatemachineGrammar } from './grammar.js';
109

@@ -14,11 +13,11 @@ export const StatemachineLanguageMetaData = {
1413
caseInsensitive: false
1514
} as const satisfies LanguageMetaData;
1615

17-
export const StatemachineGeneratedSharedModule: Module<LangiumSharedServices, LangiumGeneratedSharedCoreServices> = {
16+
export const StatemachineGeneratedSharedModule: Module<LangiumSharedCoreServices, LangiumGeneratedSharedCoreServices> = {
1817
AstReflection: () => new StatemachineAstReflection()
1918
};
2019

21-
export const StatemachineGeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
20+
export const StatemachineGeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
2221
Grammar: () => StatemachineGrammar(),
2322
LanguageMetaData: () => StatemachineLanguageMetaData,
2423
parser: {}

packages/langium-cli/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Change Log of `langium-cli`
22

3+
## v3.0.1 (Feb. 2024)
4+
5+
Fixed a minor issue related to generated code for projects that don't use the `langium/lsp` import ([#1393](https://github.com/eclipse-langium/langium/pull/1393)).
6+
7+
## v3.0.0 (Feb. 2024)
8+
9+
Some adjustments of the generated code due to the LSP bundling changes in Langium. For further information, see [here](https://github.com/eclipse-langium/langium/blob/main/packages/langium/CHANGELOG.md#smaller-bundles-with-exports).
10+
311
## v2.0.1 (Aug. 2023)
412

513
Fix a bug that prevented usage of the JS API of the CLI package ([#1160](https://github.com/eclipse-langium/langium/pull/1160)).

packages/langium-cli/src/generator/module-generator.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,14 @@ export function generateModule(grammars: Grammar[], config: LangiumConfig, gramm
2525
import type { LanguageMetaData } from '../../languages/language-meta-data${config.importExtension}';
2626
import { ${config.projectName}AstReflection } from '../../languages/generated/ast${config.importExtension}';
2727
import type { Module } from '../../dependency-injection${config.importExtension}';
28-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices } from '../../services${config.importExtension}';
29-
import type { LangiumSharedServices, LangiumServices } from '../../lsp/lsp-services${config.importExtension}';
28+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices } from '../../services${config.importExtension}';
3029
`.appendTemplateIf(hasIParserConfigImport)`
3130
3231
import type { IParserConfig } from '../../parser/parser-config${config.importExtension}';
3332
`
3433
).appendTemplateIf(!config.langiumInternal)`
3534
36-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module${hasIParserConfigImport ? ', IParserConfig' : ''} } from 'langium';
37-
import type { LangiumSharedServices, LangiumServices } from 'langium/lsp';
35+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices, LanguageMetaData, Module${hasIParserConfigImport ? ', IParserConfig' : ''} } from 'langium';
3836
import { ${config.projectName}AstReflection } from './ast${config.importExtension}';
3937
`.appendTemplate`
4038
@@ -79,7 +77,7 @@ export function generateModule(grammars: Grammar[], config: LangiumConfig, gramm
7977
};
8078
`}
8179
82-
export const ${config.projectName}GeneratedSharedModule: Module<LangiumSharedServices, LangiumGeneratedSharedCoreServices> = {
80+
export const ${config.projectName}GeneratedSharedModule: Module<LangiumSharedCoreServices, LangiumGeneratedSharedCoreServices> = {
8381
AstReflection: () => new ${config.projectName}AstReflection()
8482
};
8583
${joinToNode(
@@ -88,7 +86,7 @@ export function generateModule(grammars: Grammar[], config: LangiumConfig, gramm
8886
const grammarConfig = grammarConfigMap.get(grammar)!;
8987
return expandToNode`
9088
91-
export const ${grammar.name}GeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
89+
export const ${grammar.name}GeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
9290
Grammar: () => ${grammar.name}Grammar(),
9391
LanguageMetaData: () => ${grammar.name}LanguageMetaData,
9492
parser: {${(grammarConfig.chevrotainParserConfig || parserConfig) && expandToNode`

packages/langium/src/grammar/generated/module.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
import type { LanguageMetaData } from '../../languages/language-meta-data.js';
77
import { LangiumGrammarAstReflection } from '../../languages/generated/ast.js';
88
import type { Module } from '../../dependency-injection.js';
9-
import type { LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices } from '../../services.js';
10-
import type { LangiumSharedServices, LangiumServices } from '../../lsp/lsp-services.js';
9+
import type { LangiumSharedCoreServices, LangiumCoreServices, LangiumGeneratedCoreServices, LangiumGeneratedSharedCoreServices } from '../../services.js';
1110
import type { IParserConfig } from '../../parser/parser-config.js';
1211
import { LangiumGrammarGrammar } from './grammar.js';
1312

@@ -21,11 +20,11 @@ export const LangiumGrammarParserConfig: IParserConfig = {
2120
maxLookahead: 3,
2221
};
2322

24-
export const LangiumGrammarGeneratedSharedModule: Module<LangiumSharedServices, LangiumGeneratedSharedCoreServices> = {
23+
export const LangiumGrammarGeneratedSharedModule: Module<LangiumSharedCoreServices, LangiumGeneratedSharedCoreServices> = {
2524
AstReflection: () => new LangiumGrammarAstReflection()
2625
};
2726

28-
export const LangiumGrammarGeneratedModule: Module<LangiumServices, LangiumGeneratedCoreServices> = {
27+
export const LangiumGrammarGeneratedModule: Module<LangiumCoreServices, LangiumGeneratedCoreServices> = {
2928
Grammar: () => LangiumGrammarGrammar(),
3029
LanguageMetaData: () => LangiumGrammarLanguageMetaData,
3130
parser: {

0 commit comments

Comments
 (0)