textDocument/didClose notification

[cdietrich]

hi should a textDocument/didClose notification lead to a invalidateDocumentor deleteDocument in LangiumDocuments
i dont see this happening in monaco-languageclient / webworker scenario

[msujew]

Usually, in vscode, textDocument/didClose doesn't really do anything, since it doesn't change the state of the document - The document is still there, just not open in the editor. If the document changes by closing the editor, textDocument/didChange gets called anyway which we correctly apply to the workspace.

In a webworker scenario this semantic might change, as the document could indeed get lost. You should rather listen on workspace/didDeleteFiles instead of textDocument/didClose in the language server, as that unambiguously denotes that a file has been deleted/removed. Though you might need to emit this notification manually when the document closes. See also #1230.

[msujew]

We don't want to remove a file from the workspace, just because its editor has closed, do we?

[cdietrich]

yes but we might want to trigger an update.
maybe this also need to be fixed upstream.
the TextDocuments maintains synced documents and uses that one to remove the dirty open doc.
but also the did open produces a did change.
also on did close of a dirty file langium somehow builds affected files.
did not debug yet why this is working.

[msujew]

also on did close of a dirty file langium somehow builds affected files.
did not debug yet why this is working.

VSCode sends a textDocument/didChange when closing a dirty file. We just lean on that behavior.

[cdietrich]

and it changes it to empty? or the original content?

[msujew]

It changes back to the original content as the dirty state is effectively deleted.