Completion based on typesystem

[cdietrich]

we have in our grammar something like

PropertyAssignment:
   property=[Property:ID] ":" value=PropertyValue;
   
PropertyValue: StringLiteral | SomeExpressionWithKeyword;

StringLiteral: value=STRING;

SomeExpressionWithKeyword: "somekeyword" value=INT;

the langium completion behaves like this: (maybe we have customized too much)

• we get called with a context next.feature = keyword (for SomeExpressionWithKeyword)
• we get called with context next.feature = RuleCall for StringLiteral

now we want to restrict the visible alternatives in PropertyValue based on the Property on the right hand side.
what is the best way and place to do it.

the different context if RuleCall vs Keywords makes it quite hard to filter out in completionFor

is there a better way of achieving this? e.g. the next feature calculation

[msujew]

Hey @cdietrich,

Can't you just look for AstUtils.getContainerOfType(context.node, isPropertyAssignment) in the completionFor override? I think that should always return the same context to restrict the completion result.

[cdietrich]

had feared that. so we will need to do some refactoring to keep the downstream completion customizations reusable