How to use customized validator in unit tests for document-validator?

[durianwaffle]

Hi Langium team, I am trying to implement unit tests for all the error messages in my project.
The validation feature in my projects rely on the customized parser-error-provider, validator, document-validator.
I find that I can achieve that by implementing unit tests in document-validator if I can inject my customized validator into it.
But currently, the document validator doesn't consist of error messages from customized validator.

let services: ReturnType<typeof createMyServices>;
let document: LangiumDocument<Model> | undefined;
let documentValidator: MyDocumentValidator;
let documentValidatorAny: any;
let parse: ReturnType<typeof parseHelper<Model>>;

beforeAll(async () => {
    services = createMyServices(EmptyFileSystem);
    parse = parseHelper<Model>(services.MyService);
    documentValidator = new MyDocumentValidator(services.MyService);
    documentValidatorAny = documentValidator as any;
});

[cdietrich]

@durianwaffle i cannot follow you. where do you validate? i dont see any refeences to validationHelper in the snippet you posted.

[cdietrich]

If you register it in module it should be called automatically

[msujew]

See here and here how to register your own validator.

[durianwaffle]

Hi @msujew, yes I am using the method you showed above to register my own validator registerValidationChecks(MyLanguage);
So it's already called automatically in document-validator?

[msujew]

Yes, that's how it's designed.

[durianwaffle]

Okay, thanks a lot!

[msujew]

Hey @durianwaffle,

just as Christian, I would recommend you to use the validationHelper utility to implement your validation tests.

[durianwaffle]

Hi @msujew, do you think that only by using it I can get the error message from my customized validator?
https://github.com/eclipse-langium/langium/blob/55791a542d0f4e0b9264fc74749f546a1c7d7734/packages/langium/test/validation/document-validator.test.ts

Or my current implementation also works?

let services: ReturnType<typeof createMyServices>;
let document: LangiumDocument<Model> | undefined;
let documentValidator: MyDocumentValidator;
let documentValidatorAny: any;
let parse: ReturnType<typeof parseHelper<Model>>;

beforeAll(async () => {
    services = createMyServices(EmptyFileSystem);
    parse = parseHelper<Model>(services.MyService);
    documentValidator = new MyDocumentValidator(services.MyService);
    documentValidatorAny = documentValidator as any;
});

[msujew]

I mean, it's just a recommendation. You don't absolutely need to use it.