testing api + parseHelper + build

[cdietrich]

parseHelper calls documentbuilder.build
we have some tests, e.g. content assist tests, that need to work in a workspace like env.
we currently do it like the following

• add multiple documents (via parseHelper),
• call expectCompletion

this is problematic when the first documents have references that cannot be resolved by document add order
so we end up with stale refs.

is there a reason parseHelper does not call update?

[msujew]

Hey @cdietrich,

is there a reason parseHelper does not call update?

I believe that's because the DocumentBuilder#build call does not require a TextDocument instance, if I remember correctly. It predates our change that allows to easily create and set TextDocument instances on the TextDocuments service. On the other hand, update requires the TextDocument for that URI to be in place, which is more setup work for the test. However, I don't think that those assumptions hold up anymore, since we evolved the infrastructure quite a bit.