Preventing completions for single-line comments

[dalyIsaac]

I have a completion provider, however I'd like to disable it for text in what should be a single-line comment.

For example, in the statemachine example at https://langium.org/showcase/statemachine/, it's possible to trigger suggestions in the single-line comment:

I suspect that if a single-line comment required a newline, this would be achievable. However, completions should be prevented on comments even if there isn't a following newline.

I may be missing something, but to me this seems like something which isn't supported by Langium?

[msujew]

Hey @dalyIsaac,

that's a good point. It seems like our completion provider actually only looks at the semantically relevant tokens when determining what to complete, completely ignoring that the user is within a comment/hidden token:

langium/packages/langium/src/lsp/completion/completion-provider.ts

Line 364 in 910e8a0

const tokens = this.lexer.tokenize(text).tokens;

We should probably take this into account. Do you mind creating an issue for this?

[dalyIsaac]

Thanks for looking, I've created #2016