Skip to content

Commit 77a44c7

Browse files
authored
chore: make disambiguation config optional when disambiguation is not activated. (#295)
1 parent f0a6bb4 commit 77a44c7

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

lmos-runtime-core/src/main/kotlin/org/eclipse/lmos/runtime/core/RuntimeConfiguration.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import org.eclipse.lmos.runtime.core.disambiguation.defaultDisambiguationIntrodu
1212
open class RuntimeConfiguration(
1313
val channelRoutingRepository: ChannelRoutingRepositoryConfig,
1414
val openAi: OpenAI? = null,
15-
val disambiguation: Disambiguation,
15+
val disambiguation: Disambiguation? = null,
1616
) {
1717
data class ChannelRoutingRepositoryConfig(
1818
val baseUrl: String? = null, // Made nullable

lmos-runtime-spring-boot-starter/src/main/kotlin/org/eclipse/lmos/runtime/config/RuntimeAutoConfiguration.kt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,13 @@ class RuntimeAutoConfiguration(
128128
// different models for disambiguation and agent classification.
129129
LangChainChatModelFactory.createClient(
130130
ChatModelClientProperties(
131-
provider = runtimeProperties.disambiguation.llm.provider,
132-
apiKey = runtimeProperties.disambiguation.llm.apiKey,
133-
baseUrl = runtimeProperties.disambiguation.llm.baseUrl,
134-
model = runtimeProperties.disambiguation.llm.model,
135-
maxTokens = runtimeProperties.disambiguation.llm.maxTokens,
136-
temperature = runtimeProperties.disambiguation.llm.temperature,
137-
logRequestsAndResponses = runtimeProperties.disambiguation.llm.logRequestsAndResponses,
131+
provider = runtimeProperties.disambiguation!!.llm.provider,
132+
apiKey = runtimeProperties.disambiguation!!.llm.apiKey,
133+
baseUrl = runtimeProperties.disambiguation!!.llm.baseUrl,
134+
model = runtimeProperties.disambiguation!!.llm.model,
135+
maxTokens = runtimeProperties.disambiguation!!.llm.maxTokens,
136+
temperature = runtimeProperties.disambiguation!!.llm.temperature,
137+
logRequestsAndResponses = runtimeProperties.disambiguation!!.llm.logRequestsAndResponses,
138138
),
139139
)
140140

@@ -153,8 +153,8 @@ class RuntimeAutoConfiguration(
153153
): DisambiguationHandler =
154154
DefaultDisambiguationHandler(
155155
chatModel,
156-
lmosRuntimeProperties.disambiguation.introductionPrompt(),
157-
lmosRuntimeProperties.disambiguation.clarificationPrompt(),
156+
lmosRuntimeProperties.disambiguation!!.introductionPrompt(),
157+
lmosRuntimeProperties.disambiguation!!.clarificationPrompt(),
158158
MvelSystemPromptRenderer(),
159159
tracerProvider.getIfAvailable { NoopClassifierTracer() },
160160
)

lmos-runtime-spring-boot-starter/src/main/kotlin/org/eclipse/lmos/runtime/properties/RuntimeProperties.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import org.springframework.boot.context.properties.ConfigurationProperties
1313
class RuntimeProperties(
1414
channelRoutingRepository: ChannelRoutingRepositoryConfig,
1515
openAi: OpenAI? = null,
16-
disambiguation: Disambiguation,
16+
disambiguation: Disambiguation? = null,
1717
val router: Router,
1818
) : RuntimeConfiguration(channelRoutingRepository, openAi, disambiguation)
1919

0 commit comments

Comments
 (0)