[build] Test failures make the build 'unstable', not 'failed'; removed obsolete Slack notifications

Author: spoenemann

Jenkinsfile

@@ -7,32 +7,25 @@
  *******************************************************************************/
 
 node {
-	try {
-		properties([
-			[$class: 'BuildDiscarderProperty', strategy: [$class: 'LogRotator', numToKeepStr: '15']]
-		])
-		
-		stage 'Checkout'
+	properties([
+		[$class: 'BuildDiscarderProperty', strategy: [$class: 'LogRotator', numToKeepStr: '15']]
+	])
+	
+	stage('Checkout') {
 		checkout scm
-		
-		stage 'Gradle Build'
-		try {
-			sh "./gradlew clean build createLocalMavenRepo --refresh-dependencies --continue"
-		} finally {
-			step([$class: 'JUnitResultArchiver', testResults: '**/build/test-results/test/*.xml'])
-		}
-		
-		stage 'Maven Build'
+	}
+	
+	stage('Gradle Build') {
+		sh "./gradlew clean build createLocalMavenRepo -PignoreTestFailures=true --refresh-dependencies --continue"
+		step([$class: 'JUnitResultArchiver', testResults: '**/build/test-results/test/*.xml'])
+	}
+	
+	stage('Maven Build') {
 		def mvnHome = tool 'M3'
 		env.M2_HOME = "${mvnHome}"
 		dir('.m2/repository/org/eclipse/lsp4j') { deleteDir() }
 		sh "${mvnHome}/bin/mvn -f releng --batch-mode --update-snapshots -Dmaven.repo.local=.m2/repository clean install"
-		
-		archive 'build/**'
-		slackSend "Build Succeeded - ${env.JOB_NAME} ${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)"
-		
-	} catch (e) {
-		slackSend color: 'danger', message: "Build Failed - ${env.JOB_NAME} ${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)"
-		throw e
 	}
+	
+	archive 'build/**'
 }

gradle/java-compiler-settings.gradle

@@ -33,3 +33,9 @@ configurations.all {
 		force "com.google.guava:guava:18.0"
 	}
 }
+
+if (findProperty('ignoreTestFailures') == 'true') {
+	tasks.withType(Test) {
+		ignoreFailures = true
+	}
+}