Remove deprecated API #881
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long deprecated and replaced with the more generic JsonRpcData Fixes eclipse-lsp4j#876
Instead use TypeUtils helper methods Fixes eclipse-lsp4j#877
These were the old way of accessing factories. Fixes eclipse-lsp4j#878
This was a misspelling and is replaced by ServerNotInitialized Fixes eclipse-lsp4j#879
Mitigation: either upgrade to Jakarta version or remain on older version of LSP4J. Fixes eclipse-lsp4j#647
Open
pisv
reviewed
Jul 29, 2025
Contributor
pisv
left a comment
pisv
left a comment
There was a problem hiding this comment.
LGTM, apart from Either.java having some unused imports left after removing the deprecated methods there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #874
Individual commits fix the sub-issues of #874