Skip to content

Commit 294e168

Browse files
committed
Optional dependencies are no longer included
Signed-off-by: Christoph Läubrich <[email protected]>
1 parent 22fc5a4 commit 294e168

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

org.eclipse.m2e.pde.target.tests/src/org/eclipse/m2e/pde/target/tests/AbstractMavenTargetTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ private static <T> boolean isOriginalArtifact(ExpectedUnit expectedUnit, T unit,
127127
return false;
128128
}
129129
URI location = getLocation.apply(unit);
130-
String expectedPathSuffix = "/" + String.join("/", ".m2", "repository", key.groupId().replace('.', '/'),
130+
String expectedPathSuffix = "/" + String.join("/", "repository", key.groupId().replace('.', '/'),
131131
key.artifactId(), key.version(), key.artifactId() + "-" + key.version() + ".jar");
132132
return location.toASCIIString().endsWith(expectedPathSuffix);
133133
}

org.eclipse.m2e.pde.target.tests/src/org/eclipse/m2e/pde/target/tests/MavenFeatureTest.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
import org.junit.runners.Parameterized.Parameter;
2323
import org.junit.runners.Parameterized.Parameters;
2424

25+
/**
26+
* Test that the generated features contain the expected content
27+
*/
2528
@RunWith(Parameterized.class)
2629
public class MavenFeatureTest extends AbstractMavenTargetTest {
2730
@Parameter(0)
@@ -109,22 +112,17 @@ public void testPomArtifactFeatureGeneration() throws Exception {
109112
originalOSGiBundle("com.sun.xml.bind.jaxb-impl", "4.0.2", "com.sun.xml.bind:jaxb-impl"),
110113
originalOSGiBundle("com.sun.xml.bind.jaxb-jxc", "4.0.2", "com.sun.xml.bind:jaxb-jxc"),
111114
originalOSGiBundle("com.sun.xml.bind.jaxb-xjc", "4.0.2", "com.sun.xml.bind:jaxb-xjc"),
112-
originalOSGiBundle("com.sun.xml.fastinfoset.FastInfoset", "2.1.0",
113-
"com.sun.xml.fastinfoset:FastInfoset"),
114-
originalOSGiBundle("jakarta.activation-api", "2.1.1", "jakarta.activation:jakarta.activation-api"),
115-
originalOSGiBundle("jakarta.xml.bind-api", "4.0.0", "jakarta.xml.bind:jakarta.xml.bind-api"),
116-
originalOSGiBundle("org.jvnet.staxex.stax-ex", "2.1.0", "org.jvnet.staxex:stax-ex"));
115+
originalOSGiBundle("jakarta.activation-api", "2.1.0", "jakarta.activation:jakarta.activation-api"),
116+
originalOSGiBundle("jakarta.xml.bind-api", "4.0.0", "jakarta.xml.bind:jakarta.xml.bind-api"));
117117
assertTargetBundles(target, includeSource ? withSourceBundles(expectedBundles) : expectedBundles);
118118
List<ExpectedFeature> expectedFeature = List.of(generatedFeature("com.sun.xml.bind.jaxb-ri.pom", "0.0.1",
119119
List.of(//
120120
featurePlugin("com.sun.xml.bind.jaxb-core", "4.0.2"),
121121
featurePlugin("com.sun.xml.bind.jaxb-impl", "4.0.2"),
122122
featurePlugin("com.sun.xml.bind.jaxb-jxc", "4.0.2"),
123123
featurePlugin("com.sun.xml.bind.jaxb-xjc", "4.0.2"),
124-
featurePlugin("com.sun.xml.fastinfoset.FastInfoset", "2.1.0"),
125-
featurePlugin("jakarta.activation-api", "2.1.1"),
126-
featurePlugin("jakarta.xml.bind-api", "4.0.0"),
127-
featurePlugin("org.jvnet.staxex.stax-ex", "2.1.0"))));
124+
featurePlugin("jakarta.activation-api", "2.1.0"),
125+
featurePlugin("jakarta.xml.bind-api", "4.0.0"))));
128126
assertTargetFeatures(target, includeSource ? withSourceFeatures(expectedFeature) : expectedFeature);
129127

130128
}

org.eclipse.m2e.pde.target.tests/src/org/eclipse/m2e/pde/target/tests/MixedCasesTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ public void testMultipleArtifactsWithWrappingAndExclusion() throws Exception {
8282
originalOSGiBundle("com.google.guava", "30.1.0.jre", "com.google.guava:guava", "30.1-jre"),
8383
originalOSGiBundle("com.google.guava", "30.1.1.jre", "com.google.guava:guava", "30.1.1-jre"),
8484
originalOSGiBundle("com.google.guava.failureaccess", "1.0.1", "com.google.guava:failureaccess"),
85-
originalOSGiBundle("org.objectweb.asm", "9.2.0", "org.ow2.asm:asm", "9.2"),
8685
originalOSGiBundle("checker-qual", "3.8.0", "org.checkerframework:checker-qual"),
8786
generatedBundle("m2e.wrapped.com.google.errorprone.error_prone_annotations", "2.3.4",
8887
"com.google.errorprone:error_prone_annotations"),

0 commit comments

Comments
 (0)