Skip to content

Commit 3fe4145

Browse files
Copilotlaeubi
andcommitted
Replace Apache StringUtils with native Java methods
Co-authored-by: laeubi <[email protected]>
1 parent 3f68f5d commit 3fe4145

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed

org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenProperties.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050

5151
import org.apache.maven.cli.CLIManager;
5252
import org.apache.maven.cli.MavenCli;
53-
import org.apache.maven.shared.utils.StringUtils;
5453

5554
import org.eclipse.m2e.core.embedder.IMavenConfiguration;
5655
import org.eclipse.m2e.core.embedder.MavenSettingsLocations;
@@ -169,7 +168,7 @@ static String createMavenVersionString(Properties buildProperties) {
169168
if(rev != null || timestamp != null) {
170169
msg += " (";
171170
msg += (rev != null ? rev : "");
172-
if(StringUtils.isNotBlank(timestamp)) {
171+
if(timestamp != null && !timestamp.isBlank()) {
173172
String ts = formatTimestamp(Long.parseLong(timestamp));
174173
msg += (rev != null ? "; " : "") + ts;
175174
}

org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/JavaProjectConversionParticipant.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313

1414
package org.eclipse.m2e.jdt.internal;
1515

16-
import static org.apache.maven.shared.utils.StringUtils.isEmpty;
17-
1816
import java.util.ArrayList;
1917
import java.util.Arrays;
2018
import java.util.Collections;
@@ -118,8 +116,8 @@ public void convert(IProject project, Model model, IProgressMonitor monitor) thr
118116
Map<String, String> options = javaProject.getOptions(true);
119117
String source = options.get(JavaCore.COMPILER_SOURCE);
120118
String target = options.get(JavaCore.COMPILER_CODEGEN_TARGET_PLATFORM);
121-
boolean emptySource = isEmpty(source);
122-
boolean emptyTarget = isEmpty(target);
119+
boolean emptySource = source == null || source.isEmpty();
120+
boolean emptyTarget = target == null || target.isEmpty();
123121

124122
if(emptySource && emptyTarget) {
125123
return;

org.eclipse.m2e.pde.ui/src/org/eclipse/m2e/pde/ui/target/editor/internal/TargetDependencyModel.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.util.function.BiConsumer;
2020
import java.util.stream.Stream;
2121

22-
import org.apache.maven.shared.utils.StringUtils;
2322
import org.eclipse.core.databinding.observable.sideeffect.ISideEffectFactory;
2423
import org.eclipse.core.databinding.observable.value.IObservableValue;
2524
import org.eclipse.core.databinding.observable.value.WritableValue;
@@ -266,7 +265,7 @@ public boolean canUpdate() {
266265
downStream.accept(dependency.getVersion());
267266
});
268267

269-
return allFields.noneMatch(StringUtils::isBlank) && !currentSelection.isEmpty();
268+
return allFields.noneMatch(s -> s == null || s.isBlank()) && !currentSelection.isEmpty();
270269
}
271270

272271
public boolean hasErrors() {
@@ -298,7 +297,7 @@ public void check() {
298297
downStream.accept(dependency.getVersion());
299298
downStream.accept(dependency.getType());
300299
});
301-
hasErrors.setValue(allFields.anyMatch(StringUtils::isBlank));
300+
hasErrors.setValue(allFields.anyMatch(s -> s == null || s.isBlank()));
302301
}
303302

304303
private static List<MavenTargetDependency> deepClone(List<MavenTargetDependency> dependencies) {

org.eclipse.m2e.profiles.core/src/org/eclipse/m2e/profiles/core/internal/management/ProfileManager.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
import org.apache.maven.repository.RepositorySystem;
5151
import org.apache.maven.settings.Settings;
5252
import org.apache.maven.settings.SettingsUtils;
53-
import org.apache.maven.shared.utils.StringUtils;
5453

5554
import org.eclipse.m2e.core.MavenPlugin;
5655
import org.eclipse.m2e.core.embedder.IMaven;
@@ -264,11 +263,9 @@ private Model buildParentModelViaRelativePath(Model model) {
264263
return null;
265264
}
266265

267-
String relativePath;
268-
if(StringUtils.isEmpty(model.getParent().getRelativePath())) {
266+
String relativePath = model.getParent().getRelativePath();
267+
if(relativePath == null || relativePath.isEmpty()) {
269268
relativePath = ".." + File.separator + "pom.xml";
270-
} else {
271-
relativePath = model.getParent().getRelativePath();
272269
}
273270
String relativeFileSystemPathToParentPom = ".." + File.separator + relativePath;
274271

0 commit comments

Comments
 (0)