Add failing tests for unresolvable properties

This relates to #1916

Author: kwin

org.eclipse.m2e.jdt.tests/META-INF/MANIFEST.MF

@@ -12,6 +12,7 @@ Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.m2e.core,
  org.eclipse.m2e.core.ui,
  org.eclipse.jdt.launching,
+ org.eclipse.jdt.junit,
  org.eclipse.debug.core,
  org.eclipse.ui.tests.harness,
  org.eclipse.ui,

org.eclipse.m2e.jdt.tests/src/org/eclipse/m2e/jdt/tests/UnitTestLaunchConfigConfigurationTest.java

@@ -12,6 +12,7 @@
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assume.assumeTrue;
@@ -150,7 +151,8 @@ public void test_configuration_must_be_updated_with_surefire_config()
 
 		// check argLine
 		String argLine = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_VM_ARGUMENTS, "");
-		assertTrue(argLine.contains("--argLineItem=surefireArgLineValue"));
+		assertThat(argLine, Matchers.containsString("--argLineItem=surefireArgLineValue --undefinedArgLineItem="));
+		assertThat(argLine, Matchers.not(Matchers.containsString("${undefinedProperty}")));
 
 		// check environmentVariables
 		Map<String, String> envVars = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_ENVIRONMENT_VARIABLES,
@@ -209,7 +211,8 @@ public void test_configuration_must_be_updated_with_failsafe_config()
 
 		// check argLine
 		String argLine = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_VM_ARGUMENTS, "");
-		assertTrue(argLine.contains("--argLineItem=failsafeArgLineValue"));
+		assertThat(argLine, Matchers.containsString("--argLineItem=failsafeArgLineValue --undefinedArgLineItem="));
+		assertThat(argLine, Matchers.not(Matchers.containsString("${undefinedProperty}")));
 
 		// check environmentVariables
 		Map<String, String> envVars = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_ENVIRONMENT_VARIABLES,
@@ -261,7 +264,8 @@ public void test_configuration_must_be_updated_with_surefire_config_when_created
 
 		// check argLine
 		String argLine = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_VM_ARGUMENTS, "");
-		assertTrue(argLine.contains("--argLineItem=surefireArgLineValue"));
+		assertThat(argLine, Matchers.containsString("--argLineItem=surefireArgLineValue --undefinedArgLineItem="));
+		assertThat(argLine, Matchers.not(Matchers.containsString("${undefinedProperty}")));
 
 		// check environmentVariables
 		Map<String, String> envVars = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_ENVIRONMENT_VARIABLES,
@@ -310,7 +314,8 @@ public void test_configuration_must_be_updated_with_failSafe_config_when_created
 
 		// check argLine
 		String argLine = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_VM_ARGUMENTS, "");
-		assertTrue(argLine.contains("--argLineItem=failsafeArgLineValue"));
+		assertThat(argLine, Matchers.containsString("--argLineItem=failsafeArgLineValue --undefinedArgLineItem="));
+		assertThat(argLine, Matchers.not(Matchers.containsString("${undefinedProperty}")));
 
 		// check environmentVariables
 		Map<String, String> envVars = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_ENVIRONMENT_VARIABLES,
@@ -355,7 +360,7 @@ public void test_deferred_variable_are_resolved() throws CoreException, IOExcept
 		ILaunchConfiguration config = updatedConfigurations[0];
 		String argLine = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_VM_ARGUMENTS, "");
 		assertTrue(argLine.contains("-javaagent")); // resolved jacoco agent
-		assertTrue(argLine.contains("@{titi.tata}")); // unresolved property is unchanged as in CLI
+		assertFalse(argLine.contains("@{titi.tata}")); // unresolved property is removed
 	}
 
 	private void updateProject(IProject project) throws CoreException, InterruptedException {