Skip to content

Commit 6c280f0

Browse files
szarnekowlaeubi
authored andcommitted
Avoid throwing NPE from EclipseLogger if no throwable was passed
This closes #1652 Signed-off-by: Sebastian Zarnekow <[email protected]>
1 parent 46c8667 commit 6c280f0

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/EclipseLogger.java

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void debug(String msg) {
4040
@Override
4141
public void debug(String msg, Throwable t) {
4242
if(isDebugEnabled()) {
43-
log.debug(msg + " " + t.getMessage(), t);
43+
log.debug(toMessageString(msg, t), t);
4444
}
4545
}
4646

@@ -54,7 +54,7 @@ public void info(String msg) {
5454
@Override
5555
public void info(String msg, Throwable t) {
5656
if(isInfoEnabled()) {
57-
log.info(msg + " " + t.getMessage(), t);
57+
log.info(toMessageString(msg, t), t);
5858
}
5959
}
6060

@@ -68,7 +68,7 @@ public void warn(String msg) {
6868
@Override
6969
public void warn(String msg, Throwable t) {
7070
if(isWarnEnabled()) {
71-
log.warn(msg + " " + t.getMessage(), t);
71+
log.warn(toMessageString(msg, t), t);
7272
}
7373
}
7474

@@ -82,7 +82,7 @@ public void fatalError(String msg) {
8282
@Override
8383
public void fatalError(String msg, Throwable t) {
8484
if(isFatalErrorEnabled()) {
85-
log.error(msg + " " + t.getMessage(), t);
85+
log.error(toMessageString(msg, t), t);
8686
}
8787
}
8888

@@ -96,7 +96,7 @@ public void error(String msg) {
9696
@Override
9797
public void error(String msg, Throwable t) {
9898
if(isErrorEnabled()) {
99-
log.error(msg + " " + t.getMessage(), t);
99+
log.error(toMessageString(msg, t), t);
100100
}
101101
}
102102

@@ -143,4 +143,14 @@ public Logger getChildLogger(String name) {
143143
public String getName() {
144144
return Messages.EclipseLogger_name;
145145
}
146+
147+
private String toMessageString(String msg, Throwable t) {
148+
if(t == null || t.getMessage() == null) {
149+
return msg;
150+
}
151+
if(msg == null) {
152+
return t.getMessage();
153+
}
154+
return msg + " " + t.getMessage();
155+
}
146156
}

0 commit comments

Comments
 (0)