Skip to content

Commit 8b88dac

Browse files
committed
Prevent empty lines in stack-trace of error messages on Windows
and avoid explicit use of StringBuilder.
1 parent b942896 commit 8b88dac

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/markers/MavenMarkerManager.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,13 +163,11 @@ private String getRootErrorMessage(Throwable ex) {
163163
}
164164

165165
private String getErrorMessage(Throwable ex) {
166-
StringBuilder message = new StringBuilder();
167-
if(ex.getMessage() != null) {
168-
message.append(ex.getMessage()).append("\n\n");
169-
}
170-
StringWriter errorStackTrace = new StringWriter();
171-
ex.printStackTrace(new PrintWriter(errorStackTrace));
172-
return message.append(errorStackTrace).toString();
166+
String exMessage = ex.getMessage();
167+
StringWriter stackTrace = new StringWriter();
168+
ex.printStackTrace(new PrintWriter(stackTrace));
169+
String stackString = stackTrace.toString().replace("\r\n", "\n");
170+
return exMessage != null ? exMessage + "\n\n" + stackString : stackString;
173171
}
174172

175173
private Throwable getRootCause(Throwable ex) {

0 commit comments

Comments
 (0)