Skip to content

Commit 8d299fd

Browse files
committed
Extract maven-resolver-api from the embedded runtime bundle
Currently we embed the maven-resolver-api jar into m2e, but the API itself is already a bundle an we should consume it as such so we can: 1) update it independently 2) make it reusable by others without require the full runtime 3) cut down the size of the runtime bundle
1 parent 19c8f09 commit 8d299fd

File tree

4 files changed

+25
-2
lines changed

4 files changed

+25
-2
lines changed

org.eclipse.m2e.feature/feature.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22
<feature
33
id="org.eclipse.m2e.feature"
44
label="%featureName"
5+
<<<<<<< Upstream, based on main
56
version="2.8.0.qualifier"
7+
=======
8+
version="2.6.2.qualifier"
9+
>>>>>>> 9df7271 Extract maven-resolver-api from the embedded runtime bundle
610
provider-name="%providerName"
711
plugin="org.eclipse.m2e.core"
812
license-feature="org.eclipse.license"

org.eclipse.m2e.maven.runtime/pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@
205205
org.apache.commons.cli;version="[1.4.0,2.0.0)", \
206206
org.apache.commons.codec*
207207
Require-Bundle: \
208-
com.google.guava;bundle-version="32.2.1"
209-
208+
com.google.guava;bundle-version="32.2.1",
209+
org.apache.maven.resolver.api;bundle-version="${maven-resolver.version}";visibility:=reexport
210210
-failok: true
211211
-nouses: true
212212
-nodefaultversion: true
@@ -305,6 +305,7 @@
305305
<phase>generate-resources</phase>
306306
<configuration>
307307
<outputDirectory>${project.basedir}/${jars.directory}</outputDirectory>
308+
<excludeArtifactIds>maven-resolver-api</excludeArtifactIds>
308309
</configuration>
309310
</execution>
310311
<execution>

org.eclipse.m2e.tests.common/META-INF/MANIFEST.MF

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,18 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: M2E Testing Helpers
44
Bundle-SymbolicName: org.eclipse.m2e.tests.common;singleton:=true
5+
<<<<<<< Upstream, based on main
56
Bundle-Version: 2.1.1.qualifier
67
Require-Bundle: org.junit;bundle-version="4.0.0",
78
org.eclipse.m2e.core;bundle-version="[2.0.0,3.0.0)",
89
org.eclipse.m2e.maven.runtime;bundle-version="[3.9.900,4.0.0)",
10+
=======
11+
Bundle-Version: 2.0.7.qualifier
12+
Require-Bundle: org.apache.maven.resolver.api;bundle-version="1.9.20",
13+
org.eclipse.m2e.maven.runtime;bundle-version="[3.8.6,4.0.0)",
14+
org.junit;bundle-version="4.0.0",
15+
org.eclipse.m2e.core;bundle-version="[2.0.0,3.0.0)",
16+
>>>>>>> 9df7271 Extract maven-resolver-api from the embedded runtime bundle
917
org.eclipse.m2e.jdt;bundle-version="[2.0.0,3.0.0)",
1018
org.eclipse.core.runtime,
1119
org.eclipse.jdt.core,

target-platform/target-platform.target

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,16 @@ Export-Package: org.apache.maven.*;-noimport:=true;provider=m2e;mandatory
189189
Import-Package: !*
190190
]]></instructions>
191191
</location>
192+
<location includeDependencyDepth="none" includeSource="true" label="Maven Resolver" missingManifest="generate" type="Maven">
193+
<dependencies>
194+
<dependency>
195+
<groupId>org.apache.maven.resolver</groupId>
196+
<artifactId>maven-resolver-api</artifactId>
197+
<version>1.9.20</version>
198+
<type>jar</type>
199+
</dependency>
200+
</dependencies>
201+
</location>
192202
<location type="Target" uri="file:${project_loc:/m2e-core}/target-platform/m2e-runtimes.target"/>
193203
</locations>
194204
</target>

0 commit comments

Comments
 (0)