Skip to content

Commit 9459582

Browse files
committed
[Setup] Remove disable P2-director and set id for worksing sets
The connectors defined in the disabled P2-director are not compatible with m2e and are unlikely to become compatible in the future (project seems abandoned) and are actually not necessary anymore.
1 parent 9c81b2a commit 9459582

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

setup/m2e.setup

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
xmlns:setup.p2="http://www.eclipse.org/oomph/setup/p2/1.0"
1414
xmlns:setup.workingsets="http://www.eclipse.org/oomph/setup/workingsets/1.0"
1515
xmlns:workingsets="http://www.eclipse.org/oomph/workingsets/1.0"
16-
xsi:schemaLocation="http://www.eclipse.org/oomph/setup/git/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Git.ecore http://www.eclipse.org/oomph/setup/jdt/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/JDT.ecore http://www.eclipse.org/oomph/setup/maven/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Maven.ecore http://www.eclipse.org/oomph/setup/pde/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/PDE.ecore http://www.eclipse.org/oomph/predicates/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Predicates.ecore http://www.eclipse.org/oomph/setup/projects/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Projects.ecore http://www.eclipse.org/oomph/setup/workingsets/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/SetupWorkingSets.ecore http://www.eclipse.org/oomph/workingsets/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/WorkingSets.ecore"
16+
xsi:schemaLocation="http://www.eclipse.org/oomph/setup/git/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Git.ecore http://www.eclipse.org/oomph/setup/jdt/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/JDT.ecore http://www.eclipse.org/oomph/setup/maven/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Maven.ecore http://www.eclipse.org/oomph/setup/pde/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/PDE.ecore http://www.eclipse.org/oomph/predicates/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Predicates.ecore http://www.eclipse.org/oomph/setup/projects/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Projects.ecore http://www.eclipse.org/oomph/setup/workingsets/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/SetupWorkingSets.ecore http://www.eclipse.org/oomph/workingsets/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/WorkingSets.ecore"
1717
name="m2e"
1818
label="m2e">
1919
<annotation
@@ -95,19 +95,6 @@
9595
url="https://download.eclipse.org/technology/m2e/snapshots/latest/"/>
9696
<description>Install the tools needed in the IDE to work with the source code for ${scope.project.label}</description>
9797
</setupTask>
98-
<setupTask
99-
xsi:type="setup.p2:P2Task"
100-
disabled="true"
101-
label="m2e - connectors">
102-
<requirement
103-
name="org.sonatype.m2e.modello.feature.feature.group"/>
104-
<requirement
105-
name="com.ianbrandt.tools.m2e.mdp.feature.feature.group"/>
106-
<repository
107-
url="https://repo1.maven.org/maven2/.m2e/connectors/m2eclipse-modello/0.16.0/N/LATEST/"/>
108-
<repository
109-
url="https://ianbrandt.github.io/m2e-maven-dependency-plugin/"/>
110-
</setupTask>
11198
<setupTask
11299
xsi:type="git:GitCloneTask"
113100
id="git.clone.m2e.core"
@@ -169,7 +156,8 @@
169156
locateNestedProjects="true"/>
170157
</setupTask>
171158
<setupTask
172-
xsi:type="setup.workingsets:WorkingSetTask">
159+
xsi:type="setup.workingsets:WorkingSetTask"
160+
id="m2e.workingsets">
173161
<workingSet
174162
name="m2e-core"
175163
id="m2e.core">
@@ -181,7 +169,7 @@
181169
includeNestedRepositories="true"/>
182170
<operand
183171
xsi:type="workingsets:ExclusionPredicate"
184-
excludedWorkingSet="//@setupTasks.11/@workingSets[name='m2e-core-tests'] //@setupTasks.11/@workingSets[name='m2e-maven-runtime']"/>
172+
excludedWorkingSet="//'m2e.workingsets'/@workingSets[name='m2e-core-tests'] //'m2e.workingsets'/@workingSets[name='m2e-maven-runtime']"/>
185173
</predicate>
186174
</workingSet>
187175
<workingSet

0 commit comments

Comments
 (0)