Skip to content

Commit 980359a

Browse files
committed
Clean up MavenRuntimeClasspathProvider and m2e.editor.lemminx metadata
1 parent 6e71772 commit 980359a

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

org.eclipse.m2e.editor.lemminx/META-INF/MANIFEST.MF

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@ Bundle-Name: M2E Maven POM File Editor using Wild Web Developer, LemMinX and Mav
44
Bundle-SymbolicName: org.eclipse.m2e.editor.lemminx;singleton:=true
55
Bundle-Version: 2.0.4.qualifier
66
Automatic-Module-Name: org.eclipse.m2e.xmlls.extension
7-
Import-Package: org.eclipse.core.runtime;version="3.5.0",
7+
Import-Package: javax.inject;version="[1.0.0,2.0.0)",
8+
org.eclipse.core.runtime;version="3.5.0",
89
org.osgi.framework;version="1.10.0",
910
org.slf4j;version="[1.7.0,3.0.0)"
10-
Require-Bundle: javax.inject,
11-
org.eclipse.wildwebdeveloper.xml;bundle-version="[1.1,1.2)",
11+
Require-Bundle: org.eclipse.wildwebdeveloper.xml;bundle-version="[1.1,1.2)",
1212
org.eclipse.lsp4e;bundle-version="0.16.0",
1313
org.eclipse.lsp4j;bundle-version="0.9.0",
1414
org.eclipse.m2e.core,
15-
org.eclipse.m2e.maven.runtime;bundle-version="[3.8.6,4.0.0)"
15+
org.eclipse.m2e.maven.runtime;bundle-version="[3.8.6,4.0.0)",
16+
org.eclipse.core.resources
1617
Bundle-RequiredExecutionEnvironment: JavaSE-17
1718
Bundle-Vendor: Eclipse.org - m2e

org.eclipse.m2e.editor.lemminx/src/org/eclipse/m2e/editor/lemminx/MavenRuntimeClasspathProvider.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.util.ArrayList;
2020
import java.util.List;
2121
import java.util.Map;
22+
import java.util.Optional;
2223
import java.util.concurrent.CompletableFuture;
2324
import java.util.stream.Stream;
2425

@@ -54,8 +55,8 @@ public MavenRuntimeClasspathProvider() {
5455
DidChangeConfigurationParams params = new DidChangeConfigurationParams(Map.of("xml", options));
5556

5657
LanguageServers.forProject(null).withPreferredServer(definition).excludeInactive()
57-
.collectAll((w, ls) -> CompletableFuture.completedFuture(ls)).thenAccept(
58-
lss -> lss.stream().forEach(ls -> ls.getWorkspaceService().didChangeConfiguration(params)));
58+
.collectAll((w, ls) -> CompletableFuture.completedFuture(ls)).thenAccept(lss -> lss.stream()
59+
.forEach(ls -> ls.getWorkspaceService().didChangeConfiguration(params)));
5960

6061
};
6162
MavenPlugin.getMavenConfiguration().addConfigurationChangeListener(mavenConfigurationlistener);
@@ -70,12 +71,9 @@ public List<File> get() {
7071
addJarsFromBundle(FrameworkUtil.getBundle(org.apache.maven.Maven.class), "/jars/", mavenRuntimeJars);
7172
// Libraries that are also required and not included in
7273
// org.eclipse.m2e.maven.runtime
73-
try {
74-
mavenRuntimeJars.add(FileLocator.getBundleFile(FrameworkUtil.getBundle(javax.inject.Inject.class)));
75-
mavenRuntimeJars.add(FileLocator.getBundleFile(FrameworkUtil.getBundle(org.slf4j.Logger.class)));
76-
} catch (IOException e) {
77-
LOG.error(e.getMessage(), e);
78-
}
74+
Stream.of(javax.inject.Inject.class, org.slf4j.Logger.class)//
75+
.map(FrameworkUtil::getBundle).map(FileLocator::getBundleFileLocation)//
76+
.flatMap(Optional::stream).forEach(mavenRuntimeJars::add);
7977
return mavenRuntimeJars;
8078
}
8179

0 commit comments

Comments
 (0)