Improve wording and icons in the DiscoveryDialog

Currently the DiscoveryDialog shows missing messages with a big red x
and a text that says "resolve later", this gives an expression something
is generally broken / error. Actually m2e now executes all mojos by
default, and even before it shows non executed mojos as warnings.

This replaces the error icon with a light-bulb/info icon so the user
knows there is something one can take an action on but it is probably
not that important to be concerned about (right now), and adjust the
text to reflect that if nothing is choose it will just do whatever is
choose in the workspace settings.

Author: laeubi

org.eclipse.m2e.core.ui/icons/quick_fix_info_obj.png

@@ -87,6 +87,8 @@ public class MavenImages {
 
   public static final Image IMG_PASSED = createImage("passed.png"); //$NON-NLS-1$
 
+  public static final Image IMG_INFO_AUTO = createImage("quick_fix_info_obj.png"); //$NON-NLS-1$
+
   public static final Image IMG_POM = POM.createImage();
 
   public static final Image IMG_ERROR = createImage("error_st_obj.png"); //$NON-NLS-1$

org.eclipse.m2e.core.ui/icons/[email protected]

@@ -129,7 +129,7 @@ public class Messages extends NLS {
 
   public static String LifecycleMappingPage_numErrors;
 
-  public static String LifecycleMappingPage_resolveLaterDescription;
+  public static String LifecycleMappingPage_useDefaultMapping;
 
   public static String LifecycleMappingPage_title;
 

org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/MavenImages.java

@@ -76,7 +76,7 @@ LifecycleMappingPage_licenseLabel=License
 LifecycleMappingPage_mavenBuildColumnTitle=Maven Build
 LifecycleMappingPage_noMarketplaceEntryDescription=No marketplace entries found to handle {0} in Eclipse.  Please see Help for more information.
 LifecycleMappingPage_numErrors={0} errors
-LifecycleMappingPage_resolveLaterDescription=Resolve Later
+LifecycleMappingPage_useDefaultMapping=Use Workspace Default
 LifecycleMappingPage_title=Setup Maven plugin connectors
 LifecycleMappingPreferencePage_Browse=Browse...
 LifecycleMappingPreferencePage_ChangeLocation=Change mapping file location\:

org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/Messages.java

@@ -241,7 +241,7 @@ protected CellEditor getCellEditor(Object element) {
           for(IMavenDiscoveryProposal prop : all) {
             values.add(NLS.bind(Messages.LifecycleMappingPage_installDescription, prop.toString()));
           }
-          values.add(Messages.LifecycleMappingPage_resolveLaterDescription);
+          values.add(Messages.LifecycleMappingPage_useDefaultMapping);
 
           addIgnoreProposals(values, prov);
           ComboBoxCellEditor edit = new ComboBoxCellEditor(treeViewer.getTree(),
@@ -390,12 +390,7 @@ public void addListener(ILabelProviderListener listener) {
       public String getColumnText(Object element, int columnIndex) {
         if(element instanceof ILifecycleMappingLabelProvider prov) {
           if(columnIndex == MAVEN_INFO_IDX) {
-            String text = prov.getMavenText();
-            if(prov instanceof AggregateMappingLabelProvider aggProv && !isHandled(prov)) {
-              text = NLS.bind(Messages.LifecycleMappingPage_errorMavenBuild,
-                  new String[] {text, String.valueOf(aggProv.getChildren().length)});
-            }
-            return text;
+            return prov.getMavenText();
           } else if(columnIndex == ACTION_INFO_IDX && element instanceof AggregateMappingLabelProvider) {
             IMavenDiscoveryProposal proposal = mappingConfiguration.getSelectedProposal(prov.getKey());
             if(ignore.contains(element)) {
@@ -409,7 +404,7 @@ public String getColumnText(Object element, int columnIndex) {
             } else if(loading || !prov.isError(mappingConfiguration)) {
               return EMPTY_STRING;
             } else {
-              return Messages.LifecycleMappingPage_resolveLaterDescription;
+              return Messages.LifecycleMappingPage_useDefaultMapping;
             }
           }
         }
@@ -423,7 +418,10 @@ public Image getColumnImage(Object element, int columnIndex) {
         }
         if(element instanceof AggregateMappingLabelProvider prov) {
           if(prov.isError(mappingConfiguration) && !isHandled(prov)) {
-            return MavenImages.IMG_ERROR;
+            //historically missing mappings where shows as ERROR (therefore the name isError)
+            //but now m2e execute missing mappings according on user request so this is more an info that
+            //it is handled automatic and the user can choose to change this
+            return MavenImages.IMG_INFO_AUTO;
           }
           return MavenImages.IMG_PASSED;
         }