Provide Quick-Fix to enable execution if not connector is found

[laeubi]

Currently if a mapping is missing, the user is presented with the following options:

This only let the user find a connector or disable execution, but actually the user probably want to configure it in a way to execute the mapping using <?m2e execute onConfiguration?> (or incremental) as described here #1013 (comment))

[HannesWell]

This only let the user find a connector or disable execution, but actually the user probably want to configure it in a way to execute the mapping using <?m2e execute onConfiguration?> (or incremental) as described here #1013 (comment))

Yes that would be good. 👍🏽 I especially like the processing-instruction based mappings because they are far less verbose and more focused.
And there is actually even a third option: <?m2e execute ?>, which executes only on full builds. For completeness we could consider to add a corresponding argument onFullBuild, to have onConfiguration, onFullBuild onIncremental. Then onIncremental should be replaced/aliased by onIncrementalBuild to only have onConfiguration, onFullBuild onIncrementalBuild?

[laeubi]

I think "incremental" is even the same as "full" this is a bit confusing and eclipse itself actually has a clean build option so actually it would be good to have:

• configure
• build
• clean

By the way is there any configuration / code reference on this part of m2e? I haven't found one just the usual lifecyclemapping references, so maybe we can have at least a small wiki page describing this.

[HannesWell]

It is indeed not very clear.

There is a release note from long ago:
https://www.eclipse.org/m2e/documentation/release-notes-17.html#new-syntax-for-specifying-lifecycle-mapping-metadata
Nevertheless describing this in some documentation (not only release notes) would be better to find. But I think we should not start a wiki when we have a web-site. This could happen as part of #831

That doc tells something different than I thought would happen if one only has execute.
However, the clean option is a good idea. But couldn't M2E just be smart and run mojos marked to execute that are bound to the clean-lifecycle/phase in the clean build instead of the full/incremental build? Then there is no need for an extra option.

Nevertheless I think it can be good to have an execution only on full builds for things that are too heavy weight to execute on incremental, but should happen more often than only on configuration/initialization. E.g. build some documentation.

If possible we could add some details in the view, which pops up when you hover over elements in the pom-editor, that describes the processing-instruction.

[dstango]

I'd like to second using the processing-instructions. Is this issue sufficient to tackle it, or does it need a separate issue to request changing the pom.xml-modifications by the existing quick fix to processing-instructions?

[laeubi]

@dstango yes this issue can / should be used for this and using processing instructions seems most "lightweight" if added to the pom.

[dstango]

@laeubi sounds good. It also prevents the warning maven usually prints because of the non-existent lifecyle-mapping plugin, which has never been fixed: https://bugs.eclipse.org/bugs/show_bug.cgi?id=367870

Actually I think it would be great to have an additional quick-fix in the pom-editor to transform existing lifecycle-mapping-entries into the appropriate processing-instructions.
And if I'd dream on I'd even wish for a deprecation warning when the lifecycle-mapping is used n the pom ... (unless it could perform other functions that I'm not aware of.)

[laeubi]

@dstango dreams can come true with just opening a PR :-D

[dstango]

hehe ... ;-)
@laeubi Any hint/link how to easily setup an environment to be able to test and contribute to this project/module?

I contributed last year a little something to the eclipse platform, but when everything moved from gerrit to github I got lost on the way... so I guess I'd need to start all over with a current setup.

[laeubi]

https://github.com/eclipse-m2e/m2e-core/blob/master/CONTRIBUTING.md

[dstango]

@laeubi thanks, I'll check it out

[dstango]

@laeubi so I set it up (yet skipped RCPTT for the moment, hope that's okay), and tried m2e-core--build, resulting in:
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-baseline-plugin:4.0.0-SNAPSHOT:verify (baseline-check) on project org.eclipse.m2e.archetype.common: Baseline problems found! Project version: 3.2.103.20230102-2253, baseline version: 3.2.103.20230102-2253, suggested version: 3.2.104

Where can I go from here?

PS: I tried to change the version of org.eclipse.m2e.archetype.common/pom.xml to 3.2.104-SNAPSHOT, which resulted in my build running longer, but ending up in a similar error message for some other pom ... so this seems to be like rabbit hole to me ... ;-)

[laeubi]

@dstango in the log there should be a table mentioning why a version change is suggested, can you take a look here and maybe provide the file in question as a zipped item here?

If you change the version in org.eclipse.m2e.archetype.common make sure you adjust it as well in the pom.xml as well where it is referenced as a dependency.

[dstango]

@laeubi thatnks, here's the message table:

 ┌──────────────────────────┬──────────────────────────┬──────────────────────────┬─────────────────────────┬─────────────────────────┬─────────────────────────┐
 │Delta                     │Type                      │Name                      │Project Version          │Baseline Version         │Suggested Version        │
 ├──────────────────────────┼──────────────────────────┼──────────────────────────┼─────────────────────────┼─────────────────────────┼─────────────────────────┤
 │MICRO                     │RESOURCES                 │org.eclipse.m2e.archetype.│3.2.103                  │3.2.103                  │3.2.104                  │
 │                          │                          │common_3.2.103.20230102-22│                         │                         │                         │
 │                          │                          │53.jar                    │                         │                         │                         │
 ├──────────────────────────┼──────────────────────────┼──────────────────────────┴─────────────────────────┴─────────────────────────┴─────────────────────────┤
 │..CHANGED                 │RESOURCE                  │about.html                                                                                              │
 ├──────────────────────────┴──────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────┤
 │different                                                                                                                                                     │
 └──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
 C:\Java\eclipse-contribution\m2e-master\git\m2e-core\m2e-maven-runtime\org.eclipse.m2e.archetype.common [0:0]: Baseline problems found! Project version: 3.2.103.20230102-2253, baseline version: 3.2.103.20230102-2253, suggested version: 3.2.104

here's the zipped jar file:
org.eclipse.m2e.archetype.common_3.2.103.20230102-2253.zip

If there were a change in the about.html file it should show up in the git log, shouldn't it? I can only find a last change in 2020.

A little above the table there are some warnings - don't know if they are of interest:

[INFO] --- bnd-maven-plugin:6.4.0:bnd-process (prepare-jar-with-manifest) @ org.eclipse.m2e.archetype.common ---
[WARNING] C:\Java\eclipse-contribution\m2e-master\git\m2e-core\m2e-maven-runtime\org.eclipse.m2e.archetype.common\pom.xml [0:0]: Host org.eclipse.m2e.maven.runtime=bundle-version="[3.0.0,4.0.0)" for this fragment/require bundle cannot be found on the classpath
[WARNING] C:\Java\eclipse-contribution\m2e-master\git\m2e-core\m2e-maven-runtime\org.eclipse.m2e.archetype.common\pom.xml [0:0]: Host com.ibm.icu= for this fragment/require bundle cannot be found on the classpath
[WARNING] C:\Java\eclipse-contribution\m2e-master\git\m2e-core\m2e-maven-runtime\org.eclipse.m2e.archetype.common\pom.xml [0:0]: Export org.apache.maven.archetype.common,  has 1,  private references [org.jdom2]
[WARNING] C:\Java\eclipse-contribution\m2e-master\git\m2e-core\m2e-maven-runtime\org.eclipse.m2e.archetype.common\pom.xml [0:0]: Export org.apache.maven.archetype.common.util,  has 2,  private references [org.jdom2, org.jdom2.output]
[WARNING] C:\Java\eclipse-contribution\m2e-master\git\m2e-core\ANONYMOUS [0:0]: Invalid package name: 'META-INF.plexus' in Export-Package

Regarding:

If you change the version in org.eclipse.m2e.archetype.common make sure you adjust it as well in the pom.xml as well where it is referenced as a dependency.

I only tried to change the version in the pom.xml - can't find it anywhere else. Where exactly else should I look? I only found MANIFEST.MF-entries with version ranges, that seemed to match.

I found one reference to org.eclipse.m2e.archetype.common, though and changed that to 3.2.104-SNAPSHOT. The I run into the next issue with a new table:

[ERROR] ┌──────────────────────────┬──────────────────────────┬──────────────────────────┬─────────────────────────┬─────────────────────────┬─────────────────────────┐
[ERROR] │Delta                     │Type                      │Name                      │Project Version          │Baseline Version         │Suggested Version        │
[ERROR] ├──────────────────────────┼──────────────────────────┼──────────────────────────┼─────────────────────────┼─────────────────────────┼─────────────────────────┤
[ERROR] │MICRO                     │RESOURCES                 │org.eclipse.m2e.maven.runt│3.8.701                  │3.8.701                  │3.8.702                  │
[ERROR] │                          │                          │ime_3.8.701.20230209-1606.│                         │                         │                         │
[ERROR] │                          │                          │jar                       │                         │                         │                         │
[ERROR] ├──────────────────────────┼──────────────────────────┼──────────────────────────┴─────────────────────────┴─────────────────────────┴─────────────────────────┤
[ERROR] │..CHANGED                 │RESOURCE                  │META-INF/sisu/javax.inject.Named                                                                        │
[ERROR] ├──────────────────────────┴──────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────┤
[ERROR] │different                                                                                                                                                     │
[ERROR] ├──────────────────────────┬──────────────────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────┤
[ERROR] │..CHANGED                 │RESOURCE                  │about.html                                                                                              │
[ERROR] ├──────────────────────────┴──────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────┤
[ERROR] │different                                                                                                                                                     │
[ERROR] └──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
[ERROR] C:\Java\eclipse-contribution\m2e-master\git\m2e-core\m2e-maven-runtime\org.eclipse.m2e.maven.runtime [0:0]: Baseline problems found! Project version: 3.8.701.20230209-1606, baseline version: 3.8.701.20230209-1606, suggested version: 3.8.702

Of course I could try to manually tweak with these versions ad infinitum, but I wonder if I'm doing something basic wrong here, as I somehow expected cloning the master branch should result in a compilable build ... ;-)

Next thing I'm gonna try is simply going back in git to some released version like 2.2.1 and see if that's buildable.