Nightly build files not publishing?

[jasonk000]

I notice the nightly build doesn't seem to be updating on the MAT update website?

https://download.eclipse.org/mat/snapshots/update-site/

Last publish date looks to be June 6.

	..
	binary	11.4K	2024-06-06 11:28
	features	72K	2024-06-06 11:28
	plugins	15.1M	2024-06-06 11:28
	artifacts.jar	5.6k	2024-06-06 11:28
	artifacts.xml.xz	4.8k	2024-06-06 11:28
	content.jar	24.5k	2024-06-06 11:27
	content.xml.xz	10.9k	2024-06-06 11:28
	p2.index	172	2024-06-06 11:28

Do we need to finalise the work in #55 GH Actions workflow? I had assumed the old pipelines would continue to run post-migration.

[jasonk000]

@krumts it looks like this is dash/cyclone issue, are you able to suggest any things to investigate?

Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Map.keySet()" because "this.approvedLicenses" is null

The keySet() call has been throughout the code for many years, so this seems to be a new issue.

I can see you made this commit -- 4535fc2, but I do not see exactly where we specify the license. I assume since we do not provide one that it resorts to the dash-license-plugin source, which looks to be here

public static final String DEFAULT_APPROVED_LICENSES_URL = "https://www.eclipse.org/legal/licenses.json";

I tried to set it directly, but no success.

                        <plugin>
                                <groupId>org.eclipse.dash</groupId>
                                <artifactId>license-tool-plugin</artifactId>
                                <version>1.0.2</version>
                                <configuration>
                                        <licenses>https://www.eclipse.org/legal/licenses.json</licenses>
                                </configuration>
                                ...
                        </plugin>

Only thing I see suspicious in the logs references j9 and SWT.

[WARNING] Problems resolving provisioning plan.: [Unable to satisfy dependency from org.eclipse.swt 3.121.0.v20220829-1402 to org.eclipse.equinox.p2.iu; org.eclipse.swt.gtk.linux.ppc64le [3.121.0.v20220829-1402,3.121.0.v20220829-1402].]
[WARNING] Problems resolving provisioning plan.: [Unable to satisfy dependency from org.eclipse.swt 3.121.0.v20220829-1402 to org.eclipse.equinox.p2.iu; org.eclipse.swt.gtk.linux.aarch64 [3.121.0.v20220829-1402,3.121.0.v20220829-1402].]
[WARNING] Bundle-ClassPath entry lib/j9ddr-structs.jar does not exist in /Users/jkoch/.m2/repository/p2/osgi/bundle/com.ibm.dtfj.j9/1.12.29003.202006111057/com.ibm.dtfj.j9-1.12.29003.202006111057.jar
[WARNING] Bundle-ClassPath entry lib/j9ddr-structs.jar does not exist in /Users/jkoch/.m2/repository/p2/osgi/bundle/com.ibm.dtfj.j9/1.12.29003.202006111057/com.ibm.dtfj.j9-1.12.29003.202006111057.jar

I can see the history here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=582480

[krumts]

@jasonk000 , sorry for the delayed reply. Something changed and both local and jenkins builds are failing reproducibly - also for older MAT commits, which used to build fine.
I figured out, that the default url for licenses which you pasted replies with a 302 redirect to https://www.eclipse.org/legal/licenses/licenses.json (i.e. one folder "licenses" deeper). Is looks like the dash plugin doesn't handle the redirects correct.
Adding the new URL explicitly (as you did with the old one) fixed my local builds.
I'll push a fix for it and hope this would fix also the jenkins build.
I'll see if the issue was reported on dash and do so if this is not yet the case.

[krumts]

#66 fixed the build and I confirmed that also the contents of the update site got updated.

[jasonk000]

Ah, great work, I'd never checked for redirects, and must have mixed up my report. Thank you for taking care of it.

[krumts]

It turned out, that the latest version of the license-tool-plugin works fine with the redirects. I just didn't see that this version exists (although I checked :) ). So, I made a second change - upgrading to the latest version and removed the explicit URL config.