Problems using uanodeset

[johannwesely]

Hello Kevin,

you suggested me the https://github.com/digitalpetri/uanodeset. I tried to use it as my new nodeset parser but ran into a problem when the Nodesetloader comes to registerDynamicDataType it calls DataTypeCodec.create and in some cases there is no definition and i get an runtimeexception.

 public static DataTypeCodec create(DataType dataType, DataTypeTree dataTypeTree) {
    DataTypeDefinition definition = dataType.getDataTypeDefinition();

    if (definition instanceof EnumDefinition) {
      // If we're asked to create a DataTypeCodec and the definition is an EnumDefinition,
      // that means it's an OptionSet subclass. True enumerations are encoded/decoded as
      // integers, so they don't have a corresponding codec.
      return new DynamicOptionSetCodec(dataType);
    } else if (definition instanceof StructureDefinition structureDefinition) {
      return switch (structureDefinition.getStructureType()) {
        case Structure, StructureWithOptionalFields, StructureWithSubtypedValues ->
            new DynamicStructCodec(dataType, dataTypeTree);
        case Union, UnionWithSubtypedValues -> new DynamicUnionCodec(dataType, dataTypeTree);
      };
    } else {
// <<<<<<<<<< What if Definition is null ?
      throw new RuntimeException("unknown DataTypeDefinition: " + definition);
    }
  } 

So do you have any suggestions ? Greetings Johann

[kevinherron]

Maybe something like this change to NodeSetNodeLoader:

Index: uanodeset-namespace/src/main/java/com/digitalpetri/opcua/uanodeset/namespace/NodeSetNodeLoader.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/uanodeset-namespace/src/main/java/com/digitalpetri/opcua/uanodeset/namespace/NodeSetNodeLoader.java b/uanodeset-namespace/src/main/java/com/digitalpetri/opcua/uanodeset/namespace/NodeSetNodeLoader.java
--- a/uanodeset-namespace/src/main/java/com/digitalpetri/opcua/uanodeset/namespace/NodeSetNodeLoader.java	(revision 0d5b6d2f6196df4c90faa301001454bc1129bdfc)
+++ b/uanodeset-namespace/src/main/java/com/digitalpetri/opcua/uanodeset/namespace/NodeSetNodeLoader.java	(date 1743694753417)
@@ -200,9 +200,13 @@
               (UaDataTypeNode)
                   context.getNodeManager().getNode(reindexNodeId(nodeId)).orElseThrow();
 
-          dataTypeNode.setDataTypeDefinition(newDataTypeDefinition(dataType, dataTypeTree));
+          var dataTypeDefinition = newDataTypeDefinition(dataType, dataTypeTree);
+
+          if (dataTypeDefinition != null) {
+            dataTypeNode.setDataTypeDefinition(dataTypeDefinition);
 
-          registerDynamicDataType(dataTypeNode.getNodeId());
+            registerDynamicDataType(dataTypeNode.getNodeId());
+          }
         }
       }
     }
@@ -702,7 +706,7 @@
     return new AccessRestrictionType(ushort(value));
   }
 
-  private org.eclipse.milo.opcua.stack.core.types.structured.DataTypeDefinition
+  private @Nullable org.eclipse.milo.opcua.stack.core.types.structured.DataTypeDefinition
       newDataTypeDefinition(UADataType dataType, DataTypeInfoTree dataTypeTree) {
 
     DataTypeDefinition definition = dataType.getDefinition();

[kevinherron]

It seems that the definition may be null e.g. when the DataType is a simple or alias type, like how the built-in Duration type is really just a Double.

[kevinherron]

I just pushed a commit with this change in it: digitalpetri/uanodeset@e8e02d8

It should be deployed under 0.2-SNAPSHOT by now.