Node Management Support

[johannwesely]

Hello,
we are right now in the certification process of our milo server.
One Point that occured during the process is this:
"Node Management:
Service calls return OperationResults with Bad_NotSupported. Which operations of this service are supported?"

Greetings Johann

[kevinherron]

None are implemented by the SDK, but all can be implemented by users of the SDK by overriding the corresponding methods in AddressSpace:

milo/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/AddressSpace.java

Lines 279 to 309 in 253e115

	// region NodeManagement Services
	default List<AddNodesResult> addNodes(AddNodesContext context, List<AddNodesItem> nodesToAdd) {
	AddNodesResult result =
	new AddNodesResult(new StatusCode(StatusCodes.Bad_NotSupported), NodeId.NULL_VALUE);
	return Collections.nCopies(nodesToAdd.size(), result);
	}
	default List<StatusCode> deleteNodes(
	DeleteNodesContext context, List<DeleteNodesItem> nodesToDelete) {
	StatusCode statusCode = new StatusCode(StatusCodes.Bad_NotSupported);
	return Collections.nCopies(nodesToDelete.size(), statusCode);
	}
	default List<StatusCode> addReferences(
	AddReferencesContext context, List<AddReferencesItem> referencesToAdd) {
	StatusCode statusCode = new StatusCode(StatusCodes.Bad_NotSupported);
	return Collections.nCopies(referencesToAdd.size(), statusCode);
	}
	default List<StatusCode> deleteReferences(
	DeleteReferencesContext context, List<DeleteReferencesItem> referencesToDelete) {
	StatusCode statusCode = new StatusCode(StatusCodes.Bad_NotSupported);
	return Collections.nCopies(referencesToDelete.size(), statusCode);
	}
	// endregion

[johannwesely]

Hello, we had an discussion today with S.Allmendinger and he said that:" If not implemented, it should throw BAD_SERVICE_UNSUPPORTED on ServiceLevel, and must not throw an error on OperationResult".

[kevinherron]

Like with the history services, I have no solution for this right now. The SDK passes these service calls to user code in case they are implemented, or in the case of history, if there are currently historical nodes present. I will have to figure out some way to allow the services / service sets to be configurable so that you can sub in implementations that return Bad_ServiceUnsupported for the entire service call.

[kevinherron]

Ok, for now, something like this:

server.addServiceSet(
    "",
    new DefaultNodeManagementServiceSet(server) {
      @Override
      public AddNodesResponse onAddNodes(ServiceRequestContext context, AddNodesRequest request)
          throws UaException {

        throw new UaException(StatusCodes.Bad_ServiceUnsupported);
      }

      @Override
      public DeleteNodesResponse onDeleteNodes(
          ServiceRequestContext context, DeleteNodesRequest request) throws UaException {

        throw new UaException(StatusCodes.Bad_ServiceUnsupported);
      }

      @Override
      public AddReferencesResponse onAddReferences(
          ServiceRequestContext context, AddReferencesRequest request) throws UaException {

        throw new UaException(StatusCodes.Bad_ServiceUnsupported);
      }

      @Override
      public DeleteReferencesResponse onDeleteReferences(
          ServiceRequestContext context, DeleteReferencesRequest request) throws UaException {

        throw new UaException(StatusCodes.Bad_ServiceUnsupported);
      }
    });