Historical Access

[johannwesely]

Hello,
here is Another Point from the certification process:
"Historical Access:
Service calls do not return Bad_ServiceUnsupported. No node with Historizing == True or AccessLevel == History Read/Write could be found within the address space of the server. "
So we have actually no nodes with historical Access do i need to deactivate this Service somehow to avoid the error?

Greetings Johann

[kevinherron]

Hmm, currently operation level Bad_HistoryOperationUnsupported is returned.

I'm not sure it's required that the service level return Bad_ServiceUnsupported just because there happen to be no nodes that are currently history-enabled.

milo/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/AddressSpace.java

Lines 76 to 112 in 253e115

	/**
	* Read history values from nodes belonging to this {@link AddressSpace}.
	*
	* @param context the {@link HistoryReadContext}.
	* @param timestamps requested timestamp values.
	* @param readValueIds the values to read.
	* @return the {@link HistoryReadResult}s read.
	*/
	default List<HistoryReadResult> historyRead(
	HistoryReadContext context,
	HistoryReadDetails readDetails,
	TimestampsToReturn timestamps,
	List<HistoryReadValueId> readValueIds) {
	HistoryReadResult result =
	new HistoryReadResult(
	new StatusCode(StatusCodes.Bad_HistoryOperationUnsupported), null, null);
	return Collections.nCopies(readValueIds.size(), result);
	}
	/**
	* Update history values in nodes belonging to this {@link AddressSpace}.
	*
	* @param context the {@link HistoryUpdateContext}.
	* @param updateDetails the values to read.
	* @return the {@link HistoryUpdateResult}s for each update.
	*/
	default List<HistoryUpdateResult> historyUpdate(
	HistoryUpdateContext context, List<HistoryUpdateDetails> updateDetails) {
	HistoryUpdateResult result =
	new HistoryUpdateResult(
	new StatusCode(StatusCodes.Bad_HistoryOperationUnsupported), null, null);
	return Collections.nCopies(updateDetails.size(), result);
	}

[johannwesely]

S. Allmendiger said here : "Either nodes must be present to test the services or ServiceLevel BAD_SERVICE_UNSUPPORTED must be thrown."

[kevinherron]

That sounds like a CTT problem... is there a passage in the spec they can point to that requires this?

[kevinherron]

For now, something like this:

server.addServiceSet(
    "",
    new DefaultAttributeServiceSet(server) {
      @Override
      public HistoryReadResponse onHistoryRead(
          ServiceRequestContext context, HistoryReadRequest request) throws UaException {

        throw new UaException(StatusCodes.Bad_ServiceUnsupported);
      }

      @Override
      public HistoryUpdateResponse onHistoryUpdate(
          ServiceRequestContext context, HistoryUpdateRequest request) throws UaException {

        throw new UaException(StatusCodes.Bad_ServiceUnsupported);
      }
    });