Perform clean code of mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core

eclipse-mylyn-bot · ruspl-afed · commit 14ad45bc009f · 2025-08-13T09:39:09.000+03:00
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CancellableInputStream.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CancellableInputStream.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2013 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CommonHttpResponse.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CommonHttpResponse.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2011, 2013 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/DefaultHttpOperation.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/DefaultHttpOperation.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2012 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
@@ -52,7 +52,7 @@ protected T process(CommonHttpResponse response, IOperationMonitor monitor) thro
 			doValidate(response, monitor);
 			return doProcess(response, monitor);
 		} catch (IOException | RuntimeException e) {
-			response.release(monitor);
+			response.release();
 			throw e;
 		}
 	}
@@ -62,7 +62,7 @@ protected T processAndRelease(CommonHttpResponse response, IOperationMonitor mon
 			doValidate(response, monitor);
 			return doProcess(response, monitor);
 		} finally {
-			response.release(monitor);
+			response.release();
 		}
 	}
 
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpRequestProcessor.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpRequestProcessor.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2012 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpUtil.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpUtil.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2011, 2014 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
@@ -80,12 +80,6 @@ public class HttpUtil {
 		CoreUtil.initializeLoggingSettings();
 	}
 
-	@SuppressWarnings("unused")
-	private static final int BUFFER_SIZE = 4096;
-
-	@SuppressWarnings("unused")
-	private static final long CLOSE_TIMEOUT = -1;
-
 	/**
 	 * @see IdleConnectionMonitorThread
 	 */
@@ -101,9 +95,6 @@ public class HttpUtil {
 
 	private static final int SOCKET_TIMEOUT = 3 * 60 * 1000;
 
-	@SuppressWarnings("unused")
-	private static final int POLL_ATTEMPTS = SOCKET_TIMEOUT / POLL_INTERVAL;
-
 	private static SchemeSocketFactory socketFactory = new PollingProtocolSocketFactory();
 
 	private static SchemeSocketFactory sslSocketFactory = new PollingSslProtocolSocketFactory();
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/internal/commons/repositories/http/core/IdleConnectionMonitorThread.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/internal/commons/repositories/http/core/IdleConnectionMonitorThread.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2012 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
@@ -20,7 +20,7 @@
 
 /**
  * Closes idle connections periodically.
- * 
+ *
  * @author spingel
  */
 public class IdleConnectionMonitorThread extends Thread {
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/internal/commons/repositories/http/core/PollingProtocolSocketFactory.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/internal/commons/repositories/http/core/PollingProtocolSocketFactory.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2011, 2013 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
diff --git a/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/internal/commons/repositories/http/core/PollingSslProtocolSocketFactory.java b/mylyn.commons/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/internal/commons/repositories/http/core/PollingSslProtocolSocketFactory.java
@@ -1,10 +1,10 @@
 /*******************************************************************************
  * Copyright (c) 2011, 2013 Tasktop Technologies and others.
- * 
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
  * https://www.eclipse.org/legal/epl-2.0
- * 
+ *
  * SPDX-License-Identifier: EPL-2.0
  *
  *     Tasktop Technologies - initial API and implementation
@@ -33,7 +33,7 @@
 
 /**
  * Provides support for managing SSL connections.
- * 
+ *
  * @author Steffen Pingel
  */
 public class PollingSslProtocolSocketFactory implements LayeredSchemeSocketFactory {

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`	`1`	`/*******************************************************************************`
`2`	`2`	`* Copyright (c) 2012 Tasktop Technologies and others.`
`3`		`- *`
	`3`	`+ *`
`4`	`4`	`* This program and the accompanying materials are made available under the`
`5`	`5`	`* terms of the Eclipse Public License v. 2.0 which is available at`
`6`	`6`	`* https://www.eclipse.org/legal/epl-2.0`
`7`		`- *`
	`7`	`+ *`
`8`	`8`	`* SPDX-License-Identifier: EPL-2.0`
`9`	`9`	`*`
`10`	`10`	`* Tasktop Technologies - initial API and implementation`
`@@ -52,7 +52,7 @@ protected T process(CommonHttpResponse response, IOperationMonitor monitor) thro`
`52`	`52`	`doValidate(response, monitor);`
`53`	`53`	`return doProcess(response, monitor);`
`54`	`54`	`} catch (IOException \| RuntimeException e) {`
`55`		`- response.release(monitor);`
	`55`	`+ response.release();`
`56`	`56`	`throw e;`
`57`	`57`	`}`
`58`	`58`	`}`
`@@ -62,7 +62,7 @@ protected T processAndRelease(CommonHttpResponse response, IOperationMonitor mon`
`62`	`62`	`doValidate(response, monitor);`
`63`	`63`	`return doProcess(response, monitor);`
`64`	`64`	`} finally {`
`65`		`- response.release(monitor);`
	`65`	`+ response.release();`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`