Skip to content

Commit 161aa40

Browse files
eclipse-mylyn-botruspl-afed
authored andcommitted
Perform clean code of mylyn.reviews/org.eclipse.mylyn.gerrit.tests
1 parent 3711d2f commit 161aa40

32 files changed

+65
-82
lines changed

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/AllGerritTests.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -97,21 +97,4 @@ private static void addTests(TestSuite suite, TestConfiguration configuration) {
9797
}
9898
}
9999

100-
//FIXME: AF: enable tests
101-
//https://github.com/eclipse-mylyn/org.eclipse.mylyn.reviews/issues/5
102-
@SuppressWarnings("unused")
103-
private static void addTests(TestSuite suite, GerritFixture fixture) {
104-
fixture.createSuite(suite);
105-
fixture.add(GerritClientTest.class);
106-
fixture.add(GerritConnectorTest.class);
107-
fixture.add(GerritSynchronizationTest.class);
108-
fixture.add(GerritDataLocatorTest.class);
109-
fixture.add(GerritReviewRemoteFactoryJUnit3Test.class);
110-
fixture.add(PatchSetRemoteFactoryTest.class);
111-
fixture.add(PatchSetDetailRemoteFactoryTest.class);
112-
fixture.add(GerritUrlHandlerTest.class);
113-
fixture.add(GerritCapabilitiesTest.class);
114-
fixture.done();
115-
}
116-
117100
}

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/GerritConnectorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2012, 2015 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/GerritSynchronizationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2012, 2015 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/GerritCapabilitiesTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2014 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/GerritVersionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2013, 2015 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/OpenIdAuthenticationTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2012 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation
@@ -37,7 +37,7 @@
3737
@SuppressWarnings("nls")
3838
public class OpenIdAuthenticationTest extends TestCase {
3939

40-
private class StubRepositoryLocation extends WebLocation implements IOpenIdLocation {
40+
private static class StubRepositoryLocation extends WebLocation implements IOpenIdLocation {
4141

4242
String providerUrl;
4343

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/compat/ChangeDetailXTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2013, 2015 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation
@@ -139,7 +139,7 @@ private ChangeDetailXAsResult parseFile(String path) throws IOException {
139139
return new JSonSupport().parseResponse(content, ChangeDetailXAsResult.class);
140140
}
141141

142-
private class ChangeDetailXAsResult {
142+
private static class ChangeDetailXAsResult {
143143
private String jsonrpc;
144144

145145
private int id;

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/compat/PatchScriptXTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2014 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation
@@ -50,7 +50,7 @@ private PatchScriptX parseFile(String path) throws IOException {
5050
return result.result;
5151
}
5252

53-
private class PatchScriptXAsResult {
53+
private static class PatchScriptXAsResult {
5454
private String jsonrpc;
5555

5656
private int id;

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/rest/AbandonInputTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2013 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation

mylyn.reviews/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/gerrit/tests/core/client/rest/AccountInfoTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*******************************************************************************
22
* Copyright (c) 2013 Tasktop Technologies and others.
3-
*
3+
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License v. 2.0 which is available at
66
* https://www.eclipse.org/legal/epl-2.0
7-
*
7+
*
88
* SPDX-License-Identifier: EPL-2.0
99
*
1010
* Tasktop Technologies - initial API and implementation

0 commit comments

Comments
 (0)