Skip to content

Commit 768ba4c

Browse files
committed
Performing a VM EclipseIniTask should match prefixes more carefully
#182
1 parent 6ad98a3 commit 768ba4c

File tree

7 files changed

+13
-12
lines changed

7 files changed

+13
-12
lines changed

plugins/org.eclipse.oomph.setup.core/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.24.0,4.0.0)",
3232
org.eclipse.equinox.security;bundle-version="[1.0.0,2.0.0)",
3333
org.eclipse.oomph.base.edit;bundle-version="[1.18.0,2.0.0)",
3434
org.eclipse.oomph.p2.core;bundle-version="[1.33.0,2.0.0)",
35-
org.eclipse.oomph.setup;bundle-version="[1.32.0,2.0.0)";visibility:=reexport,
35+
org.eclipse.oomph.setup;bundle-version="[1.33.0,2.0.0)";visibility:=reexport,
3636
org.eclipse.oomph.setup.p2;bundle-version="[1.23.0,2.0.0)",
3737
org.eclipse.oomph.preferences;bundle-version="[1.15.0,2.0.0)",
3838
org.eclipse.core.net;bundle-version="[1.2.0,2.0.0)"

plugins/org.eclipse.oomph.setup.installer/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Bundle-Activator: org.eclipse.oomph.setup.internal.installer.SetupInstallerPlugi
1010
Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.24.0,4.0.0)",
1111
org.eclipse.emf.ecore.xmi;bundle-version="[2.10.0,3.0.0)",
1212
org.eclipse.emf.edit.ui;bundle-version="[2.10.0,3.0.0)",
13-
org.eclipse.oomph.setup;bundle-version="[1.32.0,2.0.0)",
13+
org.eclipse.oomph.setup;bundle-version="[1.33.0,2.0.0)",
1414
org.eclipse.oomph.setup.edit;bundle-version="[1.19.0,2.0.0)",
1515
org.eclipse.oomph.setup.ui;bundle-version="[1.34.0,2.0.0)",
1616
org.eclipse.equinox.p2.operations;bundle-version="[2.0.0,3.0.0)",

plugins/org.eclipse.oomph.setup.jdt/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Export-Package: org.eclipse.oomph.setup.jdt;version="1.24.0";x-internal:=true,
1212
org.eclipse.oomph.setup.jdt.util;version="1.24.0";x-internal:=true
1313
Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.24.0,4.0.0)",
1414
org.eclipse.emf.ecore;bundle-version="[2.10.0,3.0.0)";visibility:=reexport,
15-
org.eclipse.oomph.setup;bundle-version="[1.32.0,2.0.0)";visibility:=reexport,
15+
org.eclipse.oomph.setup;bundle-version="[1.33.0,2.0.0)";visibility:=reexport,
1616
org.eclipse.jdt.launching;bundle-version="[3.6.0,4.0.0)"
1717
Bundle-ActivationPolicy: lazy
1818
Automatic-Module-Name: org.eclipse.oomph.setup.jdt

plugins/org.eclipse.oomph.setup.p2/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Export-Package: org.eclipse.oomph.setup.internal.p2;version="1.23.0";x-internal:
1515
Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.24.0,4.0.0)",
1616
org.eclipse.emf.ecore;bundle-version="[2.10.0,3.0.0)";visibility:=reexport,
1717
org.eclipse.oomph.p2.core;bundle-version="[1.33.0,2.0.0)";visibility:=reexport,
18-
org.eclipse.oomph.setup;bundle-version="[1.32.0,2.0.0)";visibility:=reexport,
18+
org.eclipse.oomph.setup;bundle-version="[1.33.0,2.0.0)";visibility:=reexport,
1919
org.eclipse.equinox.p2.artifact.repository;bundle-version="[1.0.0,2.0.0)",
2020
org.eclipse.equinox.p2.console;bundle-version="[1.0.0,2.0.0)",
2121
org.eclipse.equinox.p2.core;bundle-version="[2.0.0,3.0.0)",

plugins/org.eclipse.oomph.setup/META-INF/MANIFEST.MF

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-SymbolicName: org.eclipse.oomph.setup;singleton:=true
4-
Bundle-Version: 1.32.0.qualifier
4+
Bundle-Version: 1.33.0.qualifier
55
Bundle-ClassPath: .
66
Bundle-Name: %pluginName
77
Bundle-Vendor: %providerName
@@ -16,10 +16,10 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.24.0,4.0.0)",
1616
org.eclipse.emf.ecore;bundle-version="[2.10.0,3.0.0)";visibility:=reexport
1717
Bundle-RequiredExecutionEnvironment: JavaSE-11
1818
Bundle-ActivationPolicy: lazy
19-
Export-Package: org.eclipse.oomph.internal.setup;version="1.32.0";x-internal:=true,
20-
org.eclipse.oomph.setup;version="1.32.0";x-internal:=true,
21-
org.eclipse.oomph.setup.impl;version="1.32.0";x-internal:=true,
22-
org.eclipse.oomph.setup.log;version="1.32.0";x-internal:=true,
23-
org.eclipse.oomph.setup.util;version="1.32.0";x-internal:=true
19+
Export-Package: org.eclipse.oomph.internal.setup;version="1.33.0";x-internal:=true,
20+
org.eclipse.oomph.setup;version="1.33.0";x-internal:=true,
21+
org.eclipse.oomph.setup.impl;version="1.33.0";x-internal:=true,
22+
org.eclipse.oomph.setup.log;version="1.33.0";x-internal:=true,
23+
org.eclipse.oomph.setup.util;version="1.33.0";x-internal:=true
2424
Bundle-Activator: org.eclipse.oomph.internal.setup.SetupPlugin$Implementation
2525
Automatic-Module-Name: org.eclipse.oomph.setup

plugins/org.eclipse.oomph.setup/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</parent>
2121
<groupId>org.eclipse.oomph</groupId>
2222
<artifactId>org.eclipse.oomph.setup</artifactId>
23-
<version>1.32.0-SNAPSHOT</version>
23+
<version>1.33.0-SNAPSHOT</version>
2424
<packaging>eclipse-plugin</packaging>
2525

2626
<build>

plugins/org.eclipse.oomph.setup/src/org/eclipse/oomph/setup/impl/EclipseIniTaskImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,10 +402,11 @@ private boolean createNewContent(SetupTaskContext context)
402402
String line = option + (value == null ? "" : value); //$NON-NLS-1$
403403
if (vmargsIndex != -1)
404404
{
405+
String optionPrefix = option + (value != null && value.startsWith("=") ? "=" : ""); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
405406
for (int i = vmargsIndex + 1; i < contents.size(); i++)
406407
{
407408
String oldLine = contents.get(i);
408-
if (oldLine.startsWith(option))
409+
if (oldLine.startsWith(optionPrefix))
409410
{
410411
contents.set(i, line);
411412
line = null;

0 commit comments

Comments
 (0)