TargetDefinition.java - Code Quality Improvements

  Optimizations:
  - Line 629-631: Eliminated unnecessary ArrayList creation and addAll
call - changed from 3 lines to 1 line returning new
ArrayList<>(Arrays.asList(collection))
  - Line 598: Modernized array creation using method reference
NameVersionDescriptor[]::new
  - Line 610: Modernized array creation using method reference
TargetBundle[]::new
  - Line 527: Modernized array creation using method reference
TargetBundle[]::new
  - Line 996: Modernized array creation using method reference
TargetFeature[]::new

  Impact:
  - Cleaner, more concise code
  - Slightly better performance by avoiding unnecessary intermediate
objects
  - Modern Java idioms make code easier to maintain
  - No API changes

Author: vogella

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetDefinition.java

@@ -524,7 +524,7 @@ private TargetBundle[] getBundles(boolean allBundles) {
 					}
 				}
 
-				TargetBundle[] allResolvedBundles = all.toArray(new TargetBundle[all.size()]);
+				TargetBundle[] allResolvedBundles = all.toArray(TargetBundle[]::new);
 				if (allBundles) {
 					return allResolvedBundles;
 				}
@@ -595,7 +595,7 @@ private TargetBundle[] filterBundles(TargetBundle[] bundles, NameVersionDescript
 		}
 
 		// Return matching bundles, if we are organizing by feature, do not create invalid target bundles for missing bundle includes
-		List<TargetBundle> result = getMatchingBundles(bundles, included.toArray(new NameVersionDescriptor[included.size()]), !containsFeatures);
+		List<TargetBundle> result = getMatchingBundles(bundles, included.toArray(NameVersionDescriptor[]::new), !containsFeatures);
 
 		// Add in missing features as resolved bundles with error statuses
 		if (containsFeatures && !missingFeatures.isEmpty()) {
@@ -607,7 +607,7 @@ private TargetBundle[] filterBundles(TargetBundle[] bundles, NameVersionDescript
 			}
 		}
 
-		return result.toArray(new TargetBundle[result.size()]);
+		return result.toArray(TargetBundle[]::new);
 	}
 
 	/**
@@ -627,9 +627,7 @@ private TargetBundle[] filterBundles(TargetBundle[] bundles, NameVersionDescript
 	 */
 	static List<TargetBundle> getMatchingBundles(TargetBundle[] collection, NameVersionDescriptor[] included, boolean handleMissingBundles) {
 		if (included == null) {
-			ArrayList<TargetBundle> result = new ArrayList<>();
-			result.addAll(Arrays.asList(collection));
-			return result;
+			return new ArrayList<>(Arrays.asList(collection));
 		}
 		// map bundles names to available versions
 		Map<String, List<TargetBundle>> bundleMap = new HashMap<>(collection.length);
@@ -995,7 +993,7 @@ public TargetFeature[] getAllFeatures() {
 			}
 		}
 
-		fFeatures = result.values().toArray(new TargetFeature[result.size()]);
+		fFeatures = result.values().toArray(TargetFeature[]::new);
 		return fFeatures;
 	}