Perform clean code of ui/org.eclipse.pde.bnd.ui

Author: eclipse-pde-bot

ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/model/repo/RepositoryTreeContentProvider.java

@@ -117,9 +117,8 @@ public boolean isShowRepos() {
 	@SuppressWarnings("unchecked")
 	public Object[] getElements(Object inputElement) {
 		Collection<Object> result;
-		if (inputElement instanceof Workspace) {
+		if (inputElement instanceof Workspace workspace) {
 			result = new ArrayList<>();
-			Workspace workspace = (Workspace) inputElement;
 			addRepositoryPlugins(result, workspace);
 		} else if (inputElement instanceof Collection) {
 			result = new ArrayList<>();

ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/model/repo/RepositoryTreeLabelProvider.java

@@ -53,9 +53,8 @@ public void update(ViewerCell cell) {
 		StyledString label = new StyledString();
 		Image image = null;
 		try {
-			if (element instanceof RepositoryPlugin) {
+			if (element instanceof RepositoryPlugin repo) {
 				if (index == 0) {
-					RepositoryPlugin repo = (RepositoryPlugin) element;
 					String status = repo.getStatus();
 					String name = null;
 					if (repo instanceof Actionable) {
@@ -72,10 +71,8 @@ public void update(ViewerCell cell) {
 					}
 					image = Resources.getImage(repo.getIcon());
 				}
-			} else if (element instanceof Project) {
+			} else if (element instanceof Project project) {
 				if (index == 0) {
-					@SuppressWarnings("resource")
-					Project project = (Project) element;
 					boolean isOk = project.isOk();
 
 					label.append(project.getName());
@@ -93,10 +90,8 @@ public void update(ViewerCell cell) {
 
 					image = projectImg;
 				}
-			} else if (element instanceof ProjectBundle) {
+			} else if (element instanceof ProjectBundle projectBundle) {
 				if (index == 0) {
-					ProjectBundle projectBundle = (ProjectBundle) element;
-
 					label.append(projectBundle.getBsn());
 					if (showRepoId) {
 						label.append(" ");
@@ -109,9 +104,8 @@ public void update(ViewerCell cell) {
 					}
 					image = bundleImg;
 				}
-			} else if (element instanceof RepositoryBundle) {
+			} else if (element instanceof RepositoryBundle bundle) {
 				if (index == 0) {
-					RepositoryBundle bundle = (RepositoryBundle) element;
 					label.append(bundle.getText());
 					if (showRepoId) {
 						label.append(" ");
@@ -120,9 +114,8 @@ public void update(ViewerCell cell) {
 					}
 					image = bundleImg;
 				}
-			} else if (element instanceof RepositoryBundleVersion) {
+			} else if (element instanceof RepositoryBundleVersion bundleVersion) {
 				if (index == 0) {
-					RepositoryBundleVersion bundleVersion = (RepositoryBundleVersion) element;
 					String versionText = bundleVersion.getText();
 
 					if (versionText.contains(" \u21E9")) {

ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/views/repository/RepositoriesView.java

@@ -396,11 +396,10 @@ public boolean performDrop(Object data) {
 				final Object element = selection.getFirstElement();
 				if (element instanceof IAdaptable) {
 					final URI uri = ((IAdaptable) element).getAdapter(URI.class);
-					if (uri == null && element instanceof RepositoryEntry) {
+					if (uri == null && element instanceof final RepositoryEntry entry) {
 						boolean download = MessageDialog.openQuestion(getSite().getShell(), "Repositories",
 							"This repository entry is unable to be opened because it has not been downloaded. Download and open it now?");
 						if (download) {
-							final RepositoryEntry entry = (RepositoryEntry) element;
 							Job downloadJob = new Job("Downloading repository entry " + entry.getBsn()) {
 								@Override
 								protected IStatus run(IProgressMonitor monitor) {
@@ -833,7 +832,7 @@ void createContextMenu() {
 				IStructuredSelection selection = (IStructuredSelection) viewer.getSelection();
 				if (!selection.isEmpty()) {
 					final Object firstElement = selection.getFirstElement();
-					if (firstElement instanceof Actionable) {
+					if (firstElement instanceof final Actionable act) {
 
 						final RepositoryPlugin rp = getRepositoryPlugin(firstElement);
 
@@ -842,8 +841,6 @@ void createContextMenu() {
 						// Should extend this to allow other menu entries
 						// from the view, but currently there are none
 						//
-						final Actionable act = (Actionable) firstElement;
-
 						// use HierarchicalMenu to build up a menue with SubMenu
 						// entries
 						HierarchicalMenu hmenu = new HierarchicalMenu();