Perform clean code of ds/org.eclipse.pde.ds.core

Author: eclipse-pde-bot

ds/org.eclipse.pde.ds.core/src/org/eclipse/pde/internal/ds/core/Activator.java

@@ -63,8 +63,9 @@ public static void log(IStatus status) {
 	}
 
 	public static void log(Throwable e) {
-		if (e instanceof InvocationTargetException)
+		if (e instanceof InvocationTargetException) {
 			e = ((InvocationTargetException) e).getTargetException();
+		}
 		IStatus status = null;
 		if (e instanceof CoreException) {
 			status = ((CoreException) e).getStatus();

ds/org.eclipse.pde.ds.core/src/org/eclipse/pde/internal/ds/core/builders/DSBuilder.java

@@ -99,8 +99,9 @@ public boolean visit(IResourceDelta delta) {
 	protected IProject[] build(int kind, Map<String, String> args, IProgressMonitor monitor)
 			throws CoreException {
 		IResourceDelta delta = null;
-		if (kind != FULL_BUILD)
+		if (kind != FULL_BUILD) {
 			delta = getDelta(getProject());
+		}
 
 		if (delta == null || kind == FULL_BUILD) {
 			// Full build
@@ -122,8 +123,9 @@ protected void clean(IProgressMonitor monitor) throws CoreException {
 	private boolean isDSFile(IFile candidate) {
 		try {
 			IContentDescription description = candidate.getContentDescription();
-			if (description == null)
+			if (description == null) {
 				return false;
+			}
 			IContentType type = description.getContentType();
 			return Activator.CONTENT_TYPE_ID.equals(type.getId());
 		} catch (CoreException e) {
@@ -132,8 +134,9 @@ private boolean isDSFile(IFile candidate) {
 	}
 
 	private void checkFile(IFile file, IProgressMonitor monitor) {
-		if (monitor.isCanceled())
+		if (monitor.isCanceled()) {
 			return;
+		}
 		String message = NLS.bind(Messages.DSBuilder_verifying, file
 				.getFullPath().toString());
 		monitor.subTask(message);

ds/org.eclipse.pde.ds.core/src/org/eclipse/pde/internal/ds/core/builders/DSErrorReporter.java

@@ -85,14 +85,16 @@ public void validate(IProgressMonitor monitor) {
 	private void validateBoolean(Element element, Attr attr) {
 		if (attr != null) {
 			String value = attr.getValue();
-			if (!value.equalsIgnoreCase("true") && !value.equalsIgnoreCase("false")) //$NON-NLS-1$ //$NON-NLS-2$
+			if (!value.equalsIgnoreCase("true") && !value.equalsIgnoreCase("false")) { //$NON-NLS-1$ //$NON-NLS-2$
 				reportIllegalAttributeValue(element, attr);
+			}
 		}
 	}
 
 	private void reportIllegalAttributeValue(Element element, Attr attr) {
-		if (attr == null || attr.getValue() == null || attr.getName() == null)
+		if (attr == null || attr.getValue() == null || attr.getName() == null) {
 			return;
+		}
 		String message = NLS.bind(Messages.DSErrorReporter_attrValue, attr
 				.getValue(), attr.getName());
 		report(message, getLine(element, attr.getName()), ERROR,
@@ -168,8 +170,9 @@ private void reportDuplicateReferenceElementName(Element element,
 			String name) {
 		Attr attr = element
 				.getAttributeNode(IDSConstants.ATTRIBUTE_REFERENCE_NAME);
-		if (attr == null || attr.getValue() == null || attr.getName() == null)
+		if (attr == null || attr.getValue() == null || attr.getName() == null) {
 			return;
+		}
 		String message = NLS.bind(
 				Messages.DSErrorReporter_duplicateReferenceName, name);
 		report(message,
@@ -198,9 +201,10 @@ private void validateReferencePolicy(Element element) {
 	private void reportIllegalPolicy(Element element, String policy) {
 		String name = element
 				.getAttribute(IDSConstants.ATTRIBUTE_REFERENCE_NAME);
-		if (name == null)
+		if (name == null) {
 			name = element
 					.getAttribute(IDSConstants.ATTRIBUTE_REFERENCE_INTERFACE);
+		}
 		String message = NLS.bind(Messages.DSErrorReporter_invalidPolicyValue,
 				name, policy);
 		Attr attr = element
@@ -242,8 +246,9 @@ private void reportIllegalCardinality(Element element, String cardinality) {
 				cardinality);
 		Attr attr = element
 				.getAttributeNode(IDSConstants.ATTRIBUTE_REFERENCE_CARDINALITY);
-		if (attr == null || attr.getValue() == null || attr.getName() == null)
+		if (attr == null || attr.getValue() == null || attr.getName() == null) {
 			return;
+		}
 		report(message, getLine(element, attr.getName()), ERROR,
 				PDEMarkerFactory.CAT_OTHER);
 	}
@@ -316,8 +321,9 @@ private void validatePropertySpecificTypeBody(String type, String body,
 		while (st.hasMoreTokens()) {
 			String token = st.nextToken();
 			token = token.trim();
-			if (token.length() > 0)
+			if (token.length() > 0) {
 				validatePropertySpecificTypeValue(type, token, element);
+			}
 		}
 	}
 
@@ -395,8 +401,9 @@ private void validatePropertyAttrValueAndBody(Element element,
 			String propertyType = property.getPropertyType();
 			if (propertyType == null
 					|| propertyType
-							.equals(IDSConstants.VALUE_PROPERTY_TYPE_STRING))
+							.equals(IDSConstants.VALUE_PROPERTY_TYPE_STRING)) {
 				return; // It's OK for a property of type "String" to have a
+			}
 			// value of "".
 			if (property.getPropertyValue().equals("")) { //$NON-NLS-1$
 				String propertyName = property.getPropertyName();
@@ -601,14 +608,16 @@ private void reportInvalidImmediate(Element element) {
 	private void validateEmpty(Element element, Attr attr) {
 		if (attr != null) {
 			String value = attr.getValue();
-			if (value.equalsIgnoreCase("")) //$NON-NLS-1$
+			if (value.equalsIgnoreCase("")) { //$NON-NLS-1$
 				reportIllegalEmptyAttributeValue(element, attr);
+			}
 		}
 	}
 
 	private void reportIllegalEmptyAttributeValue(Element element, Attr attr) {
-		if (attr == null || attr.getValue() == null || attr.getName() == null)
+		if (attr == null || attr.getValue() == null || attr.getName() == null) {
 			return;
+		}
 		String message = NLS.bind(Messages.DSErrorReporter_emptyAttrValue, attr
 				.getName());
 		report(message, getLine(element, attr.getName()), ERROR,

ds/org.eclipse.pde.ds.core/src/org/eclipse/pde/internal/ds/core/builders/DSJavaHelper.java

@@ -25,8 +25,9 @@ public class DSJavaHelper {
 
 	public static boolean isOnClasspath(String fullyQualifiedName,
 			IJavaProject project) {
-		if (fullyQualifiedName.indexOf('$') != -1)
+		if (fullyQualifiedName.indexOf('$') != -1) {
 			fullyQualifiedName = fullyQualifiedName.replace('$', '.');
+		}
 		try {
 			IType type = project.findType(fullyQualifiedName);
 			return type != null && type.exists();