Perform clean code of ui/org.eclipse.pde.runtime

Author: eclipse-pde-bot

ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/registry/RegistryBrowser.java

@@ -285,9 +285,7 @@ private void createTreeViewer(Composite parent) {
 			@Override
 			public int compare(Viewer viewer, Object e1, Object e2) {
 				// let Comparables compare themselves
-				if (e1 instanceof Comparable c1 && e2 instanceof Comparable && e1.getClass().equals(e2.getClass())) {
-					Comparable c2 = (Comparable) e2;
-
+				if (e1 instanceof Comparable c1 && e2 instanceof Comparable c2 && e1.getClass().equals(e2.getClass())) {
 					return c1.compareTo(c2);
 				}
 

ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/registry/RegistryBrowserContentProvider.java

@@ -77,13 +77,11 @@ public Object[] getChildren(Object element) {
 			return ((ConfigurationElement) element).getElements();
 		}
 
-		if (element instanceof Bundle) {
+		if (element instanceof Bundle bundle) {
 			if (fRegistryBrowser.getGroupBy() != RegistryBrowser.BUNDLES) { // expands only in Bundles mode
 				return null;
 			}
 
-			Bundle bundle = (Bundle) element;
-
 			List<Object> folders = new ArrayList<>(9);
 
 			folders.add(new Attribute(Attribute.F_LOCATION, bundle.getLocation()));

ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/registry/RegistryBrowserLabelProvider.java

@@ -340,10 +340,8 @@ protected StyledString getStyledText(Object element) {
 				return new StyledString(text);
 			}
 		}
-		if (element instanceof Extension) {
+		if (element instanceof Extension extension) {
 			if (((RegistryBrowserContentProvider) fRegistryBrowser.getAdapter(IContentProvider.class)).isInExtensionSet) {
-				Extension extension = ((Extension) element);
-
 				StyledString ss = new StyledString(extension.getExtensionPointUniqueIdentifier());
 				String name = extension.getLabel();
 				if (name != null && name.length() > 0) {

ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/spy/sections/ActiveMenuSection.java

@@ -144,7 +144,7 @@ private void createActionContributionItemText(Object object, StringBuilder buffe
 		} else {
 			// normal JFace Actions
 			Class<? extends IAction> clazz = action.getClass();
-			buffer.append(toolkit.createClassSection(text, PDERuntimeMessages.ActiveMenuSection_5, new Class[] {clazz}));
+			buffer.append(toolkit.createClassSection(text, PDERuntimeMessages.ActiveMenuSection_5, clazz));
 			Bundle bundle = FrameworkUtil.getBundle(clazz);
 			toolkit.generatePluginDetailsText(bundle, null, "meow", buffer, text); //$NON-NLS-1$
 		}

ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/spy/sections/ActivePartSection.java

@@ -95,7 +95,7 @@ public void build(ScrolledForm form, SpyFormToolkit toolkit, ExecutionEvent even
 		} else {
 			buffer.append(toolkit.createClassSection(text,
 					NLS.bind(PDERuntimeMessages.SpyDialog_activePart_desc, partType),
-					new Class<?>[] { part.getClass(), mPart.getObject().getClass() }));
+					part.getClass(), mPart.getObject().getClass()));
 		}
 
 		if (part instanceof PageBookView outline) {