Skip to content

Commit 1ac91ea

Browse files
committed
Fix PDEFormEditor.dispose() calling super.dispose() first
Common pattern for init/dispose, setup/teardown is that on init, super is called first and on dispose last. This is always done this way to allow super class initialize whatever needed first and subclass work on that, and the dispose should always perform cleanup in the opposite direction. Otherwise super code might cleanup things that are still needed for the subclass to properly cleanup. Probably related to #1963
1 parent 1c6786d commit 1ac91ea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEFormEditor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,9 +593,9 @@ public void dispose() {
593593
clipboard.dispose();
594594
clipboard = null;
595595
}
596-
super.dispose();
597596
fInputContextManager.dispose();
598597
fInputContextManager = null;
598+
super.dispose();
599599
}
600600

601601
@Override

0 commit comments

Comments
 (0)