Replace pre-generated disabled icon with on-the-fly generated ones

HeikoKlare · HannesWell · commit 1e8d28a50534 · 2025-04-30T00:45:27.000+02:00
SWT's algorithm to calculate disabled icons on the fly has been enhanced
to produce results that are equal to the existing, pre-generated
disabled icons being used. This makes the usage of pre-generated
disabled icons obsolete. This is particularly important for the
introduction of SVG icons, as the quality of on-the-fly generated
disabled icons based on the original SVGs is better for arbitrary zooms
than the scaled up or scaled downs versions of the PNG-based disabled
icons.

This change removes all explicit specifications of disabled icons unless
it's a usage of one of Platform's shared images.
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java
@@ -64,8 +64,6 @@ public class ApiUIPlugin extends AbstractUIPlugin {
 	 */
 	private static final String ICONS_PATH = "$nl$/icons/full/"; //$NON-NLS-1$
 
-	private static final String DLCL = ICONS_PATH + "dlcl16/"; //basic colors - size 16x16 disabled//$NON-NLS-1$
-
 	private static final String ELCL = ICONS_PATH + "elcl16/"; //basic colors - size 16x16 //$NON-NLS-1$
 
 	/**
@@ -300,17 +298,11 @@ protected void initializeImageRegistry(ImageRegistry reg) {
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_HELP_PAGE, ELCL + "help.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_COMPARE_APIS, ELCL + "compare_apis.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_CONFIG_SEV, ELCL + "configure_problem_severity.png"); //$NON-NLS-1$
-		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_COMPARE_APIS_DISABLED, DLCL + "compare_apis.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_EXPORT, ELCL + "export.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_NEXT_NAV, ELCL + "next_nav.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_PREV_NAV, ELCL + "prev_nav.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_EXPANDALL, ELCL + "expandall.png"); //$NON-NLS-1$
 		declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_TEXT_EDIT, ELCL + "text_edit.png"); //$NON-NLS-1$
-		// disabled images
-		declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_EXPORT, DLCL + "export.png"); //$NON-NLS-1$
-		declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_NEXT_NAV, DLCL + "next_nav.png"); //$NON-NLS-1$
-		declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_PREV_NAV, DLCL + "prev_nav.png"); //$NON-NLS-1$
-		declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_EXPANDALL, DLCL + "expandall.png"); //$NON-NLS-1$
 	}
 
 	void showAPIToolingView() {
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/IApiToolsConstants.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/IApiToolsConstants.java
@@ -55,10 +55,6 @@ public interface IApiToolsConstants {
 	public static final String IMG_ELCL_COMPARE_APIS = "IMG_ELCL_COMPARE_APIS"; //$NON-NLS-1$
 
 	public static final String IMG_ELCL_CONFIG_SEV = "IMG_ELCL_CONFIG_SEV"; //$NON-NLS-1$
-	/**
-	 * Key for a compare api disabled image
-	 */
-	public static final String IMG_ELCL_COMPARE_APIS_DISABLED = "IMG_ELCL_COMPARE_APIS_DISABLED"; //$NON-NLS-1$
 	/**
 	 * Key for filter resolution image
 	 */
@@ -152,10 +148,6 @@ public interface IApiToolsConstants {
 	 * Key for enabled export image
 	 */
 	public static final String IMG_ELCL_EXPORT = "IMG_ELCL_EXPORT"; //$NON-NLS-1$
-	/**
-	 * Key for disabled export image
-	 */
-	public static final String IMG_DLCL_EXPORT = "IMG_DLCL_EXPORT"; //$NON-NLS-1$
 	/**
 	 * Key for enabled next navigation image
 	 */
@@ -164,20 +156,8 @@ public interface IApiToolsConstants {
 	 * Key for enabled previous navigation image
 	 */
 	public static final String IMG_ELCL_PREV_NAV = "IMG_ELCL_PREV_NAV"; //$NON-NLS-1$
-	/**
-	 * Key for disabled next navigation image
-	 */
-	public static final String IMG_DLCL_NEXT_NAV = "IMG_DLCL_NEXT_NAV"; //$NON-NLS-1$
-	/**
-	 * Key for disabled previous navigation image
-	 */
-	public static final String IMG_DLCL_PREV_NAV = "IMG_DLCL_PREV_NAV"; //$NON-NLS-1$
 	/**
 	 * Key for enabled expand all image
 	 */
 	public static final String IMG_ELCL_EXPANDALL = "IMG_ELCL_EXPANDALL"; //$NON-NLS-1$
-	/**
-	 * Key for disabled expand all image
-	 */
-	public static final String IMG_DLCL_EXPANDALL = "IMG_DLCL_EXPANDALL"; //$NON-NLS-1$
 }
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java
@@ -31,8 +31,6 @@ public ExpandAllAction(TreeViewer viewer) {
 		setToolTipText(ActionMessages.ExpandAllAction_tooltip);
 		ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_EXPANDALL);
 		setImageDescriptor(enabledImageDescriptor);
-		ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_EXPANDALL);
-		setDisabledImageDescriptor(disabledImageDescriptor);
 		fViewer = viewer;
 	}
 
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportSessionAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportSessionAction.java
@@ -62,8 +62,6 @@ public ExportSessionAction(APIToolingView view) {
 		setToolTipText(ActionMessages.ExportSessionAction_tooltip);
 		ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_EXPORT);
 		setImageDescriptor(enabledImageDescriptor);
-		ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_EXPORT);
-		setDisabledImageDescriptor(disabledImageDescriptor);
 		setEnabled(false);
 		this.view = view;
 	}
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java
@@ -41,8 +41,6 @@ public NavigateAction(APIToolingView view, boolean next) {
 			setToolTipText(ActionMessages.NextAction_tooltip);
 			ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_NEXT_NAV);
 			setImageDescriptor(enabledImageDescriptor);
-			ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_NEXT_NAV);
-			setDisabledImageDescriptor(disabledImageDescriptor);
 			setActionDefinitionId(ActionFactory.NEXT.getCommandId());
 			if (bars != null) {
 				bars.setGlobalActionHandler(ActionFactory.NEXT.getId(), this);
@@ -52,8 +50,6 @@ public NavigateAction(APIToolingView view, boolean next) {
 			setToolTipText(ActionMessages.PreviousAction_tooltip);
 			ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_PREV_NAV);
 			setImageDescriptor(enabledImageDescriptor);
-			ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_PREV_NAV);
-			setDisabledImageDescriptor(disabledImageDescriptor);
 			setActionDefinitionId(ActionFactory.PREVIOUS.getCommandId());
 			if (bars != null) {
 				bars.setGlobalActionHandler(ActionFactory.PREVIOUS.getId(), this);
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/SelectSessionAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/SelectSessionAction.java
@@ -38,7 +38,6 @@ public SelectSessionAction() {
 		setText(ActionMessages.SelectSessionAction_label);
 		setToolTipText(ActionMessages.SelectSessionAction_tooltip);
 		setImageDescriptor(ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_COMPARE_APIS));
-		setDisabledImageDescriptor(ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_COMPARE_APIS_DISABLED));
 		setMenuCreator(this);
 		setEnabled(false);
 	}
diff --git a/ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/views/repository/RepositoriesView.java b/ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/views/repository/RepositoriesView.java
@@ -513,7 +513,6 @@ private void setPrefrences(BndPreferences preferences) {
 			offlineAction.setChecked(false);
 			offlineAction.setToolTipText("Go Offline");
 			offlineAction.setImageDescriptor(Resources.getImageDescriptor("connect.png"));
-			offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("connect_d.png"));
 			offlineAction.setEnabled(false);
 			return;
 		}
@@ -526,12 +525,10 @@ protected void updateOfflineAction(boolean offline) {
 			offlineAction.setChecked(true);
 			offlineAction.setToolTipText("Go Online");
 			offlineAction.setImageDescriptor(Resources.getImageDescriptor("disconnect.png"));
-			offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("disconnect_d.png"));
 		} else {
 			offlineAction.setChecked(false);
 			offlineAction.setToolTipText("Go Offline");
 			offlineAction.setImageDescriptor(Resources.getImageDescriptor("connect.png"));
-			offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("connect_d.png"));
 		}
 		offlineAction.setEnabled(true);
 	}
@@ -622,7 +619,6 @@ public void run() {
 		collapseAllAction.setText("Collapse All");
 		collapseAllAction.setToolTipText("Collapse All");
 		collapseAllAction.setImageDescriptor(Resources.getImageDescriptor("collapseall.png"));
-		collapseAllAction.setDisabledImageDescriptor(Resources.getImageDescriptor("collapseall_d.png"));
 
 		refreshAction = new Action() {
 			@Override
@@ -658,7 +654,6 @@ public IStatus runInWorkspace(IProgressMonitor monitor) throws CoreException {
 		refreshAction.setText("Refresh");
 		refreshAction.setToolTipText("Refresh Repositories Tree");
 		refreshAction.setImageDescriptor(Resources.getImageDescriptor("arrow_refresh.png"));
-		refreshAction.setDisabledImageDescriptor(Resources.getImageDescriptor("arrow_refresh_d.png"));
 
 		addBundlesAction = new Action() {
 			@Override
@@ -681,7 +676,6 @@ public void run() {
 		addBundlesAction.setText("Add");
 		addBundlesAction.setToolTipText("Add Bundles to Repository");
 		addBundlesAction.setImageDescriptor(Resources.getImageDescriptor("add_obj.png"));
-		addBundlesAction.setDisabledImageDescriptor(Resources.getImageDescriptor("add_obj_d.png"));
 
 		advancedSearchAction = new Action("Advanced Search", IAction.AS_CHECK_BOX) {
 			@Override
@@ -728,7 +722,6 @@ public void run() {
 		advancedSearchAction.setText("Advanced Search");
 		advancedSearchAction.setToolTipText("Toggle Advanced Search");
 		advancedSearchAction.setImageDescriptor(Resources.getImageDescriptor("search.png"));
-		advancedSearchAction.setDisabledImageDescriptor(Resources.getImageDescriptor("search_d.png"));
 
 		downloadAction = new Action() {
 			@Override
@@ -781,7 +774,6 @@ private <T> List<T> selectionByType(IStructuredSelection selection, Class<T> typ
 		downloadAction.setEnabled(false);
 		downloadAction.setText("Download Repository Content");
 		downloadAction.setImageDescriptor(Resources.getImageDescriptor("download.png"));
-		downloadAction.setDisabledImageDescriptor(Resources.getImageDescriptor("download_d.png"));
 
 		offlineAction = new Action("Online/Offline Mode", IAction.AS_CHECK_BOX) {
 			@Override
@@ -795,7 +787,6 @@ public void run() {
 		offlineAction.setEnabled(false);
 		offlineAction.setToolTipText("Go Offline");
 		offlineAction.setImageDescriptor(Resources.getImageDescriptor("connect.png"));
-		offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("connect_d.png"));
 
 		viewer.addSelectionChangedListener(event -> {
 			IStructuredSelection selection = (IStructuredSelection) event.getSelection();
diff --git a/ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/PDERuntimePluginImages.java b/ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/PDERuntimePluginImages.java
@@ -28,7 +28,6 @@ public class PDERuntimePluginImages {
 	public final static String ICONS_PATH = "icons/"; //$NON-NLS-1$
 
 	private static final String PATH_OBJ = ICONS_PATH + "obj16/"; //$NON-NLS-1$
-	private static final String PATH_DCL = ICONS_PATH + "dlcl16/"; //$NON-NLS-1$
 	private static final String PATH_LCL = ICONS_PATH + "elcl16/"; //$NON-NLS-1$
 	private static final String PATH_OVR = ICONS_PATH + "ovr16/"; //$NON-NLS-1$
 
@@ -57,7 +56,6 @@ public class PDERuntimePluginImages {
 	public static final ImageDescriptor COPY_QNAME = create(PATH_LCL, IMG_COPY_QNAME);
 	public static final ImageDescriptor UP_NAV = create(PATH_LCL, IMG_UP_NAV);
 
-	public static final ImageDescriptor DESC_REFRESH_DISABLED = create(PATH_DCL, "refresh.png"); //$NON-NLS-1$
 	public static final ImageDescriptor DESC_REFRESH = create(PATH_LCL, "refresh.svg"); //$NON-NLS-1$
 	public static final ImageDescriptor DESC_COLLAPSE_ALL = create(PATH_LCL, "collapseall.svg"); //$NON-NLS-1$
 	public static final ImageDescriptor DESC_EXT_POINT_OBJ = create(PATH_OBJ, "ext_point_obj.svg"); //$NON-NLS-1$
diff --git a/ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/registry/RegistryBrowser.java b/ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/registry/RegistryBrowser.java
@@ -412,7 +412,6 @@ public void run() {
 		fRefreshAction.setText(PDERuntimeMessages.RegistryView_refresh_label);
 		fRefreshAction.setToolTipText(PDERuntimeMessages.RegistryView_refresh_tooltip);
 		fRefreshAction.setImageDescriptor(PDERuntimePluginImages.DESC_REFRESH);
-		fRefreshAction.setDisabledImageDescriptor(PDERuntimePluginImages.DESC_REFRESH_DISABLED);
 
 		fShowPluginsAction = new Action(PDERuntimeMessages.RegistryView_showRunning_label) {
 			@Override
diff --git a/ui/org.eclipse.pde.ui.tests/tests/performance/plugin/org.eclipse.jdt.ui/plugin.xml b/ui/org.eclipse.pde.ui.tests/tests/performance/plugin/org.eclipse.jdt.ui/plugin.xml
@@ -1125,7 +1125,6 @@
                toolbarPath="org.eclipse.ui.edit.text.actionSet.presentation/Presentation"
                id="org.eclipse.jdt.ui.edit.text.java.toggleMarkOccurrences"
                definitionId="org.eclipse.jdt.ui.edit.text.java.toggleMarkOccurrences"
-               disabledIcon="$nl$/icons/full/dtool16/mark_occurrences.gif"
                icon="$nl$/icons/full/etool16/mark_occurrences.gif"
                helpContextId="toggle_mark_occurrences_action_context"
                label="%toggleMarkOccurrences.label"
@@ -1515,7 +1514,6 @@
                id="org.eclipse.jdt.ui.actions.NewTypeDropDown"
                toolbarPath="Normal/JavaWizards"
                class="org.eclipse.jdt.internal.ui.wizards.NewTypeDropDownAction"
-               disabledIcon="$nl$/icons/full/dtool16/newclass_wiz.gif"
                icon="$nl$/icons/full/etool16/newclass_wiz.gif"
                label="%OpenClassWizardAction.label"
                style="pulldown"
diff --git a/ui/org.eclipse.pde.ui/plugin.xml b/ui/org.eclipse.pde.ui/plugin.xml
@@ -1823,7 +1823,6 @@
                 locationURI="popup:org.eclipse.ui.popup.any?after=additions">
              <command
                    commandId="org.eclipse.pde.ui.importFromRepository"
-                   disabledIcon="icons/dtool16/imp_extplug.png"
                    icon="icons/etool16/imp_extplug.png"
                    label="%importFromRepository.action.menu.name"
                    style="push"
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEPluginImages.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEPluginImages.java
@@ -44,7 +44,6 @@ public class PDEPluginImages {
 	private static final String PATH_VIEW = ICONS_PATH + "view16/"; //$NON-NLS-1$
 	private static final String PATH_DVIEW = ICONS_PATH + "dview16/"; //$NON-NLS-1$
 	private static final String PATH_LCL = ICONS_PATH + "elcl16/"; //$NON-NLS-1$
-	private static final String PATH_LCL_DISABLED = ICONS_PATH + "dlcl16/"; //$NON-NLS-1$
 	private static final String PATH_TOOL = ICONS_PATH + "etool16/"; //$NON-NLS-1$
 	private static final String PATH_OVR = ICONS_PATH + "ovr16/"; //$NON-NLS-1$
 	private static final String PATH_WIZBAN = ICONS_PATH + "wizban/"; //$NON-NLS-1$
@@ -252,30 +251,6 @@ public class PDEPluginImages {
 	public static final ImageDescriptor DESC_FILTER = create(PATH_LCL, "filter_ps.png"); //$NON-NLS-1$
 	public static final ImageDescriptor DESC_FILTER_RELATED = create(PATH_LCL, "filter_related.png"); //$NON-NLS-1$
 
-	public static final ImageDescriptor DESC_ADD_ATT_DISABLED = create(PATH_LCL_DISABLED, "add_att.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_ALPHAB_SORT_CO_DISABLED = create(PATH_LCL_DISABLED, "alphab_sort_co.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_CLONE_ATT_DISABLED = create(PATH_LCL_DISABLED, "clone_att.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_CLONE_EL_DISABLED = create(PATH_LCL_DISABLED, "clone_el.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_GENERATE_CLASS_DISABLED = create(PATH_LCL_DISABLED, "generate_class.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_GOTOOBJ_DISABLED = create(PATH_LCL_DISABLED, "goto_obj.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_PROPERTIES_DISABLED = create(PATH_LCL_DISABLED, "properties.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_REFRESH_DISABLED = create(PATH_LCL_DISABLED, "refresh.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_REMOVE_ATT_DISABLED = create(PATH_LCL_DISABLED, "remove_att.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_HORIZONTAL_DISABLED = create(PATH_LCL_DISABLED, "th_horizontal.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_VERTICAL_DISABLED = create(PATH_LCL_DISABLED, "th_vertical.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_COLLAPSE_ALL_DISABLED = create(PATH_LCL_DISABLED, "collapseall.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_TOGGLE_EXPAND_STATE_DISABLED = create(PATH_LCL_DISABLED, "toggle_expand_state.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_LINK_WITH_EDITOR_DISABLED = create(PATH_LCL_DISABLED, "synced.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_CALLEES_DISABLED = create(PATH_LCL_DISABLED, "ch_callees.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_CALLERS_DISABLED = create(PATH_LCL_DISABLED, "ch_callers.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_DEP_LOOP_DISABLED = create(PATH_LCL_DISABLED, "dep_loop.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_FLAT_LAYOUT_DISABLED = create(PATH_LCL_DISABLED, "flatLayout.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_HIERARCHICAL_LAYOUT_DISABLED = create(PATH_LCL_DISABLED, "hierarchicalLayout.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_HISTORY_LIST_DISABLED = create(PATH_LCL_DISABLED, "history_list.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_DCLEAR = create(PATH_LCL_DISABLED, "clear.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_FILTER_DISABLED = create(PATH_LCL_DISABLED, "filter_ps.png"); //$NON-NLS-1$
-	public static final ImageDescriptor DESC_FILTER_RELATED_DISABLED = create(PATH_LCL_DISABLED, "filter_related.png"); //$NON-NLS-1$
-
 	public static final ImageDescriptor DESC_RUN_EXC = create(PATH_OBJ, "run_exc.png"); //$NON-NLS-1$
 	public static final ImageDescriptor DESC_DEBUG_EXC = create(PATH_OBJ, "debug_exc.png"); //$NON-NLS-1$
 	public static final ImageDescriptor DESC_PROFILE_EXC = create(PATH_OBJ, "profile_exc.png"); //$NON-NLS-1$
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/OrientableBlock.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/OrientableBlock.java
@@ -41,7 +41,6 @@ public void run() {
 		haction.setChecked(true);
 		haction.setToolTipText(PDEUIMessages.DetailsBlock_horizontal);
 		haction.setImageDescriptor(PDEPluginImages.DESC_HORIZONTAL);
-		haction.setDisabledImageDescriptor(PDEPluginImages.DESC_HORIZONTAL_DISABLED);
 
 		Action vaction = new Action("ver", IAction.AS_RADIO_BUTTON) { //$NON-NLS-1$
 			@Override
@@ -53,7 +52,6 @@ public void run() {
 		vaction.setChecked(false);
 		vaction.setToolTipText(PDEUIMessages.DetailsBlock_vertical);
 		vaction.setImageDescriptor(PDEPluginImages.DESC_VERTICAL);
-		vaction.setDisabledImageDescriptor(PDEPluginImages.DESC_VERTICAL_DISABLED);
 		form.getToolBarManager().add(haction);
 		form.getToolBarManager().add(vaction);
 	}
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEMultiPageContentOutline.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEMultiPageContentOutline.java
@@ -201,7 +201,6 @@ public SortingAction() {
 			PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IHelpContextIds.OUTLINE_SORT_ACTION);
 			setText(PDEUIMessages.PDEMultiPageContentOutline_SortingAction_label);
 			setImageDescriptor(PDEPluginImages.DESC_ALPHAB_SORT_CO);
-			setDisabledImageDescriptor(PDEPluginImages.DESC_ALPHAB_SORT_CO_DISABLED);
 			setToolTipText(PDEUIMessages.PDEMultiPageContentOutline_SortingAction_tooltip);
 			setDescription(PDEUIMessages.PDEMultiPageContentOutline_SortingAction_description);
 			setChecked(sortingOn);
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/ToggleLinkWithEditorAction.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/ToggleLinkWithEditorAction.java
@@ -37,7 +37,6 @@ public ToggleLinkWithEditorAction(PDEFormEditor editor) {
 		setToolTipText(PDEUIMessages.ToggleLinkWithEditorAction_toolTip);
 		setDescription(PDEUIMessages.ToggleLinkWithEditorAction_description);
 		setImageDescriptor(PDEPluginImages.DESC_LINK_WITH_EDITOR);
-		setDisabledImageDescriptor(PDEPluginImages.DESC_LINK_WITH_EDITOR_DISABLED);
 	}
 
 	@Override
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/actions/FilterRelatedExtensionsAction.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/actions/FilterRelatedExtensionsAction.java
@@ -33,7 +33,6 @@ public class FilterRelatedExtensionsAction extends Action {
 
 	public FilterRelatedExtensionsAction(TreeViewer treeViewer, FormFilteredTree filteredTree, ExtensionsSection section) {
 		setImageDescriptor(PDEPluginImages.DESC_FILTER_RELATED);
-		setDisabledImageDescriptor(PDEPluginImages.DESC_FILTER_RELATED_DISABLED);
 		// Extensions section attaches this action to the global find keybinding
 //		String filterBinding = ((IBindingService) PlatformUI.getWorkbench().getAdapter(IBindingService.class)).getBestActiveBindingFormattedFor(ActionFactory.FIND.getCommandId());
 		setText(PDEUIMessages.Actions_filter_relatedPluginElements /*+ ((filterBinding != null) ? "\t" + filterBinding : "")*/);
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/actions/ToggleExpandStateAction.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/actions/ToggleExpandStateAction.java
@@ -41,7 +41,6 @@ public class ToggleExpandStateAction extends Action {
 
 	public ToggleExpandStateAction(FormFilteredTree filteredTree, TreeViewer treeViewer) {
 		setImageDescriptor(PDEPluginImages.DESC_TOGGLE_EXPAND_STATE);
-		setDisabledImageDescriptor(PDEPluginImages.DESC_TOGGLE_EXPAND_STATE_DISABLED);
 		setText(PDEUIMessages.ExtensionsPage_toggleExpandState);
 		fExtensionTree = treeViewer;
 		fFilteredTree = filteredTree;
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java
@@ -462,11 +462,6 @@ public ImageDescriptor getImageDescriptor() {
 					return PDEPluginImages.DESC_DELETE;
 				}
 
-				@Override
-				public ImageDescriptor getDisabledImageDescriptor() {
-					return PDEPluginImages.DESC_REMOVE_ATT_DISABLED;
-				}
-
 				@Override
 				public void run() {
 					handleDelete();
@@ -556,11 +551,6 @@ public void run() {
 				public ImageDescriptor getImageDescriptor() {
 					return PDEPluginImages.DESC_DELETE;
 				}
-
-				@Override
-				public ImageDescriptor getDisabledImageDescriptor() {
-					return PDEPluginImages.DESC_REMOVE_ATT_DISABLED;
-				}
 			};
 			deleteAction.setEnabled(page.getModel().isEditable());
 			manager.add(deleteAction);
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/dependencies/DependenciesView.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/dependencies/DependenciesView.java
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/dependencies/HistoryDropDownAction.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/dependencies/HistoryDropDownAction.java
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/dependencies/HistoryListAction.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/dependencies/HistoryListAction.java

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@ public ExpandAllAction(TreeViewer viewer) {`
`31`	`31`	`setToolTipText(ActionMessages.ExpandAllAction_tooltip);`
`32`	`32`	`ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_EXPANDALL);`
`33`	`33`	`setImageDescriptor(enabledImageDescriptor);`
`34`		`- ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_EXPANDALL);`
`35`		`- setDisabledImageDescriptor(disabledImageDescriptor);`
`36`	`34`	`fViewer = viewer;`
`37`	`35`	`}`
`38`	`36`
Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,6 @@ public ExportSessionAction(APIToolingView view) {`
`62`	`62`	`setToolTipText(ActionMessages.ExportSessionAction_tooltip);`
`63`	`63`	`ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_EXPORT);`
`64`	`64`	`setImageDescriptor(enabledImageDescriptor);`
`65`		`- ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_EXPORT);`
`66`		`- setDisabledImageDescriptor(disabledImageDescriptor);`
`67`	`65`	`setEnabled(false);`
`68`	`66`	`this.view = view;`
`69`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,6 @@ public SelectSessionAction() {`
`38`	`38`	`setText(ActionMessages.SelectSessionAction_label);`
`39`	`39`	`setToolTipText(ActionMessages.SelectSessionAction_tooltip);`
`40`	`40`	`setImageDescriptor(ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_COMPARE_APIS));`
`41`		`- setDisabledImageDescriptor(ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_COMPARE_APIS_DISABLED));`
`42`	`41`	`setMenuCreator(this);`
`43`	`42`	`setEnabled(false);`
`44`	`43`	`}`