Skip to content

Commit 24a924e

Browse files
eclipse-pde-botlaeubi
authored andcommitted
Perform clean code of ui/org.eclipse.pde.launching
1 parent 93a1fc5 commit 24a924e

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/LaunchListener.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,7 @@ public void shutdown() {
120120
public void handleDebugEvents(DebugEvent[] events) {
121121
for (DebugEvent event : events) {
122122
Object source = event.getSource();
123-
if (source instanceof IProcess && event.getKind() == DebugEvent.TERMINATE) {
124-
IProcess process = (IProcess) source;
123+
if (source instanceof IProcess process && event.getKind() == DebugEvent.TERMINATE) {
125124
ILaunch launch = process.getLaunch();
126125
if (launch != null) {
127126
try {

ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/sourcelookup/PDESourceLookupDirector.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,7 @@ private ISourceContainer getArchiveSourceContainer(String location) throws JavaM
214214
IFile[] containers = root.findFilesForLocationURI(URIUtil.toURI(location));
215215
for (IFile container : containers) {
216216
IJavaElement element = JavaCore.create(container);
217-
if (element instanceof IPackageFragmentRoot) {
218-
IPackageFragmentRoot archive = (IPackageFragmentRoot) element;
217+
if (element instanceof IPackageFragmentRoot archive) {
219218
IPath path = archive.getSourceAttachmentPath();
220219
if (path == null || path.segmentCount() == 0) {
221220
continue;

ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/sourcelookup/PDESourceLookupQuery.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ public void run() throws Exception {
9898
private void findSourceElement() throws Exception {
9999
IJavaReferenceType declaringType = null;
100100
String sourcePath = null;
101-
if (fElement instanceof IJavaStackFrame) {
102-
IJavaStackFrame stackFrame = (IJavaStackFrame) fElement;
101+
if (fElement instanceof IJavaStackFrame stackFrame) {
103102
declaringType = stackFrame.getReferenceType();
104103
// under JSR 45 source path from the stack frame is more precise than anything derived from the type:
105104
sourcePath = stackFrame.getSourcePath();
@@ -198,8 +197,7 @@ protected Object findSourceElement(IJavaObject object, String typeName) throws C
198197
}
199198
// then check its fragments
200199
IJavaObject frgArray = getObject(manager, "fragments", false); //$NON-NLS-1$
201-
if (frgArray instanceof IJavaArray) {
202-
IJavaArray fragments = (IJavaArray) frgArray;
200+
if (frgArray instanceof IJavaArray fragments) {
203201
for (int i = 0; i < fragments.getLength(); i++) {
204202
IJavaObject fragment = (IJavaObject) fragments.getValue(i);
205203
if (!fragment.isNull()) {
@@ -226,8 +224,7 @@ protected Object findSourceElement(IJavaObject object, String typeName) throws C
226224
*/
227225
private Object searchClasspathEntries(IJavaObject entriesOwner, String typeName) throws CoreException {
228226
IJavaObject cpeArray = getObject(entriesOwner, "entries", false); //$NON-NLS-1$
229-
if (cpeArray instanceof IJavaArray) {
230-
IJavaArray entries = (IJavaArray) cpeArray;
227+
if (cpeArray instanceof IJavaArray entries) {
231228
for (int i = 0; i < entries.getLength(); i++) {
232229
IJavaObject entry = (IJavaObject) entries.getValue(i);
233230
if (!entry.isNull()) {
@@ -356,8 +353,7 @@ private static String generateSourceName(String qualifiedTypeName) {
356353

357354
private boolean isDebugTargetRunning() {
358355
boolean isDebugTargetRunning = false;
359-
if (fElement instanceof IDebugElement) {
360-
IDebugElement debugElement = (IDebugElement) fElement;
356+
if (fElement instanceof IDebugElement debugElement) {
361357
IDebugTarget debugTarget = debugElement.getDebugTarget();
362358
isDebugTargetRunning = debugTarget != null && !debugTarget.isDisconnected() && !debugTarget.isTerminated();
363359
}

0 commit comments

Comments
 (0)