Skip to content

Commit 3623b62

Browse files
eclipse-pde-botakurtakov
authored andcommitted
Perform clean code of apitools/org.eclipse.pde.api.tools
1 parent 6e830ad commit 3623b62

File tree

9 files changed

+9
-23
lines changed

9 files changed

+9
-23
lines changed

apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/APIFileGenerator.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,7 @@ public void generateAPIFile() {
118118
StringWriter out = new StringWriter();
119119
PrintWriter writer = new PrintWriter(out);
120120
writer.println(NLS.bind(CoreMessages.api_generation_printArguments,
121-
new String[] {
122-
this.projectName, this.projectLocation,
123-
this.binaryLocations, this.targetFolder }));
121+
this.projectName, this.projectLocation, this.binaryLocations, this.targetFolder));
124122
throw new IllegalArgumentException(String.valueOf(out.getBuffer()));
125123
}
126124
if (this.debug) {

apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/ReferenceExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1311,7 +1311,7 @@ public MethodVisitor visitMethod(int access, String name, String desc, String si
13111311
IApiMethod method = owner.getMethod(name, desc);
13121312
if (method == null) {
13131313
ApiPlugin.log(Status.warning(NLS.bind(BuilderMessages.ReferenceExtractor_failed_to_lookup_method,
1314-
new String[] { name, desc, Signatures.getQualifiedTypeSignature(owner) })));
1314+
name, desc, Signatures.getQualifiedTypeSignature(owner))));
13151315
// if we can't find the method there is no point trying to
13161316
// process it
13171317
return null;

apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/BundleComponent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1156,7 +1156,7 @@ public ResolverError[] getErrors() throws CoreException {
11561156
protected void baselineDisposed(IApiBaseline baseline) throws CoreException {
11571157
throw new CoreException(new Status(IStatus.ERROR, ApiPlugin.PLUGIN_ID, ApiPlugin.REPORT_BASELINE_IS_DISPOSED,
11581158
NLS.bind(Messages.BundleApiComponent_baseline_disposed,
1159-
new Object[] { getName(), baseline.getName(), Thread.currentThread().getName() }),
1159+
getName(), baseline.getName(), Thread.currentThread().getName()),
11601160
disposeSource));
11611161
}
11621162
}

apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/MigrationReportConvertor.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@ protected String getTypeDetails() {
7676
protected String getTypeCountSummary(String typename, CountGroup counts, int membercount) {
7777
StringBuilder buffer = new StringBuilder();
7878
buffer.append(OPEN_H4).append(SearchMessages.UseReportConverter_summary).append(CLOSE_H4);
79-
buffer.append(OPEN_P).append(NLS.bind(SearchMessages.MigrationReportConvertor_member_has_unresolved_refs, new String[] {
80-
typename, Integer.toString(counts.getTotalRefCount()),
81-
Integer.toString(membercount) })).append(CLOSE_P);
79+
buffer.append(OPEN_P).append(NLS.bind(SearchMessages.MigrationReportConvertor_member_has_unresolved_refs, typename, Integer.toString(counts.getTotalRefCount()), Integer.toString(membercount))).append(CLOSE_P);
8280
return buffer.toString();
8381
}
8482

apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/UseReportConverter.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1687,9 +1687,7 @@ protected String getAdditionalIndexInfo(boolean hasreports) {
16871687
protected String getTypeCountSummary(String typename, CountGroup counts, int membercount) {
16881688
StringBuilder buffer = new StringBuilder();
16891689
buffer.append(OPEN_H4).append(SearchMessages.UseReportConverter_summary).append(CLOSE_H4);
1690-
buffer.append(OPEN_P).append(NLS.bind(SearchMessages.UseReportConverter___has_total_refs, new String[] {
1691-
typename, Integer.toString(counts.getTotalRefCount()),
1692-
Integer.toString(membercount) })).append(CLOSE_P);
1690+
buffer.append(OPEN_P).append(NLS.bind(SearchMessages.UseReportConverter___has_total_refs, typename, Integer.toString(counts.getTotalRefCount()), Integer.toString(membercount))).append(CLOSE_P);
16931691
return buffer.toString();
16941692
}
16951693
}

apitools/org.eclipse.pde.api.tools/src_ant/org/eclipse/pde/api/tools/internal/tasks/APIDeprecationTask.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@ public void execute() throws BuildException {
4848
if (this.referenceBaselineLocation == null || this.currentBaselineLocation == null || this.reportLocation == null) {
4949
StringWriter out = new StringWriter();
5050
PrintWriter writer = new PrintWriter(out);
51-
writer.println(NLS.bind(Messages.printArguments, new String[] {
52-
this.referenceBaselineLocation,
53-
this.currentBaselineLocation, this.reportLocation, }));
51+
writer.println(NLS.bind(Messages.printArguments, this.referenceBaselineLocation, this.currentBaselineLocation, this.reportLocation));
5452
throw new BuildException(String.valueOf(out.getBuffer()));
5553
}
5654
if (this.debug) {

apitools/org.eclipse.pde.api.tools/src_ant/org/eclipse/pde/api/tools/internal/tasks/APIFreezeTask.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ public void execute() throws BuildException {
7272
if (this.referenceBaselineLocation == null || this.currentBaselineLocation == null || this.reportLocation == null) {
7373
StringWriter out = new StringWriter();
7474
PrintWriter writer = new PrintWriter(out);
75-
writer.println(NLS.bind(Messages.printArguments, new String[] {
76-
this.referenceBaselineLocation,
77-
this.currentBaselineLocation, this.reportLocation, }));
75+
writer.println(NLS.bind(Messages.printArguments, this.referenceBaselineLocation, this.currentBaselineLocation, this.reportLocation));
7876
throw new BuildException(String.valueOf(out.getBuffer()));
7977
}
8078
if (this.debug) {

apitools/org.eclipse.pde.api.tools/src_ant/org/eclipse/pde/api/tools/internal/tasks/APIToolsAnalysisTask.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,9 +292,7 @@ public void execute() throws BuildException {
292292
if (this.referenceBaselineLocation == null || this.currentBaselineLocation == null || this.reportLocation == null) {
293293
StringWriter out = new StringWriter();
294294
PrintWriter writer = new PrintWriter(out);
295-
writer.println(NLS.bind(Messages.printArguments, new String[] {
296-
this.referenceBaselineLocation,
297-
this.currentBaselineLocation, this.reportLocation, }));
295+
writer.println(NLS.bind(Messages.printArguments, this.referenceBaselineLocation, this.currentBaselineLocation, this.reportLocation));
298296
throw new BuildException(String.valueOf(out.getBuffer()));
299297
}
300298
if (this.debug) {

apitools/org.eclipse.pde.api.tools/src_ant/org/eclipse/pde/api/tools/internal/tasks/CompareTask.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ public void execute() throws BuildException {
5555
if (this.referenceBaselineLocation == null || this.currentBaselineLocation == null || this.reportLocation == null) {
5656
StringWriter out = new StringWriter();
5757
PrintWriter writer = new PrintWriter(out);
58-
writer.println(NLS.bind(Messages.printArguments, new String[] {
59-
this.referenceBaselineLocation,
60-
this.currentBaselineLocation, this.reportLocation, }));
58+
writer.println(NLS.bind(Messages.printArguments, this.referenceBaselineLocation, this.currentBaselineLocation, this.reportLocation));
6159
throw new BuildException(String.valueOf(out.getBuffer()));
6260
}
6361
if (this.debug) {

0 commit comments

Comments
 (0)