Perform clean code of ui/org.eclipse.pde.core

eclipse-pde-bot · akurtakov · commit 3e02e68390f2 · 2025-05-06T07:18:21.000+03:00
diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/BundleManifestSourceLocationManager.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/BundleManifestSourceLocationManager.java
@@ -251,7 +251,7 @@ public void setPlugins(IPluginModelBase[] externalModels) {
 									try {
 										version = new Version(versionEntry);
 									} catch (IllegalArgumentException e) {
-										PDECore.log(Status.error(NLS.bind(PDECoreMessages.SourceLocationManager_problemProcessingBundleManifestSourceHeader, new Object[] {currentPlugin.getName(), versionEntry, path.toString()}), e));
+										PDECore.log(Status.error(NLS.bind(PDECoreMessages.SourceLocationManager_problemProcessingBundleManifestSourceHeader, currentPlugin.getName(), versionEntry, path.toString()), e));
 
 									}
 									fPluginToSourceBundle.put(new SourceLocationKey(binaryPluginName, version), model);
diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/SourceEntryErrorReporter.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/SourceEntryErrorReporter.java
@@ -496,7 +496,7 @@ private void validateSourceEncodings(List<SourceFolder> toValidate) {
 							String expected = defaultLibraryEncodings.remove(lib);
 							if (expected != null) {
 								if (!specified.equals(expected)) {
-									String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_0, new String[] { expected, specified, lib });
+									String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_0, expected, specified, lib);
 									prepareEncodingError(name, expected, msg, PDEMarkerFactory.B_REPLACE);
 								}
 							} else {
@@ -553,7 +553,7 @@ private void validateSourceEncodings(List<SourceFolder> toValidate) {
 									prepareEncodingError(name, ee.toString(), msg, PDEMarkerFactory.B_REMOVAL);
 								} else {
 									if (!specified.equals(expected)) {
-										String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_7, new String[] { expected, ee.resource().getProjectRelativePath().toString(), specified });
+										String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_7, expected, ee.resource().getProjectRelativePath().toString(), specified);
 										prepareEncodingError(name, ee.toString(), msg, PDEMarkerFactory.M_ONLY_CONFIG_SEV);
 									}
 								}

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ public void setPlugins(IPluginModelBase[] externalModels) {`
`251`	`251`	`try {`
`252`	`252`	`version = new Version(versionEntry);`
`253`	`253`	`} catch (IllegalArgumentException e) {`
`254`		`- PDECore.log(Status.error(NLS.bind(PDECoreMessages.SourceLocationManager_problemProcessingBundleManifestSourceHeader, new Object[] {currentPlugin.getName(), versionEntry, path.toString()}), e));`
	`254`	`+ PDECore.log(Status.error(NLS.bind(PDECoreMessages.SourceLocationManager_problemProcessingBundleManifestSourceHeader, currentPlugin.getName(), versionEntry, path.toString()), e));`
`255`	`255`
`256`	`256`	`}`
`257`	`257`	`fPluginToSourceBundle.put(new SourceLocationKey(binaryPluginName, version), model);`
Original file line number	Diff line number	Diff line change
`@@ -496,7 +496,7 @@ private void validateSourceEncodings(List<SourceFolder> toValidate) {`
`496`	`496`	`String expected = defaultLibraryEncodings.remove(lib);`
`497`	`497`	`if (expected != null) {`
`498`	`498`	`if (!specified.equals(expected)) {`
`499`		`- String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_0, new String[] { expected, specified, lib });`
	`499`	`+ String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_0, expected, specified, lib);`
`500`	`500`	`prepareEncodingError(name, expected, msg, PDEMarkerFactory.B_REPLACE);`
`501`	`501`	`}`
`502`	`502`	`} else {`
`@@ -553,7 +553,7 @@ private void validateSourceEncodings(List<SourceFolder> toValidate) {`
`553`	`553`	`prepareEncodingError(name, ee.toString(), msg, PDEMarkerFactory.B_REMOVAL);`
`554`	`554`	`} else {`
`555`	`555`	`if (!specified.equals(expected)) {`
`556`		`- String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_7, new String[] { expected, ee.resource().getProjectRelativePath().toString(), specified });`
	`556`	`+ String msg = NLS.bind(PDECoreMessages.SourceEntryErrorReporter_7, expected, ee.resource().getProjectRelativePath().toString(), specified);`
`557`	`557`	`prepareEncodingError(name, ee.toString(), msg, PDEMarkerFactory.M_ONLY_CONFIG_SEV);`
`558`	`558`	`}`
`559`	`559`	`}`