Perform clean code of ui/org.eclipse.pde.ui

Author: eclipse-pde-bot

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/bndtools/BndScanner.java

@@ -40,12 +40,12 @@
 public class BndScanner extends RuleBasedScanner {
 	final Set<String>				instructions;
 	final Set<String>				directives	= new HashSet<>();
-	private Token T_DEFAULT;
-	private Token T_KEY;
-	private Token T_ERROR;
-	private Token T_COMMENT;
-	private Token T_INSTRUCTION;
-	private Token T_OPTION;
+	private final Token T_DEFAULT;
+	private final Token T_KEY;
+	private final Token T_ERROR;
+	private final Token T_COMMENT;
+	private final Token T_INSTRUCTION;
+	private final Token T_OPTION;
 
 	public BndScanner(IColorManager colorManager) {
 		T_DEFAULT = new Token(new TextAttribute(colorManager.getColor(IJavaColorConstants.JAVA_DEFAULT)));

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/java/AddPdeClasspathContainerClasspathFixProposal.java

@@ -26,7 +26,7 @@
 
 public class AddPdeClasspathContainerClasspathFixProposal extends ClasspathFixProposal {
 
-	private IJavaProject project;
+	private final IJavaProject project;
 
 	public AddPdeClasspathContainerClasspathFixProposal(IJavaProject project) {
 		this.project = project;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/JavaAttributeWizardPage.java

@@ -44,7 +44,7 @@ public class JavaAttributeWizardPage extends NewClassWizardPage {
 	private final ISchemaAttribute attInfo;
 	private final IPluginModelBase model;
 	private final InitialClassProperties initialValues;
-	private IJavaProject javaProject;
+	private final IJavaProject javaProject;
 
 	static class InitialClassProperties {
 		// populate new wizard page

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/parts/PluginVersionPart.java

@@ -179,7 +179,7 @@ public Object[] getElements(Object inputElement) {
 	private VersionRange fVersionRange;
 	private boolean fIsRanged;
 	private final boolean fRangeAllowed;
-	private boolean isPlugin;
+	private final boolean isPlugin;
 
 	public PluginVersionPart(boolean rangeAllowed) {
 		this(rangeAllowed, false);

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/RepositoryBundleContainerAdapterFactory.java

@@ -117,10 +117,12 @@ public boolean canEdit(ITargetDefinition target, TreePath treePath) {
 			return segment instanceof RepositoryBundleContainer || segment instanceof RequirementNode;
 		}
 
+		@Override
 		public boolean canRemove(ITargetDefinition target, TreePath treePath) {
 			return treePath.getLastSegment() instanceof RequirementNode;
 		}
 
+		@Override
 		public IStatus remove(ITargetDefinition target, TreePath[] treePaths) {
 			boolean reload = false;
 			for (TreePath path : treePaths) {

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/UpdateTargetJob.java

@@ -39,9 +39,9 @@ public class UpdateTargetJob extends Job {
 
 	private final IJobFunction action;
 
-	private boolean update;
+	private final boolean update;
 
-	private Job cancelJob;
+	private final Job cancelJob;
 
 	/**
 	 * Schedules a new update job that will update all selected children of the

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/plugin/TemplateListSelectionPage.java

@@ -57,7 +57,7 @@ public class TemplateListSelectionPage extends WizardListSelectionPage {
 	private final ContentPage fContentPage;
 	private Button fUseTemplate;
 	private String fInitialTemplateId;
-	private Map<Template, CompletableFuture<String>> templateTextLoadings = new HashMap<>();
+	private final Map<Template, CompletableFuture<String>> templateTextLoadings = new HashMap<>();
 
 	class WizardFilter extends ViewerFilter {
 		@Override

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/plugin/TemplatePluginContentWizard.java

@@ -45,7 +45,7 @@
 public class TemplatePluginContentWizard extends Wizard implements IPluginContentWizard {
 
 	private static final String DEFAULT_BND_INSTRUCTION = "bnd.bnd"; //$NON-NLS-1$
-	private Template template;
+	private final Template template;
 	private IFieldData data;
 	private TemplateParamsWizardPage paramsWizardPage;
 

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/tools/ConvertAutomaticManifestProcessor.java

@@ -56,7 +56,7 @@
 
 public class ConvertAutomaticManifestProcessor extends RefactoringProcessor {
 
-	private List<IProject> projects;
+	private final List<IProject> projects;
 	private boolean useProjectRoot;
 	private boolean keepRequireBundle;
 	private boolean keepImportPackage;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/tools/ConvertAutomaticManifestsWizardSettingsPage.java

@@ -32,7 +32,7 @@ public class ConvertAutomaticManifestsWizardSettingsPage extends UserInputWizard
 	private static final String KEY_KEEP_IMPORT_PACKAGE = "keep_import_package"; //$NON-NLS-1$
 	private static final String KEY_KEEP_EXPORT_PACKAGE = "keep_export_package"; //$NON-NLS-1$
 	private static final String KEY_KEEP_REQUIREDEXECUTIONENVIRONMENT = "keep_requiredexecutionenvironment_package"; //$NON-NLS-1$
-	private ConvertAutomaticManifestProcessor processor;
+	private final ConvertAutomaticManifestProcessor processor;
 
 	public ConvertAutomaticManifestsWizardSettingsPage(ConvertAutomaticManifestProcessor processor) {
 		super(PDEUIMessages.ConvertAutomaticManifestWizardPage_title);