Perform clean code of apitools/org.eclipse.pde.api.tools.ui

eclipse-pde-bot · laeubi · commit 4ec80e5c6d0f · 2025-03-18T06:10:51.000+01:00
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiImageDescriptor.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiImageDescriptor.java
@@ -61,11 +61,10 @@ protected Point getSize() {
 	 */
 	@Override
 	public boolean equals(Object object) {
-		if (!(object instanceof ApiImageDescriptor)) {
+		if (!(object instanceof ApiImageDescriptor other)) {
 			return false;
 		}
 
-		ApiImageDescriptor other = (ApiImageDescriptor) object;
 		return (getBaseImage().equals(other.getBaseImage()) && getFlags() == other.getFlags());
 	}
 
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiToolsLabelProvider.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiToolsLabelProvider.java
@@ -66,12 +66,10 @@ public void dispose() {
 
 	@Override
 	public Image getImage(Object element) {
-		if (element instanceof IApiComponent) {
-			IApiComponent comp = (IApiComponent) element;
+		if (element instanceof IApiComponent comp) {
 			return getApiComponentImage(comp);
 		}
-		if (element instanceof IResource) {
-			IResource resource = (IResource) element;
+		if (element instanceof IResource resource) {
 			switch (resource.getType()) {
 				case IResource.FILE:
 					return PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_OBJ_FILE);
@@ -92,8 +90,7 @@ public Image getImage(Object element) {
 		if (element instanceof EEEntry) {
 			return ApiUIPlugin.getSharedImage(IApiToolsConstants.IMG_OBJ_API_SYSTEM_LIBRARY);
 		}
-		if (element instanceof IApiProblemFilter) {
-			IApiProblemFilter filter = (IApiProblemFilter) element;
+		if (element instanceof IApiProblemFilter filter) {
 			IApiProblem problem = filter.getUnderlyingProblem();
 			/*
 			 * int flags = (problem.getSeverity() == ApiPlugin.SEVERITY_ERROR ?
@@ -193,8 +190,7 @@ private Image getApiComponentImage(IApiComponent component) {
 
 	@Override
 	public String getText(Object element) {
-		if (element instanceof IApiComponent) {
-			IApiComponent comp = (IApiComponent) element;
+		if (element instanceof IApiComponent comp) {
 			return MessageFormat.format(Messages.ApiToolsLabelProvider_0, comp.getSymbolicName(), comp.getVersion());
 		}
 		if (element instanceof File) {
@@ -204,8 +200,7 @@ public String getText(Object element) {
 				return ((File) element).getName();
 			}
 		}
-		if (element instanceof IApiBaseline) {
-			IApiBaseline baseline = (IApiBaseline) element;
+		if (element instanceof IApiBaseline baseline) {
 			StringBuilder buffer = new StringBuilder();
 			buffer.append(baseline.getName());
 			if (isDefaultBaseline(baseline)) {
@@ -216,12 +211,10 @@ public String getText(Object element) {
 		if (element instanceof EEEntry) {
 			return ((EEEntry) element).toString();
 		}
-		if (element instanceof IApiProblemFilter) {
-			IApiProblemFilter filter = (IApiProblemFilter) element;
+		if (element instanceof IApiProblemFilter filter) {
 			return filter.getUnderlyingProblem().getMessage();
 		}
-		if (element instanceof IResource) {
-			IResource resource = (IResource) element;
+		if (element instanceof IResource resource) {
 			IPath path = resource.getProjectRelativePath();
 			StringBuilder buffer = new StringBuilder();
 			buffer.append(path.removeFileExtension().lastSegment());
@@ -243,8 +236,7 @@ public String getText(Object element) {
 	 * @return if the profile is the default or not
 	 */
 	protected boolean isDefaultBaseline(Object element) {
-		if (element instanceof IApiBaseline) {
-			IApiBaseline profile = (IApiBaseline) element;
+		if (element instanceof IApiBaseline profile) {
 			IApiBaseline def = ApiPlugin.getDefault().getApiBaselineManager().getDefaultApiBaseline();
 			if (def != null) {
 				return profile.getName().equals(def.getName());
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/CompositeApiImageDescriptor.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/CompositeApiImageDescriptor.java
@@ -92,8 +92,7 @@ protected Point getSize() {
 
 	@Override
 	public boolean equals(Object obj) {
-		if (obj instanceof CompositeApiImageDescriptor) {
-			CompositeApiImageDescriptor other = (CompositeApiImageDescriptor) obj;
+		if (obj instanceof CompositeApiImageDescriptor other) {
 			return (fOriginalImage.equals(other.fOriginalImage) && fFlags == other.fFlags);
 		}
 		return false;
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/JavaElementActionFilter.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/JavaElementActionFilter.java
@@ -28,8 +28,7 @@ public class JavaElementActionFilter implements IActionFilter {
 	@Override
 	public boolean testAttribute(Object target, String name, String value) {
 		if (name.equals("JavaElementActionFilter")) { //$NON-NLS-1$
-			if (target instanceof IJavaElement) {
-				IJavaElement javaElement = (IJavaElement) target;
+			if (target instanceof IJavaElement javaElement) {
 				if (value.equals("isEnabled")) { //$NON-NLS-1$
 					while (javaElement != null) {
 						switch (javaElement.getElementType()) {
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/CompareWithAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/CompareWithAction.java
@@ -41,8 +41,7 @@ public void setActivePart(IAction action, IWorkbenchPart targetPart) {
 	 */
 	@Override
 	public void run(IAction action) {
-		if (this.selection instanceof IStructuredSelection) {
-			final IStructuredSelection structuredSelection = (IStructuredSelection) this.selection;
+		if (this.selection instanceof final IStructuredSelection structuredSelection) {
 			CompareToBaselineWizard wizard = new CompareToBaselineWizard(structuredSelection, ActionMessages.CompareDialogTitle);
 			WizardDialog wdialog = new WizardDialog(workbenchPartSite.getShell(), wizard);
 			wdialog.open();
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/TreeViewerNavigator.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/TreeViewerNavigator.java
@@ -16,7 +16,6 @@
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.jface.viewers.TreeViewer;
-import org.eclipse.pde.api.tools.ui.internal.actions.DeltaSession.TreeNode;
 import org.eclipse.swt.widgets.Tree;
 import org.eclipse.swt.widgets.TreeItem;
 
@@ -187,8 +186,7 @@ private TreeItem[] getSiblings(TreeItem currentItem) {
 
 	private boolean hasMatches(TreeItem item) {
 		Object element = item.getData();
-		if (element instanceof DeltaSession.TreeNode) {
-			TreeNode node = (TreeNode) element;
+		if (element instanceof DeltaSession.TreeNode node) {
 			return node.getData() != null && !node.hasChildren();
 		}
 		return element != null;
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/commands/CompareToBaselineHandler.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/commands/CompareToBaselineHandler.java
@@ -33,8 +33,7 @@ public class CompareToBaselineHandler extends AbstractHandler {
 	@Override
 	public Object execute(ExecutionEvent event) throws ExecutionException {
 		ISelection selection = HandlerUtil.getCurrentSelectionChecked(event);
-		if (selection instanceof IStructuredSelection) {
-			final IStructuredSelection structuredSelection = (IStructuredSelection) selection;
+		if (selection instanceof final IStructuredSelection structuredSelection) {
 			CompareToBaselineWizard wizard = new CompareToBaselineWizard(structuredSelection, ActionMessages.CompareDialogTitle);
 			WizardDialog wdialog = new WizardDialog(HandlerUtil.getActiveShell(event), wizard);
 			wdialog.open();
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/commands/RemoveFiltersHandler.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/commands/RemoveFiltersHandler.java
@@ -49,11 +49,9 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
 	 * @return the {@link IAdaptable} for the current selection context
 	 */
 	private IAdaptable getAdaptable(ISelection selection) {
-		if (selection instanceof IStructuredSelection) {
-			IStructuredSelection ss = (IStructuredSelection) selection;
+		if (selection instanceof IStructuredSelection ss) {
 			Object o = ss.getFirstElement();
-			if (o instanceof IAdaptable) {
-				IAdaptable adapt = (IAdaptable) o;
+			if (o instanceof IAdaptable adapt) {
 				IResource resource = adapt.getAdapter(IResource.class);
 				if (resource != null) {
 					return (resource instanceof IProject ? resource : resource.getProject());
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/completion/APIToolsJavadocCompletionProposalComputer.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/completion/APIToolsJavadocCompletionProposalComputer.java
@@ -293,8 +293,7 @@ private int getType(IJavaElement element) throws JavaModelException {
 		while (lelement != null && lelement.getElementType() != IJavaElement.TYPE) {
 			lelement = lelement.getParent();
 		}
-		if (lelement instanceof IType) {
-			IType type = (IType) lelement;
+		if (lelement instanceof IType type) {
 			if (type.isAnnotation()) {
 				return IApiJavadocTag.TYPE_ANNOTATION;
 			} else if (type.isInterface()) {
@@ -311,8 +310,7 @@ private int getType(IJavaElement element) throws JavaModelException {
 	 * activated on
 	 */
 	private void collectExistingTags(IJavaElement element, JavaContentAssistInvocationContext jcontext) throws JavaModelException {
-		if (element instanceof IMember) {
-			IMember member = (IMember) element;
+		if (element instanceof IMember member) {
 			ICompilationUnit cunit = jcontext.getCompilationUnit();
 			if (cunit != null) {
 				if (cunit.isWorkingCopy()) {
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateBundleVersionOperation.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateBundleVersionOperation.java
@@ -63,14 +63,12 @@ public IStatus run(IProgressMonitor monitor) {
 				ModelModification mod = new ModelModification(file) {
 					@Override
 					protected void modifyModel(IBaseModel model, IProgressMonitor monitor) throws CoreException {
-						if (!(model instanceof IBundlePluginModelBase)) {
+						if (!(model instanceof IBundlePluginModelBase modelBase)) {
 							return;
 						}
-						IBundlePluginModelBase modelBase = (IBundlePluginModelBase) model;
 						IBundle bundle = modelBase.getBundleModel().getBundle();
 						IManifestHeader header = bundle.getManifestHeader(Constants.BUNDLE_VERSION);
-						if (header instanceof BundleVersionHeader) {
-							BundleVersionHeader versionHeader = (BundleVersionHeader) header;
+						if (header instanceof BundleVersionHeader versionHeader) {
 							versionHeader.setValue(fVersion);
 						}
 					}
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateSinceTagOperation.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateSinceTagOperation.java
@@ -97,8 +97,7 @@ public void run(IProgressMonitor monitor) {
 				parser.setSource(compilationUnit);
 				if (intValue <= 0) {
 					// try to use the name range of the corresponding element
-					if (handleElement instanceof IMember) {
-						IMember member = (IMember) handleElement;
+					if (handleElement instanceof IMember member) {
 						ISourceRange range = member.getNameRange();
 						if (range != null) {
 							intValue = range.getOffset();
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiErrorsWarningsConfigurationBlock.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiErrorsWarningsConfigurationBlock.java
@@ -1375,8 +1375,7 @@ private void updateControls() {
 	 */
 	private void enableControl(Control ctrl, boolean enabled) {
 		ctrl.setEnabled(enabled);
-		if (ctrl instanceof Composite) {
-			Composite comp = (Composite) ctrl;
+		if (ctrl instanceof Composite comp) {
 			Control[] children = comp.getChildren();
 			for (Control element : children) {
 				enableControl(element, enabled);
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiUseScanConfigurationBlock.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiUseScanConfigurationBlock.java
@@ -207,8 +207,7 @@ protected final static Key getApiToolsKey(String key) {
 	private final SelectionListener selectionlistener = new SelectionAdapter() {
 		@Override
 		public void widgetSelected(SelectionEvent e) {
-			if (e.widget instanceof Combo) {
-				Combo combo = (Combo) e.widget;
+			if (e.widget instanceof Combo combo) {
 				ControlData data = (ControlData) combo.getData();
 				data.key.setStoredValue(fLookupOrder[0], combo.getText(), fManager);
 				ApiBaselinePreferencePage.rebuildcount = 0;
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/properties/ApiFiltersPropertyPage.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/properties/ApiFiltersPropertyPage.java
@@ -206,8 +206,7 @@ public boolean select(Viewer viewer, Object parentElement, Object element) {
 			fRemoveButton.setEnabled(size > 0);
 			if (size == 1) {
 				Object element = ss.getFirstElement();
-				if (element instanceof IApiProblemFilter) {
-					IApiProblemFilter filter = (IApiProblemFilter) element;
+				if (element instanceof IApiProblemFilter filter) {
 					String comment = filter.getComment();
 					fEditButton.setEnabled(true);
 					if (comment != null) {
@@ -229,8 +228,7 @@ public boolean select(Viewer viewer, Object parentElement, Object element) {
 			if (fViewer.isExpandable(o)) {
 				fViewer.setExpandedState(o, !fViewer.getExpandedState(o));
 			} else {
-				if (o instanceof IApiProblemFilter) {
-					IApiProblemFilter filter = (IApiProblemFilter) o;
+				if (o instanceof IApiProblemFilter filter) {
 					handleEdit(filter);
 				}
 			}
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/views/APIToolingView.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/views/APIToolingView.java
@@ -99,8 +99,7 @@ public void inputChanged(Viewer v, Object oldInput, Object newInput) {
 
 		@Override
 		public Object[] getElements(Object parent) {
-			if (parent instanceof ISession) {
-				ISession session = (ISession) parent;
+			if (parent instanceof ISession session) {
 				if (this.model == null) {
 					this.model = session.getModel();
 				}
@@ -139,8 +138,7 @@ public String getText(Object obj) {
 
 		@Override
 		public Image getImage(Object obj) {
-			if (obj instanceof ITreeNode) {
-				ITreeNode treeNode = (ITreeNode) obj;
+			if (obj instanceof ITreeNode treeNode) {
 				switch (treeNode.getId()) {
 					case ITreeNode.CLASS:
 						return JavaUI.getSharedImages().getImage(org.eclipse.jdt.ui.ISharedImages.IMG_OBJS_CLASS);
@@ -156,8 +154,7 @@ public Image getImage(Object obj) {
 						break;
 				}
 				Object data = treeNode.getData();
-				if (data instanceof IDelta) {
-					IDelta delta = (IDelta) data;
+				if (data instanceof IDelta delta) {
 					Image image = getDeltaElementImage(delta);
 					if (image != null) {
 						int flags = (DeltaProcessor.isCompatible(delta) ? ApiImageDescriptor.SUCCESS : ApiImageDescriptor.ERROR);
@@ -418,8 +415,7 @@ public void run() {
 					} else {
 						APIToolingView.this.viewer.expandToLevel(item, 1);
 					}
-					if (item instanceof ITreeNode) {
-						ITreeNode node = (ITreeNode) item;
+					if (item instanceof ITreeNode node) {
 						if (node.getData() != null && !node.hasChildren()) {
 							// show the Properties view
 							ApiUIPlugin.getDefault().showPropertiesView();
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/CompareOperation.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/CompareOperation.java
@@ -120,8 +120,7 @@ public static ApiScope walkStructureSelection(IStructuredSelection structuredSel
 			return scope;
 		}
 		Arrays.sort(selected, (o1, o2) -> {
-			if (o1 instanceof IJavaElement && o2 instanceof IJavaElement) {
-				IJavaElement element = (IJavaElement) o1;
+			if (o1 instanceof IJavaElement element && o2 instanceof IJavaElement) {
 				IJavaElement element2 = (IJavaElement) o2;
 				return element.getElementType() - element2.getElementType();
 			}
@@ -130,8 +129,7 @@ public static ApiScope walkStructureSelection(IStructuredSelection structuredSel
 		int length = selected.length;
 		for (int i = 0; i < length; i++) {
 			Object currentSelection = selected[i];
-			if (currentSelection instanceof IJavaElement) {
-				IJavaElement element = (IJavaElement) currentSelection;
+			if (currentSelection instanceof IJavaElement element) {
 				IJavaProject javaProject = element.getJavaProject();
 				try {
 					switch (element.getElementType()) {
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/CompareToBaselineWizardPage.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/CompareToBaselineWizardPage.java
@@ -182,8 +182,7 @@ private void restoreComboSelection(Combo combo, String id, IDialogSettings setti
 	 */
 	IAdaptable getAdaptable() {
 		Object o = this.selection.getFirstElement();
-		if (o instanceof IAdaptable) {
-			IAdaptable adapt = (IAdaptable) o;
+		if (o instanceof IAdaptable adapt) {
 			IResource resource = adapt.getAdapter(IResource.class);
 			if (resource != null) {
 				return (resource instanceof IProject ? resource : resource.getProject());
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/DirectoryBasedApiBaselineWizardPage.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/DirectoryBasedApiBaselineWizardPage.java
@@ -186,8 +186,7 @@ public void createControl(Composite parent) {
 		treeviewer.addFilter(new ViewerFilter() {
 			@Override
 			public boolean select(Viewer viewer, Object parentElement, Object element) {
-				if (element instanceof IApiComponent) {
-					IApiComponent component = (IApiComponent) element;
+				if (element instanceof IApiComponent component) {
 					try {
 						if (component.isSourceComponent() || component.isSystemComponent()) {
 							return false;
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/JavadocConversionPage.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/JavadocConversionPage.java
@@ -283,8 +283,7 @@ protected Object[] getWorkbenchSelection() {
 								Object[] jps = ((IStructuredSelection) provider.getSelection()).toArray();
 								ArrayList<IProject> pjs = new ArrayList<>();
 								for (Object jp : jps) {
-									if (jp instanceof IAdaptable) {
-										IAdaptable adapt = (IAdaptable) jp;
+									if (jp instanceof IAdaptable adapt) {
 										IProject pj = adapt.getAdapter(IProject.class);
 										if (Util.isApiProject(pj)) {
 											pjs.add(pj);
diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/TargetBasedApiBaselineWizardPage.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/TargetBasedApiBaselineWizardPage.java
@@ -246,8 +246,7 @@ public int compare(Viewer viewer, Object e1, Object e2) {
 		treeviewer.addFilter(new ViewerFilter() {
 			@Override
 			public boolean select(Viewer viewer, Object parentElement, Object element) {
-				if (element instanceof IApiComponent) {
-					IApiComponent component = (IApiComponent) element;
+				if (element instanceof IApiComponent component) {
 					try {
 						if (component.isSourceComponent() || component.isSystemComponent()) {
 							return false;

Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,10 @@ protected Point getSize() {`
`61`	`61`	`*/`
`62`	`62`	`@Override`
`63`	`63`	`public boolean equals(Object object) {`
`64`		`- if (!(object instanceof ApiImageDescriptor)) {`
	`64`	`+ if (!(object instanceof ApiImageDescriptor other)) {`
`65`	`65`	`return false;`
`66`	`66`	`}`
`67`	`67`
`68`		`- ApiImageDescriptor other = (ApiImageDescriptor) object;`
`69`	`68`	`return (getBaseImage().equals(other.getBaseImage()) && getFlags() == other.getFlags());`
`70`	`69`	`}`
`71`	`70`
Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,7 @@ protected Point getSize() {`
`92`	`92`
`93`	`93`	`@Override`
`94`	`94`	`public boolean equals(Object obj) {`
`95`		`- if (obj instanceof CompositeApiImageDescriptor) {`
`96`		`- CompositeApiImageDescriptor other = (CompositeApiImageDescriptor) obj;`
	`95`	`+ if (obj instanceof CompositeApiImageDescriptor other) {`
`97`	`96`	`return (fOriginalImage.equals(other.fOriginalImage) && fFlags == other.fFlags);`
`98`	`97`	`}`
`99`	`98`	`return false;`
Original file line number	Diff line number	Diff line change
`@@ -63,14 +63,12 @@ public IStatus run(IProgressMonitor monitor) {`
`63`	`63`	`ModelModification mod = new ModelModification(file) {`
`64`	`64`	`@Override`
`65`	`65`	`protected void modifyModel(IBaseModel model, IProgressMonitor monitor) throws CoreException {`
`66`		`- if (!(model instanceof IBundlePluginModelBase)) {`
	`66`	`+ if (!(model instanceof IBundlePluginModelBase modelBase)) {`
`67`	`67`	`return;`
`68`	`68`	`}`
`69`		`- IBundlePluginModelBase modelBase = (IBundlePluginModelBase) model;`
`70`	`69`	`IBundle bundle = modelBase.getBundleModel().getBundle();`
`71`	`70`	`IManifestHeader header = bundle.getManifestHeader(Constants.BUNDLE_VERSION);`
`72`		`- if (header instanceof BundleVersionHeader) {`
`73`		`- BundleVersionHeader versionHeader = (BundleVersionHeader) header;`
	`71`	`+ if (header instanceof BundleVersionHeader versionHeader) {`
`74`	`72`	`versionHeader.setValue(fVersion);`
`75`	`73`	`}`
`76`	`74`	`}`