Perform clean code of ui/org.eclipse.pde.ui

Author: eclipse-pde-bot

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/dialogs/FeatureSelectionDialog.java

@@ -134,8 +134,7 @@ private int getId(Object element) {
 		}
 
 		private int compareSimilarObjects(Object o1, Object o2) {
-			if (o1 instanceof IFeatureModel ipmb1 && o2 instanceof IFeatureModel) {
-				IFeatureModel ipmb2 = (IFeatureModel) o2;
+			if (o1 instanceof IFeatureModel ipmb1 && o2 instanceof IFeatureModel ipmb2) {
 				return compareFeatures(ipmb1.getFeature(), ipmb2.getFeature());
 			}
 			return 0;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/dialogs/PluginSelectionDialog.java

@@ -105,8 +105,7 @@ private int getId(Object element) {
 		}
 
 		private int compareSimilarObjects(Object o1, Object o2) {
-			if (o1 instanceof IPluginModelBase ipmb1 && o2 instanceof IPluginModelBase) {
-				IPluginModelBase ipmb2 = (IPluginModelBase) o2;
+			if (o1 instanceof IPluginModelBase ipmb1 && o2 instanceof IPluginModelBase ipmb2) {
 				return comparePlugins(ipmb1.getPluginBase(), ipmb2.getPluginBase());
 			}
 			return 0;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/KeyValueSourcePage.java

@@ -31,8 +31,7 @@ public ViewerComparator createDefaultOutlineComparator() {
 		return new ViewerComparator() {
 			@Override
 			public int compare(Viewer viewer, Object e1, Object e2) {
-				if ((e1 instanceof IDocumentKey key1) && (e2 instanceof IDocumentKey)) {
-					IDocumentKey key2 = (IDocumentKey) e2;
+				if ((e1 instanceof IDocumentKey key1) && (e2 instanceof IDocumentKey key2)) {
 					return Integer.compare(key1.getOffset(), key2.getOffset());
 				}
 				// Bundle manifest header elements

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/contentassist/TypePackageCompletionProcessor.java

@@ -246,8 +246,7 @@ private Comparator<Object> getComparator() {
 			fComparator = new Comparator<>() {
 				@Override
 				public int compare(Object arg0, Object arg1) {
-					if (arg0 instanceof ICompletionProposal p1 && arg1 instanceof ICompletionProposal) {
-						ICompletionProposal p2 = (ICompletionProposal) arg1;
+					if (arg0 instanceof ICompletionProposal p1 && arg1 instanceof ICompletionProposal p2) {
 						return getSortKey(p1).compareToIgnoreCase(getSortKey(p2));
 					}
 					return 0;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/PluginInputContextManager.java

@@ -136,8 +136,7 @@ private void bundleRemoved(InputContext bundleContext) {
 	}
 
 	private void transferListeners(IModel source, IModel target) {
-		if (source instanceof IModelChangeProviderExtension smodel && target instanceof IModelChangeProviderExtension) {
-			IModelChangeProviderExtension tmodel = (IModelChangeProviderExtension) target;
+		if (source instanceof IModelChangeProviderExtension smodel && target instanceof IModelChangeProviderExtension tmodel) {
 			// first fire one last event to all the listeners to
 			// refresh
 			smodel.fireModelChanged(new ModelChangedEvent(smodel, IModelChangedEvent.WORLD_CHANGED, null, null));

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/preferences/PDECompilersConfigurationBlock.java

@@ -345,8 +345,7 @@ public static Key[] getAllKeys() {
 	 * Default selection listener for combo and check controls
 	 */
 	private final SelectionListener selectionlistener = widgetSelectedAdapter(e -> {
-		if (e.widget instanceof Combo) {
-			Combo combo = (Combo) e.widget;
+		if (e.widget instanceof Combo combo) {
 			ControlData data = (ControlData) combo.getData();
 			int selectionIndex = combo.getSelectionIndex();
 			selectionIndex = adjustIndex(selectionIndex);
@@ -366,8 +365,7 @@ public static Key[] getAllKeys() {
 	 * Default modify listener for text controls
 	 */
 	private final ModifyListener modifylistener = e -> {
-		if (e.widget instanceof Text) {
-			Text text = (Text) e.widget;
+		if (e.widget instanceof Text text) {
 			ControlData data = (ControlData) text.getData();
 			data.key.setStoredValue(fLookupOrder[0], text.getText().trim(), fManager);
 			fDirty = true;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/search/dialogs/FilteredPluginArtifactsSelectionDialog.java

@@ -764,30 +764,25 @@ private int getId(Object element) {
 		}
 
 		private int compareSimilarObjects(Object o1, Object o2) {
-			if (o1 instanceof IPluginModelBase ipmb1 && o2 instanceof IPluginModelBase) {
-				IPluginModelBase ipmb2 = (IPluginModelBase) o2;
+			if (o1 instanceof IPluginModelBase ipmb1 && o2 instanceof IPluginModelBase ipmb2) {
 				return comparePlugins(ipmb1.getPluginBase(), ipmb2.getPluginBase());
-			} else if (o1 instanceof IPluginExtensionPoint ipep1 && o2 instanceof IPluginExtensionPoint) {
-				IPluginExtensionPoint ipep2 = (IPluginExtensionPoint) o2;
+			} else if (o1 instanceof IPluginExtensionPoint ipep1 && o2 instanceof IPluginExtensionPoint ipep2) {
 				return compareExtensionPoints(ipep1, ipep2);
-			} else if (o1 instanceof IPluginExtension ipe1 && o2 instanceof IPluginExtension) {
-				IPluginExtension ipe2 = (IPluginExtension) o2;
+			} else if (o1 instanceof IPluginExtension ipe1 && o2 instanceof IPluginExtension ipe2) {
 				int comparePointsResult = ipe1.getPoint().compareTo(ipe2.getPoint());
 				if (comparePointsResult == 0) {
 					return comparePlugins(ipe1.getPluginBase(), ipe2.getPluginBase());
 				}
 				// else
 				return comparePointsResult;
-			} else if (o1 instanceof ExportPackageDescription epd1 && o2 instanceof ExportPackageDescription) {
-				ExportPackageDescription epd2 = (ExportPackageDescription) o2;
+			} else if (o1 instanceof ExportPackageDescription epd1 && o2 instanceof ExportPackageDescription epd2) {
 				int compareNamesResult = epd1.getName().compareTo(epd2.getName());
 				if (compareNamesResult == 0) {
 					return compareBundleDescriptions(epd1.getSupplier(), epd2.getSupplier());
 				}
 				// else
 				return compareNamesResult;
-			} else if (o1 instanceof IFeatureModel ifm1 && o2 instanceof IFeatureModel) {
-				IFeatureModel ifm2 = (IFeatureModel) o2;
+			} else if (o1 instanceof IFeatureModel ifm1 && o2 instanceof IFeatureModel ifm2) {
 				return compareFeatures(ifm1, ifm2);
 			}
 			return 0;

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/features/viewer/FeatureChildViewerFilter.java

@@ -21,8 +21,7 @@ public class FeatureChildViewerFilter extends ViewerFilter {
 
 	@Override
 	public boolean select(Viewer viewer, Object parentElement, Object element) {
-		if (parentElement instanceof DeferredFeaturesViewInput input && element instanceof IFeatureModel) {
-			IFeatureModel featureModel = (IFeatureModel) element;
+		if (parentElement instanceof DeferredFeaturesViewInput input && element instanceof IFeatureModel featureModel) {
 			boolean showProducts = input.getFeaturesViewInput().isIncludeProducts();
 
 			String featureId = featureModel.getFeature().getId();