AbstractBundleContainer.java - Caching & Performance

  Optimizations:
  - Line 72: Renamed poorly-named static field hash to fVMArgsCache with
proper documentation - much clearer intent
  - Line 229-233: Replaced inefficient loop through hash entries (for
(Entry<...> entry : hash.entrySet())) with direct HashMap get() - O(n) →
O(1) lookup
  - Line 268, 271: Updated all references to use the renamed
fVMArgsCache

  Impact:
  - Major performance improvement: Changed from O(n) iteration through
all cache entries to O(1) HashMap lookup
  - Better code clarity with descriptive naming
  - No API changes - purely internal optimization

Author: vogella

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/AbstractBundleContainer.java

@@ -17,7 +17,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.util.HashMap;
-import java.util.Map.Entry;
 
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
@@ -66,7 +65,10 @@ public abstract class AbstractBundleContainer extends PlatformObject implements
 	 */
 	private String[] fVMArgs;
 
-	static private HashMap<AbstractBundleContainer, String[]> hash = new HashMap<>();
+	/**
+	 * Cache for VM arguments to avoid repeated expensive resolution
+	 */
+	private static final HashMap<AbstractBundleContainer, String[]> fVMArgsCache = new HashMap<>();
 
 	/**
 	 * Resolves any string substitution variables in the given text returning
@@ -223,11 +225,12 @@ protected void clearResolutionStatus() {
 
 	@Override
 	public String[] getVMArguments() {
-		for (Entry<AbstractBundleContainer, String[]> entry : hash.entrySet()) {
-			if (entry.getKey().equals(this)) {
-				return entry.getValue();
-			}
+		// Check cache first for faster lookup
+		String[] cachedArgs = fVMArgsCache.get(this);
+		if (cachedArgs != null) {
+			return cachedArgs;
 		}
+
 		String FWK_ADMIN_EQ = "org.eclipse.equinox.frameworkadmin.equinox"; //$NON-NLS-1$
 		if (fVMArgs == null) {
 			try {
@@ -261,10 +264,10 @@ public String[] getVMArguments() {
 
 		}
 		if (fVMArgs == null || fVMArgs.length == 0) {
-			hash.put(this, null);
+			fVMArgsCache.put(this, null);
 			return null;
 		}
-		hash.put(this, fVMArgs);
+		fVMArgsCache.put(this, fVMArgs);
 		return fVMArgs;
 	}