Skip to content

Commit 668886e

Browse files
committed
Fix ImageBrowserView combos popup transparency
On Fedora 43 system SWT.COLOR_LIST_BACKGROUND comes with transparency set and this misrenders combos popup as the color is inherited by children. Not setting any color at all is the simplest and most naturally fitting choice to fix the problem.
1 parent b95aeca commit 668886e

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/imagebrowser/ImageBrowserView.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2012, 2018 Christian Pontesegger and others.
2+
* Copyright (c) 2012, 2025 Christian Pontesegger and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -167,7 +167,6 @@ public ImageBrowserView() {
167167
public void createPartControl(final Composite parent) {
168168
final Composite composite = SWTFactory.createComposite(parent, 1, 1, GridData.FILL_BOTH, 0, 0);
169169
PlatformUI.getWorkbench().getHelpSystem().setHelp(composite, IHelpContextIds.IMAGE_BROWSER_VIEW);
170-
composite.setBackground(parent.getDisplay().getSystemColor(SWT.COLOR_LIST_BACKGROUND));
171170
Composite topComp = new Composite(composite, SWT.NONE);
172171
RowLayout layout = new RowLayout();
173172
// need to center vertically, otherwise its looks misaligned
@@ -231,12 +230,9 @@ public void createPartControl(final Composite parent) {
231230
spinMaxImages.setSelection(250);
232231
spinMaxImages.setLayoutData(GridDataFactory.fillDefaults().create());
233232
spinMaxImages.addModifyListener(e -> {
234-
Display.getCurrent().asyncExec(new Runnable() {
235-
@Override
236-
public void run() {
237-
page = 0; // reset to 1st page
238-
scanImages();
239-
}
233+
Display.getCurrent().asyncExec(() -> {
234+
page = 0; // reset to 1st page
235+
scanImages();
240236
});
241237
});
242238

0 commit comments

Comments
 (0)